Github user walterddr commented on a diff in the pull request:
https://github.com/apache/flink/pull/6201#discussion_r200523824
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/schema/TableSourceSinkTable.scala
---
@@ -0,0 +1,43
Github user walterddr commented on a diff in the pull request:
https://github.com/apache/flink/pull/6201#discussion_r200522491
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/BatchTableEnvironment.scala
---
@@ -160,10 +173,34 @@ abstract class
Github user walterddr commented on a diff in the pull request:
https://github.com/apache/flink/pull/6201#discussion_r200524149
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/connector/TableConnectorFactoryService.scala
---
@@ -16,57 +16,57
Github user walterddr commented on a diff in the pull request:
https://github.com/apache/flink/pull/6201#discussion_r200521017
--- Diff:
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/config/Environment.java
---
@@ -56,23 +58,44 @@ public Environment
Github user walterddr commented on a diff in the pull request:
https://github.com/apache/flink/pull/6201#discussion_r200524249
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/TableSinkDescriptor.scala
---
@@ -0,0 +1,30
Github user walterddr commented on a diff in the pull request:
https://github.com/apache/flink/pull/6201#discussion_r200524110
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/connector/TableConnectorFactoryService.scala
---
@@ -16,57 +16,57
Github user walterddr commented on a diff in the pull request:
https://github.com/apache/flink/pull/6201#discussion_r200523261
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/connector/TableConnectorFactory.scala
---
@@ -16,21 +16,18
Github user walterddr commented on a diff in the pull request:
https://github.com/apache/flink/pull/6201#discussion_r200521222
--- Diff:
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/config/Environment.java
---
@@ -56,23 +58,44 @@ public Environment
Github user walterddr commented on a diff in the pull request:
https://github.com/apache/flink/pull/6188#discussion_r199352237
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/scala/expressionDsl.scala
---
@@ -1029,6 +1029,29 @@ object
Github user walterddr commented on a diff in the pull request:
https://github.com/apache/flink/pull/6188#discussion_r197622239
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/time.scala
---
@@ -328,6 +330,42 @@ case class TemporalOverlaps
Github user walterddr commented on a diff in the pull request:
https://github.com/apache/flink/pull/6188#discussion_r197613995
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/time.scala
---
@@ -328,6 +330,42 @@ case class TemporalOverlaps
Github user walterddr commented on a diff in the pull request:
https://github.com/apache/flink/pull/6188#discussion_r197613915
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/time.scala
---
@@ -328,6 +330,42 @@ case class TemporalOverlaps
Github user walterddr commented on a diff in the pull request:
https://github.com/apache/flink/pull/6188#discussion_r197613157
--- Diff: docs/dev/table/tableApi.md ---
@@ -2804,6 +2804,17 @@ dateFormat(TIMESTAMP, STRING
Github user walterddr commented on a diff in the pull request:
https://github.com/apache/flink/pull/6188#discussion_r197614566
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/time.scala
---
@@ -328,6 +330,42 @@ case class TemporalOverlaps
Github user walterddr commented on the issue:
https://github.com/apache/flink/pull/6049
Thanks for the comment @zentol . I actually thought about it and think we
should group same jobs status listings together, there are also some other
non-terminating states as well. Regarding
Github user walterddr commented on a diff in the pull request:
https://github.com/apache/flink/pull/6049#discussion_r192778560
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java ---
@@ -474,6 +482,19 @@ protected void list(String[] args) throws
Github user walterddr commented on a diff in the pull request:
https://github.com/apache/flink/pull/5863#discussion_r190788353
--- Diff: flink-end-to-end-tests/test-scripts/test_cli_api.sh ---
@@ -0,0 +1,196 @@
+#!/usr/bin/env bash
Github user walterddr commented on a diff in the pull request:
https://github.com/apache/flink/pull/5863#discussion_r190433925
--- Diff: flink-end-to-end-tests/test-scripts/test_cli_api.sh ---
@@ -0,0 +1,155 @@
+#!/usr/bin/env bash
Github user walterddr commented on a diff in the pull request:
https://github.com/apache/flink/pull/5998#discussion_r190124815
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/setop/StreamIntersectCoProcessFunction.scala
---
@@ -0,0 +1,236
Github user walterddr commented on a diff in the pull request:
https://github.com/apache/flink/pull/5998#discussion_r190124755
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/setop/StreamIntersectCoProcessFunction.scala
---
@@ -0,0 +1,236
Github user walterddr commented on a diff in the pull request:
https://github.com/apache/flink/pull/5998#discussion_r190120842
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/setop/StreamIntersectCoProcessFunction.scala
---
@@ -0,0 +1,236
Github user walterddr commented on a diff in the pull request:
https://github.com/apache/flink/pull/5998#discussion_r190119234
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamIntersect.scala
---
@@ -0,0 +1,116
Github user walterddr commented on a diff in the pull request:
https://github.com/apache/flink/pull/5998#discussion_r190123516
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/setop/StreamIntersectCoProcessFunction.scala
---
@@ -0,0 +1,236
Github user walterddr commented on a diff in the pull request:
https://github.com/apache/flink/pull/5998#discussion_r190122671
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/setop/StreamIntersectCoProcessFunction.scala
---
@@ -0,0 +1,236
Github user walterddr commented on a diff in the pull request:
https://github.com/apache/flink/pull/5998#discussion_r190119548
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamIntersect.scala
---
@@ -0,0 +1,116
Github user walterddr commented on the issue:
https://github.com/apache/flink/pull/5849
Thanks @tzulitai for the suggestion. I will close this and continue with
the new PR in #6054 .
---
Github user walterddr closed the pull request at:
https://github.com/apache/flink/pull/5849
---
GitHub user walterddr opened a pull request:
https://github.com/apache/flink/pull/6054
[FLINK-8986][e2e-test] Flink end to end test REST API
## What is the purpose of the change
Adding end to end test for REST APIs for FLIP-6 generated endpoints.
*This is a follow
Github user walterddr commented on the issue:
https://github.com/apache/flink/pull/6049
@zentol yeah, I totally agree with the naming issue and just updated with a
more clear `ListOptions` definitions. Please take another look.
Thanks
---
Github user walterddr commented on a diff in the pull request:
https://github.com/apache/flink/pull/5863#discussion_r189673647
--- Diff: flink-end-to-end-tests/test-scripts/test_cli_api.sh ---
@@ -0,0 +1,155 @@
+#!/usr/bin/env bash
GitHub user walterddr opened a pull request:
https://github.com/apache/flink/pull/6049
[FLINK-9398][Client] Fix CLI list running job returns all except scheduled
jobs
## What is the purpose of the change
This PR fixes CLI command `bin/flink list -r` returning all
Github user walterddr commented on the issue:
https://github.com/apache/flink/pull/5849
Hi @tzulitai . I've actually created a new version of the test based on
@zentol 's comment on this PR:
https://github.com/walterddr/flink/compare/FLINK-8985...walterddr:FLINK-8986-test
Github user walterddr commented on the issue:
https://github.com/apache/flink/pull/5863
Thanks @tzulitai for the review. I will update asap.
I am not 100% sure whether I should verify the CLI return but I would
definitely add them.
---
Github user walterddr commented on the issue:
https://github.com/apache/flink/pull/6007
Wasn't sure this is the full PR or just partial implementation, but I don't
see `EPOCH` or `DECADE` in main or test though.
---
Github user walterddr commented on a diff in the pull request:
https://github.com/apache/flink/pull/5985#discussion_r187459062
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/AccumulatorsIncludeSerializedValueQueryParameter.java
---
@@ -38,4 +38,10
Github user walterddr commented on a diff in the pull request:
https://github.com/apache/flink/pull/5985#discussion_r187460147
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/SubtaskIndexPathParameter.java
---
@@ -44,4 +44,9 @@ protected String
Github user walterddr commented on a diff in the pull request:
https://github.com/apache/flink/pull/5985#discussion_r187458764
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/SavepointPathQueryParameter.java
---
@@ -28,4 +28,9
Github user walterddr commented on the issue:
https://github.com/apache/flink/pull/5940
LOL. I think I found a way:
1. Rebase #3764 over to current master;
2. Rebase this branch to the rebased #3764;
3. Make changes on top
:-)
---
Github user walterddr commented on the issue:
https://github.com/apache/flink/pull/5940
Thanks @suez1224 @fhueske for the comments. I will change them accordingly.
Yes I copied a lot of test cases from @haohui's PR for my own testing. I
can definitely put it on top given
Github user walterddr commented on a diff in the pull request:
https://github.com/apache/flink/pull/5913#discussion_r184861354
--- Diff: docs/dev/table/sqlClient.md ---
@@ -0,0 +1,539 @@
+---
+title: "SQL Client"
+nav-parent_id: tableapi
+nav-pos: 100
Github user walterddr commented on a diff in the pull request:
https://github.com/apache/flink/pull/5913#discussion_r184861107
--- Diff: docs/dev/table/sqlClient.md ---
@@ -0,0 +1,539 @@
+---
+title: "SQL Client"
+nav-parent_id: tableapi
+nav-pos: 100
Github user walterddr commented on a diff in the pull request:
https://github.com/apache/flink/pull/5913#discussion_r184860963
--- Diff: docs/dev/table/sqlClient.md ---
@@ -0,0 +1,539 @@
+---
+title: "SQL Client"
+nav-parent_id: tableapi
+nav-pos: 100
Github user walterddr commented on a diff in the pull request:
https://github.com/apache/flink/pull/5913#discussion_r184860924
--- Diff: docs/dev/table/sqlClient.md ---
@@ -0,0 +1,538 @@
+---
+title: "SQL Client"
+nav-parent_id: tableapi
+nav-pos: 100
Github user walterddr commented on a diff in the pull request:
https://github.com/apache/flink/pull/5913#discussion_r184860868
--- Diff: docs/dev/table/sqlClient.md ---
@@ -0,0 +1,538 @@
+---
+title: "SQL Client"
+nav-parent_id: tableapi
+nav-pos: 100
Github user walterddr commented on a diff in the pull request:
https://github.com/apache/flink/pull/5913#discussion_r184860810
--- Diff: docs/dev/table/sqlClient.md ---
@@ -0,0 +1,539 @@
+---
+title: "SQL Client"
+nav-parent_id: tableapi
+nav-pos: 100
GitHub user walterddr opened a pull request:
https://github.com/apache/flink/pull/5940
[FLINK-8690][table]Support DistinctAgg on DataStream
## What is the purpose of the change
* Allow FlinkLogicalAggregate to support distinct aggregations on
DataStream, while keeping
Github user walterddr commented on a diff in the pull request:
https://github.com/apache/flink/pull/#discussion_r184441869
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/DistinctAccumulator.scala
---
@@ -47,60 +51,51
Github user walterddr commented on a diff in the pull request:
https://github.com/apache/flink/pull/#discussion_r184429742
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/stream/sql/OverWindowITCase.scala
---
@@ -50,6 +50,155 @@ class
Github user walterddr commented on a diff in the pull request:
https://github.com/apache/flink/pull/#discussion_r184428065
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/stream/sql/OverWindowITCase.scala
---
@@ -50,6 +50,155 @@ class
Github user walterddr commented on a diff in the pull request:
https://github.com/apache/flink/pull/#discussion_r184115873
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala
---
@@ -151,8 +157,36 @@ class
Github user walterddr commented on a diff in the pull request:
https://github.com/apache/flink/pull/#discussion_r184125030
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/DistinctAccumulator.scala
---
@@ -0,0 +1,106
Github user walterddr commented on a diff in the pull request:
https://github.com/apache/flink/pull/#discussion_r184115947
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala
---
@@ -151,8 +157,36 @@ class
Github user walterddr commented on a diff in the pull request:
https://github.com/apache/flink/pull/#discussion_r183880939
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala
---
@@ -151,8 +157,15 @@ class
Github user walterddr commented on a diff in the pull request:
https://github.com/apache/flink/pull/#discussion_r183222089
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
@@ -1439,7 +1467,47 @@ object
Github user walterddr commented on a diff in the pull request:
https://github.com/apache/flink/pull/#discussion_r183222353
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala
---
@@ -327,19 +392,41 @@ class
Github user walterddr commented on a diff in the pull request:
https://github.com/apache/flink/pull/#discussion_r183222457
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/OverAggregate.scala
---
@@ -70,7 +70,12 @@ trait OverAggregate
Github user walterddr commented on a diff in the pull request:
https://github.com/apache/flink/pull/#discussion_r183222451
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/DistinctAccumulator.scala
---
@@ -0,0 +1,102
Github user walterddr commented on a diff in the pull request:
https://github.com/apache/flink/pull/#discussion_r183222077
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
@@ -1439,7 +1467,47 @@ object
Github user walterddr commented on a diff in the pull request:
https://github.com/apache/flink/pull/#discussion_r18367
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala
---
@@ -151,8 +157,15 @@ class
Github user walterddr commented on a diff in the pull request:
https://github.com/apache/flink/pull/#discussion_r183598006
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/stream/sql/OverWindowITCase.scala
---
@@ -50,6 +50,155 @@ class
Github user walterddr commented on a diff in the pull request:
https://github.com/apache/flink/pull/#discussion_r183222573
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/stream/sql/OverWindowITCase.scala
---
@@ -50,6 +51,96 @@ class
Github user walterddr commented on the issue:
https://github.com/apache/flink/pull/
Thanks @fhueske, I had the exact same feeling. Just attaching `MapState`
towards the back of the `Row` might be a current working solution for now, but
will probably be nasty to maintain
Github user walterddr commented on the issue:
https://github.com/apache/flink/pull/
Hi @fhueske . Thanks for the review, all very good points. I will follow up
with the next steps. Actually @hequn8128 and I had some discussions regarding
the follow up in FLINK-8690 already and I
Github user walterddr commented on the issue:
https://github.com/apache/flink/pull/5867
Hi @twalthr, having JVM heap size configurable is definitely a great
benefit. Just to clarify, this is only changing the Client JVM heap size,
correct? I am assuming this is mainly
Github user walterddr commented on the issue:
https://github.com/apache/flink/pull/5865
thx @zentol , sorry I had to skip checkstyle and test to speed up the
build. just fixed
---
GitHub user walterddr opened a pull request:
https://github.com/apache/flink/pull/5865
[FLINK-9199][REST][hot-fix] handler and paramter typos
[hot-fix] fix message header / handler and parameter typos.
You can merge this pull request into a Git repository by running:
$ git
GitHub user walterddr opened a pull request:
https://github.com/apache/flink/pull/5863
[FLINK-8985][e2etest] initial support for End-to-end CLI test, excluding
YARN test
## What is the purpose of the change
Adding end to end test for CLI APIs.
## Brief change log
Github user walterddr commented on the issue:
https://github.com/apache/flink/pull/5849
At this moment it skips 8 of the 39 tests (PATCH & POST methods). And
there's 2 test failures and I think should be fix in another JIRA. Namely,
`/jobs/:jobid/vertices/:vertexid/subt
GitHub user walterddr opened a pull request:
https://github.com/apache/flink/pull/5849
[FLINK-8986][e2e-test] Flink end to end test REST API
## What is the purpose of the change
Adding end to end test for REST APIs for FLIP-6 generated endpoints
## Brief change
Github user walterddr commented on a diff in the pull request:
https://github.com/apache/flink/pull/5758#discussion_r179178156
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/TableDescriptor.scala
---
@@ -0,0 +1,75
Github user walterddr commented on a diff in the pull request:
https://github.com/apache/flink/pull/5797#discussion_r178913403
--- Diff:
flink-docs/src/main/java/org/apache/flink/docs/rest/RestAPIDocGenerator.java ---
@@ -258,6 +265,37 @@ private static String
GitHub user walterddr opened a pull request:
https://github.com/apache/flink/pull/5797
[Flink 9104][doc]Re-generate REST API documentation for FLIP-6
## What is the purpose of the change
Fix REST-API doc generator and regenerate rest_dispatcher.html
## Brief change
Github user walterddr commented on the issue:
https://github.com/apache/flink/pull/5796
Wrong base
---
Github user walterddr closed the pull request at:
https://github.com/apache/flink/pull/5796
---
GitHub user walterddr opened a pull request:
https://github.com/apache/flink/pull/5796
[Flink 9104][doc]Re-generate REST API documentation for FLIP-6
## What is the purpose of the change
Fix REST-API doc generator and regenerate rest_dispatcher.html
## Brief
Github user walterddr commented on a diff in the pull request:
https://github.com/apache/flink/pull/5758#discussion_r178334028
--- Diff:
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/config/Environment.java
---
@@ -29,38 +30,47
Github user walterddr commented on a diff in the pull request:
https://github.com/apache/flink/pull/5758#discussion_r178334057
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/TableDescriptor.scala
---
@@ -0,0 +1,75
Github user walterddr commented on a diff in the pull request:
https://github.com/apache/flink/pull/5758#discussion_r177830071
--- Diff:
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/config/Environment.java
---
@@ -102,10 +112,10 @@ public static
Github user walterddr commented on a diff in the pull request:
https://github.com/apache/flink/pull/5758#discussion_r177828794
--- Diff:
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/config/Environment.java
---
@@ -29,38 +30,47
Github user walterddr commented on a diff in the pull request:
https://github.com/apache/flink/pull/5758#discussion_r177836030
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/TableDescriptor.scala
---
@@ -0,0 +1,75
Github user walterddr commented on the issue:
https://github.com/apache/flink/pull/5750
Based on the umbrella task link FLINK-8970, it seems like this e2e test
should be attached to FLINK-8973 instead?
---
Github user walterddr commented on the issue:
https://github.com/apache/flink/pull/5638
Thanks for the explanation @buptljy. Yeah if that's the case the only way
to validate is via ITCase, it might be an overkill in this situation though.
---
Github user walterddr commented on a diff in the pull request:
https://github.com/apache/flink/pull/5706#discussion_r175825522
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/logical/FlinkLogicalWindowAggregate.scala
---
@@ -103,6 +106,22
Github user walterddr commented on a diff in the pull request:
https://github.com/apache/flink/pull/5688#discussion_r175317673
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sinks/QueryableTableSink.scala
---
@@ -0,0 +1,162 @@
+/*
+ * Licensed
Github user walterddr commented on a diff in the pull request:
https://github.com/apache/flink/pull/5688#discussion_r175315979
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sinks/QueryableTableSink.scala
---
@@ -0,0 +1,162 @@
+/*
+ * Licensed
Github user walterddr commented on a diff in the pull request:
https://github.com/apache/flink/pull/5638#discussion_r175296949
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/scala/expressionDsl.scala
---
@@ -1130,4 +1130,13 @@ object concat_ws
Github user walterddr commented on a diff in the pull request:
https://github.com/apache/flink/pull/5706#discussion_r175296744
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/logical/FlinkLogicalWindowAggregate.scala
---
@@ -103,6 +106,22
Github user walterddr commented on the issue:
https://github.com/apache/flink/pull/
Thanks @hequn8128 for the prompt review.
Are you suggesting we created the mapView parallel with the accumulator?
The reason why I kept `DistinctAccumulator` is to act as a delegate to enclose
Github user walterddr commented on a diff in the pull request:
https://github.com/apache/flink/pull/5638#discussion_r173607312
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/scala/expressionDsl.scala
---
@@ -1130,4 +1130,13 @@ object concat_ws
Github user walterddr commented on a diff in the pull request:
https://github.com/apache/flink/pull/5638#discussion_r173606447
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/scala/expressionDsl.scala
---
@@ -1130,4 +1130,13 @@ object concat_ws
Github user walterddr commented on a diff in the pull request:
https://github.com/apache/flink/pull/5327#discussion_r172408177
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/NonWindowJoin.scala
---
@@ -0,0 +1,271
Github user walterddr commented on a diff in the pull request:
https://github.com/apache/flink/pull/5327#discussion_r172408402
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/NonWindowLeftJoinWithNonEquiPredicates.scala
---
@@ -0,0 +1,228
Github user walterddr commented on the issue:
https://github.com/apache/flink/pull/
@hequn8128 @fhueske Thanks for the feedback. I have updated the diff to
directly use DistinctAccumulator for filtering and modified the
`generateAggregation` API. Please kindly take another look
Github user walterddr commented on a diff in the pull request:
https://github.com/apache/flink/pull/5174#discussion_r171346253
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/stream/table/CalcWithSplitCodeGenITCase.scala
---
@@ -0,0 +1,385
Github user walterddr commented on a diff in the pull request:
https://github.com/apache/flink/pull/5174#discussion_r170804955
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/FunctionCodeGenerator.scala
---
@@ -41,7 +41,7 @@ import
Github user walterddr commented on a diff in the pull request:
https://github.com/apache/flink/pull/5174#discussion_r171358583
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/CommonCalc.scala
---
@@ -46,10 +47,22 @@ trait CommonCalc
Github user walterddr commented on a diff in the pull request:
https://github.com/apache/flink/pull/5174#discussion_r171360773
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/stream/table/CalcWithSplitCodeGenITCase.scala
---
@@ -0,0 +1,385
Github user walterddr commented on a diff in the pull request:
https://github.com/apache/flink/pull/5174#discussion_r171357748
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/CommonCalc.scala
---
@@ -171,4 +186,47 @@ trait CommonCalc
Github user walterddr commented on the issue:
https://github.com/apache/flink/pull/
I agree this design is much cleaner and easier to maintain later. I was
hesitating to change the function signature of `generateAggregations()`.
I will try to introduce some common
Github user walterddr commented on a diff in the pull request:
https://github.com/apache/flink/pull/5327#discussion_r170610689
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/stream/table/JoinITCase.scala
---
@@ -201,18 +202,294 @@ class
1 - 100 of 140 matches
Mail list logo
