[GitHub] flink issue #5846: [FLINK-9143] [client] Restart strategy defined in flink-c...

2018-06-18 Thread yuqi1129
Github user yuqi1129 commented on the issue: https://github.com/apache/flink/pull/5846 @dawidwys Sorry , I will push my code in two days, if there still have any problem, any suggestions are appreciated. any way, if you have try to fix this problem, just go head. ---

[GitHub] flink pull request #6092: [FLINK-9352] In Standalone checkpoint recover mode...

2018-05-29 Thread yuqi1129
Github user yuqi1129 commented on a diff in the pull request: https://github.com/apache/flink/pull/6092#discussion_r191340849 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java --- @@ -1173,9 +1179,10 @@ public void

[GitHub] flink pull request #5846: [FLINK-9143] [client] Restart strategy defined in ...

2018-05-28 Thread yuqi1129
Github user yuqi1129 commented on a diff in the pull request: https://github.com/apache/flink/pull/5846#discussion_r191211627 --- Diff: flink-clients/src/main/java/org/apache/flink/client/program/ClusterClient.java --- @@ -896,6 +898,10 @@ public static JobGraph getJobGraph

[GitHub] flink pull request #5846: [FLINK-9143] [client] Restart strategy defined in ...

2018-05-28 Thread yuqi1129
Github user yuqi1129 commented on a diff in the pull request: https://github.com/apache/flink/pull/5846#discussion_r191143764 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java --- @@ -255,6 +264,35 @@ public void start() throws Exception

[GitHub] flink pull request #5846: [FLINK-9143] [client] Restart strategy defined in ...

2018-05-28 Thread yuqi1129
Github user yuqi1129 commented on a diff in the pull request: https://github.com/apache/flink/pull/5846#discussion_r191143882 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java --- @@ -255,6 +264,35 @@ public void start() throws Exception

[GitHub] flink pull request #5846: [FLINK-9143] [client] Restart strategy defined in ...

2018-05-28 Thread yuqi1129
Github user yuqi1129 commented on a diff in the pull request: https://github.com/apache/flink/pull/5846#discussion_r191143746 --- Diff: flink-clients/src/main/java/org/apache/flink/client/program/ClusterClient.java --- @@ -896,6 +898,10 @@ public static JobGraph getJobGraph

[GitHub] flink pull request #6022: [FLINK-9283] Update cluster execution docs

2018-05-16 Thread yuqi1129
GitHub user yuqi1129 opened a pull request: https://github.com/apache/flink/pull/6022 [FLINK-9283] Update cluster execution docs ## What is the purpose of the change This pull request is to fix port error in example about using `RemoteStreamEnvironment

[GitHub] flink pull request #5959: [FLINK-9258][metrics] Thread-safe initialization o...

2018-05-07 Thread yuqi1129
Github user yuqi1129 commented on a diff in the pull request: https://github.com/apache/flink/pull/5959#discussion_r186603684 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/ComponentMetricGroup.java --- @@ -57,11 +57,12 @@ public

[GitHub] flink pull request #5902: [FLINK-9194][history] Add HistoryServer support to...

2018-05-07 Thread yuqi1129
Github user yuqi1129 commented on a diff in the pull request: https://github.com/apache/flink/pull/5902#discussion_r186599431 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/history/HistoryServerArchiveFetcher.java --- @@ -162,7 +166,7 @@ public void

[GitHub] flink pull request #5910: [FLINK-8841] [state] Remove HashMapSerializer and ...

2018-04-25 Thread yuqi1129
Github user yuqi1129 commented on a diff in the pull request: https://github.com/apache/flink/pull/5910#discussion_r184044453 --- Diff: flink-core/src/main/java/org/apache/flink/util/InstantiationUtil.java --- @@ -221,6 +226,52 @@ protected ObjectStreamClass readClassDescriptor

[GitHub] flink pull request #5902: [FLINK-9194][history] Add HistoryServer support to...

2018-04-24 Thread yuqi1129
Github user yuqi1129 commented on a diff in the pull request: https://github.com/apache/flink/pull/5902#discussion_r183709218 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/history/HistoryServerArchiveFetcher.java --- @@ -211,7 +215,7 @@ public void

[GitHub] flink pull request #5902: [FLINK-9194][history] Add HistoryServer support to...

2018-04-24 Thread yuqi1129
Github user yuqi1129 commented on a diff in the pull request: https://github.com/apache/flink/pull/5902#discussion_r183702452 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/history/HistoryServerArchiveFetcher.java --- @@ -211,7 +215,7 @@ public void

[GitHub] flink pull request #5902: [FLINK-9194][history] Add HistoryServer support to...

2018-04-24 Thread yuqi1129
Github user yuqi1129 commented on a diff in the pull request: https://github.com/apache/flink/pull/5902#discussion_r183697720 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/JobVertexTaskManagersHandler.java --- @@ -83,6 +90,24 @@ protected

[GitHub] flink pull request #5888: [FLINK-9194] [histroyserver] Finished jobs are not...

2018-04-23 Thread yuqi1129
Github user yuqi1129 commented on a diff in the pull request: https://github.com/apache/flink/pull/5888#discussion_r183392156 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/history/HistoryServerArchiveFetcher.java --- @@ -180,10 +180,22 @@ public

[GitHub] flink pull request #5888: [FLINK-9194] [histroyserver] Finished jobs are not...

2018-04-21 Thread yuqi1129
GitHub user yuqi1129 opened a pull request: https://github.com/apache/flink/pull/5888 [FLINK-9194] [histroyserver] Finished jobs are not archived to Histor… ## What is the purpose of the change This is to solve the problem that history server can only show only one

[GitHub] flink issue #5829: [FLINK-9056] [jobmanager] Job submission fails with AskTi...

2018-04-15 Thread yuqi1129
Github user yuqi1129 commented on the issue: https://github.com/apache/flink/pull/5829 @tillrohrmann Could you help to check if this change is acceptable ? ---

[GitHub] flink issue #5846: [FLINK-9143] [client] Restart strategy defined in flink-c...

2018-04-15 Thread yuqi1129
Github user yuqi1129 commented on the issue: https://github.com/apache/flink/pull/5846 @tillrohrmann Can you help to look if this change is OK ? thanks ---

[GitHub] flink pull request #5846: [FLINK-9143] [client] Restart strategy defined in ...

2018-04-14 Thread yuqi1129
GitHub user yuqi1129 opened a pull request: https://github.com/apache/flink/pull/5846 [FLINK-9143] [client] Restart strategy defined in flink-conf.yaml is ignored ## What is the purpose of the change This change is to fix the bug that if restart strategy

[GitHub] flink issue #5777: [FLINK-7897] Consider using nio.Files for file deletion i...

2018-04-09 Thread yuqi1129
Github user yuqi1129 commented on the issue: https://github.com/apache/flink/pull/5777 @tedyu , You are right, I ignore the code below which do not show in the change. +1 ---

[GitHub] flink pull request #5829: [FLINK-9056] [jobmanager] Job submission fails wit...

2018-04-09 Thread yuqi1129
GitHub user yuqi1129 opened a pull request: https://github.com/apache/flink/pull/5829 [FLINK-9056] [jobmanager] Job submission fails with AskTimeoutExcepti… ## What is the purpose of the change This pull request makes the jobmanager return specific information

[GitHub] flink pull request #5777: [FLINK-7897] Consider using nio.Files for file del...

2018-03-28 Thread yuqi1129
Github user yuqi1129 commented on a diff in the pull request: https://github.com/apache/flink/pull/5777#discussion_r177736130 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/blob/TransientBlobCleanupTask.java --- @@ -100,9 +102,15 @@ public void run

[GitHub] flink pull request #:

2018-02-28 Thread yuqi1129
Github user yuqi1129 commented on the pull request: https://github.com/apache/flink/commit/6c44d93d0a9da725ef8b1ad2a94889f79321db73#commitcomment-27853406 In flink-dist/src/main/flink-bin/bin/taskmanager.sh: In flink-dist/src/main/flink-bin/bin/taskmanager.sh on line 64: Why