Github user zentol commented on the issue:
https://github.com/apache/flink/pull/6242
I take it that happens in 1.5.0? If so, this was already fixed for master
and 1.5.1.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/6242
see https://issues.apache.org/jira/browse/FLINK-9398
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/6140#discussion_r199760506
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java ---
@@ -166,6 +166,10 @@ public Configuration getConfiguration
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/6140#discussion_r199760246
--- Diff: flink-scala-shell/start-script/start-scala-shell.sh ---
@@ -19,6 +19,9 @@
# from scala-lang 2.10.4
+# Uncomment the following
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/6084#discussion_r199761621
--- Diff: docs/quickstart/java_api_quickstart.md ---
@@ -111,7 +111,7 @@ In IntelliJ IDEA recommended way to change JVM options
is from the `Help | Edit
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/6102#discussion_r199776329
--- Diff: tools/check_dependency_convergence.sh ---
@@ -0,0 +1,67 @@
+#!/usr/bin/env bash
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/6102#discussion_r199776816
--- Diff: tools/check_dependency_convergence.sh ---
@@ -0,0 +1,67 @@
+#!/usr/bin/env bash
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/6222
Merging, will create the issue once I'm done.
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/6218#discussion_r199792051
--- Diff: flink-formats/flink-avro/pom.xml ---
@@ -51,6 +51,17 @@ under the License
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/6230
We typically don't backport refactorings and code-cleanups.
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/6203#discussion_r199866326
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java
---
@@ -315,36 +315,61 @@ public JobSubmissionResult
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/6203#discussion_r199867852
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java
---
@@ -315,36 +315,61 @@ public JobSubmissionResult
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/6230
wait.
Is this a _backport_ of #6212 for 1.5, or an _extension_ that fixes another
occurrence?
---
Github user zentol closed the pull request at:
https://github.com/apache/flink/pull/6241
---
Github user zentol closed the pull request at:
https://github.com/apache/flink/pull/6222
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/6251#discussion_r200062854
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionTest.java
---
@@ -385,6 +381,76 @@ public void
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/6244#discussion_r200065001
--- Diff:
flink-fs-tests/src/test/java/org/apache/flink/hdfstests/DistributedCacheDfsTest.java
---
@@ -128,7 +130,7 @@ public void testDistributeFileViaDFS
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/6249
merging.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/6246
merging.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/6140
merging. @zjffdu Please open a follow-up issue for adding a test so we
don't break this again.
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/6184#discussion_r200122022
--- Diff:
flink-metrics/flink-metrics-prometheus/src/main/java/org/apache/flink/metrics/prometheus/PrometheusPushGatewayReporter.java
---
@@ -0,0 +1,94
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/6184#discussion_r200122928
--- Diff:
flink-metrics/flink-metrics-prometheus/src/main/java/org/apache/flink/metrics/prometheus/PrometheusPushGatewayReporter.java
---
@@ -0,0 +1,94
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/6184#discussion_r200122913
--- Diff:
flink-metrics/flink-metrics-prometheus/src/main/java/org/apache/flink/metrics/prometheus/PrometheusPushGatewayReporter.java
---
@@ -0,0 +1,94
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/6184#discussion_r200122411
--- Diff:
flink-metrics/flink-metrics-prometheus/src/main/java/org/apache/flink/metrics/prometheus/PrometheusPushGatewayReporter.java
---
@@ -0,0 +1,94
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/6184#discussion_r200122815
--- Diff:
flink-metrics/flink-metrics-prometheus/src/main/java/org/apache/flink/metrics/prometheus/PrometheusReporter.java
---
@@ -20,76 +20,38
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/6184#discussion_r200123362
--- Diff:
flink-metrics/flink-metrics-prometheus/src/main/java/org/apache/flink/metrics/prometheus/PrometheusPushGatewayReporter.java
---
@@ -0,0 +1,94
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/6184#discussion_r200121810
--- Diff: docs/monitoring/metrics.md ---
@@ -700,6 +700,31 @@ Flink metric types are mapped to Prometheus metric
types as follows:
All Flink
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/6184#discussion_r200122285
--- Diff:
flink-metrics/flink-metrics-prometheus/src/main/java/org/apache/flink/metrics/prometheus/PrometheusPushGatewayReporter.java
---
@@ -0,0 +1,94
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/6184#discussion_r200122904
--- Diff:
flink-metrics/flink-metrics-prometheus/src/main/java/org/apache/flink/metrics/prometheus/PrometheusPushGatewayReporter.java
---
@@ -0,0 +1,94
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/6184#discussion_r200123482
--- Diff:
flink-metrics/flink-metrics-prometheus/src/main/java/org/apache/flink/metrics/prometheus/PrometheusPushGatewayReporter.java
---
@@ -0,0 +1,94
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/6184#discussion_r200123407
--- Diff:
flink-metrics/flink-metrics-prometheus/src/main/java/org/apache/flink/metrics/prometheus/PrometheusPushGatewayReporter.java
---
@@ -0,0 +1,94
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/6184#discussion_r200122215
--- Diff:
flink-metrics/flink-metrics-prometheus/src/main/java/org/apache/flink/metrics/prometheus/PrometheusPushGatewayReporter.java
---
@@ -0,0 +1,94
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/6184#discussion_r200122491
--- Diff:
flink-metrics/flink-metrics-prometheus/src/main/java/org/apache/flink/metrics/prometheus/AbstractPrometheusReporter.java
---
@@ -0,0 +1,279
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/6240
The jepsen license is not compatible with the apache license and thus must
be part of the release.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/6240
My information is outdated, they updated the license roughly a month ago to
EPL:
https://github.com/jepsen-io/jepsen/commit/d9c8530b7a2deac2389d93639581dfa1ff0f08fc
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/6195
This PR isn't complete. As noted in the JIRA I would like to delay work on
this JIRA until 1.7, once the legacy code is dropped this will be significantly
easier to implement properly.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/6256
The RAT plugin ignores the `.gitignore` fail AFAIK, so I don't understand
why this would change anything.
RAT exclusions must be set in the plugin configuration in the root
`pom.xml`.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/6240
Note that this may also imply that the files that we add cannot be apache
licensed, but I'm not completely sure about that.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/6266
Travis failed, please investigate.
---
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/6269
[FLINK-9770][rest] Fix jar listing
## What is the purpose of the change
Ensures that uploaded jars adhere to the naming scheme that the
`JarListHandler` expects.
## Verifying this
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/6270
[FLINK-9769][rest] Clear FileUpload attribute after access
## What is the purpose of the change
Prevents a resource leakage by clearing the `UPLOADED_FILES` attribute
after accessing it
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/6270
Ultimately this should happen if the client sets the `keep-alive` flag on
the first request.
One thing i observed is that it appears to be gated by time. Uploading a
jar immediately triggers
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/6102
We should make sure it runs on mac, I just haven't had the time to search
for a cross-platform solution.
I also wouldn't be able to verify that it actually runs on mac, so someone
els
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/6269
merging.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/6270
merging.
---
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/6274
[FLINK-9771][rest] Fix plan JSON response
## What is the purpose of the change
This PR fixes the JSON plan display in the UI. The returned JSON did not
conform to the expected format `{plan
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/6266
That's really something that should've been cleared up in the JIRA before
any line of code was written.
On the spot i can't think of a good place to put it. You would want th
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/6247
for the AsyncIOExample, please revert the change to the `counter` field,
and open a separate JIRA and PR. This issue is specifically about fixing static
references.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/6256
merging.
---
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/6285
[FLINK-9768][release] Speed up binary release
## What is the purpose of the change
This PR speeds up the building of convenience release artifacts.
On my machine this makes the
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/6286
[FLINK-9754][release] Remove references to scala profiles
## What is the purpose of the change
This PR removes references to `scala_X.Y` profiles from the release
scripts. These profiles
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/6288
This doesn't really work; the configured name for the reporter (ìn this
case `prom`) is arbitrary and can be chosen by the user. As such this approach
will fail the moment users choose a diff
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/6288#discussion_r200987982
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/LaunchableMesosWorker.java
---
@@ -85,11 +85,11 @@
* @param
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/6263#discussion_r201291316
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/program/PackagedProgramTest.java
---
@@ -56,6 +63,54 @@ public void testGetPreviewPlan
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/6263#discussion_r201291422
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/program/PackagedProgramTest.java
---
@@ -56,6 +63,54 @@ public void testGetPreviewPlan
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/6263#discussion_r201291547
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/program/PackagedProgramTest.java
---
@@ -56,6 +63,54 @@ public void testGetPreviewPlan
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/6263#discussion_r201291704
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/program/PackagedProgramTest.java
---
@@ -56,6 +63,54 @@ public void testGetPreviewPlan
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/6263#discussion_r201291489
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/program/PackagedProgramTest.java
---
@@ -56,6 +63,54 @@ public void testGetPreviewPlan
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/6263#discussion_r201291273
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/program/PackagedProgramTest.java
---
@@ -56,6 +63,54 @@ public void testGetPreviewPlan
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/6292
[FLINK-9789][metrics] Ensure uniqueness of watermark metrics
## What is the purpose of the change
This PR ensures that all registered watermark metric objects are only
registered once
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/6292#discussion_r201315827
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/metrics/util/InterceptingTaskMetricGroup.java
---
@@ -0,0 +1,53 @@
+/*
+ * Licensed
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/6263#discussion_r201322209
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/program/PackagedProgramTest.java
---
@@ -21,16 +21,24 @@
import
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/6263
If it work I'll fix the issue I found and merge it afterwards.
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/6294#discussion_r201329612
--- Diff: docs/ops/deployment/yarn_setup.md ---
@@ -132,7 +132,10 @@ Stop the YARN session by stopping the unix process
(using CTRL+C) or by entering
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/6288#discussion_r201331084
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/LaunchableMesosWorker.java
---
@@ -332,6 +334,22 @@ public String
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/6288#discussion_r201331518
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/LaunchableMesosWorker.java
---
@@ -332,6 +334,22 @@ public String
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/6263
yes, `TemporaryFolders` should always be final, regardless of what existing
code does.
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/6292#discussion_r201347774
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/OneInputStreamTask.java
---
@@ -93,7 +93,7 @@ public void init
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/6230
@lamber-ken For the future, please ensure that the first commit message
includes the JIRA id (like the PR title) and has a proper name.
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/6292#discussion_r201358726
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/metrics/util/InterceptingTaskMetricGroup.java
---
@@ -0,0 +1,53 @@
+/*
+ * Licensed
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/6296
Please update the JIRA and this PR with an english title and description of
the problem.
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/6296#discussion_r201396143
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java
---
@@ -1189,9 +1189,9 @@ private static Path
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/6294#discussion_r201398701
--- Diff: docs/ops/deployment/yarn_setup.md ---
@@ -132,7 +132,7 @@ Stop the YARN session by stopping the unix process
(using CTRL+C) or by entering
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/6286
merging.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/6285
merging.
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/6296#discussion_r201586679
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java
---
@@ -1189,9 +1189,9 @@ private static Path
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/6296#discussion_r201586773
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java
---
@@ -1227,7 +1227,6 @@ public FileVisitResult visitFile
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/6292
Relying on hashCode/equals implementations would mean we could no longer
use lambdas/method references for gauges which imo isn't a viable option.
---
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/6304
[FLINK-9801][build] Add missing example dependencies to flink-dist
## What is the purpose of the change
With this PR `flink-dist` explicitly depends on `flink-examples-batch` and
`flink
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/6170
alrighty, looks good to me, merging.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/6303
If you modify the description of config options you have to regenerate the
documentation. See the test error message for instructions.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/6304
merging.
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/6288#discussion_r201657551
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/LaunchableMesosWorker.java
---
@@ -332,6 +334,22 @@ public String
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/6265
+1
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/6231
This doesn't look correct to me, the serializer should always be non-null,
and silently dropping null serializers most likely just causes other problems.
Did you actually run into thi
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/6307
[FLINK-9805][rest] Catch JsonProcessingException in RestClient
## What is the purpose of the change
With this PR `RestClient#readRawResponse` catches all JSON-related
exceptions. The exact
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/6310
[FLINK-9810][rest] Close jar file in JarListHandler
## What is the purpose of the change
Small cleanup in the `JarListHandler` to properly close listed jars, as
otherwise subsequent delete
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/6311
[FLINK-9811][rest] Add test for jar handler interactions
Based on #6310.
## What is the purpose of the change
This PR adds an ITCase for the interactions between jar handlers
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/6304
hm, so this causes fairly consistently timeouts in the kafka end-to-end
test. How in the world can this break things...
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/6304
ah of course, we promote transitive dependencies in flink-dist, and the
examples depend on kafka
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/6312#discussion_r201787098
--- Diff: docs/_includes/generated/security_configuration.html ---
@@ -10,7 +10,7 @@
security.ssl.algorithms
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/6312#discussion_r201802349
--- Diff: docs/_includes/generated/security_configuration.html ---
@@ -10,7 +10,7 @@
security.ssl.algorithms
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/6312#discussion_r201802591
--- Diff: docs/_includes/generated/security_configuration.html ---
@@ -10,7 +10,7 @@
security.ssl.algorithms
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/6312#discussion_r201803134
--- Diff: docs/_includes/generated/security_configuration.html ---
@@ -10,7 +10,7 @@
security.ssl.algorithms
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/6312#discussion_r201805424
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/description/Formatter.java
---
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/6312#discussion_r201805835
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/description/ListElement.java
---
@@ -0,0 +1,60 @@
+/*
+ * Licensed to the Apache
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/6312#discussion_r201806215
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/description/BlockElement.java
---
@@ -0,0 +1,33 @@
+/*
+ * Licensed to the Apache
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/6312#discussion_r201838689
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/description/LineBreakElement.java
---
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/6312#discussion_r201932360
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/description/LineBreakElement.java
---
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/6304#discussion_r202052321
--- Diff: flink-dist/pom.xml ---
@@ -140,6 +140,22 @@ under the License.
+
--- End diff
1601 - 1700 of 2446 matches
Mail list logo
