[GitHub] flink pull request #6199: [FLINK-9624][runtime] Move jar/artifact upload out...

2018-06-21 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6199#discussion_r197279307 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/JobGraph.java --- @@ -552,96 +550,33 @@ public boolean hasUsercodeJarFiles

[GitHub] flink pull request #6199: [FLINK-9624][runtime] Move jar/artifact upload out...

2018-06-21 Thread zentol
GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/6199 [FLINK-9624][runtime] Move jar/artifact upload out of jobgraph ## What is the purpose of the change This PR moves the logic for uploading jars/artifacts from the jobgraph into a separate

[GitHub] flink issue #6189: [FLINK-9599][rest] RestClient supports FileUploads

2018-06-21 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/6189 I've rebased the PR. ---

[GitHub] flink pull request #6189: [FLINK-9599][rest] RestClient supports FileUploads...

2018-06-21 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6189#discussion_r197142993 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/FileUploadHandler.java --- @@ -106,7 +106,7 @@ protected void channelRead0(final

[GitHub] flink issue #6178: [FLINK-9599][rest] Implement generic mechanism to access ...

2018-06-21 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/6178 will change the logging and merge afterwards. ---

[GitHub] flink issue #6152: [FLINK-9467][metrics][WebUI] Fix watermark display

2018-06-21 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/6152 merging. ---

[GitHub] flink issue #6187: FLINK-9623][runtime] Move zipping logic out of blobservic...

2018-06-21 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/6187 merging. ---

[GitHub] flink pull request #6187: FLINK-9623][runtime] Move zipping logic out of blo...

2018-06-21 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6187#discussion_r197112471 --- Diff: flink-optimizer/src/test/java/org/apache/flink/optimizer/plantranslate/JobGraphGeneratorTest.java --- @@ -206,4 +222,54 @@ public boolean filter

[GitHub] flink pull request #6187: FLINK-9623][runtime] Move zipping logic out of blo...

2018-06-21 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6187#discussion_r197112144 --- Diff: flink-optimizer/src/test/java/org/apache/flink/optimizer/plantranslate/JobGraphGeneratorTest.java --- @@ -206,4 +222,54 @@ public boolean filter

[GitHub] flink pull request #6189: [FLINK-9599][rest] RestClient supports FileUploads...

2018-06-21 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6189#discussion_r197106285 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/FileUploadHandler.java --- @@ -106,7 +106,7 @@ protected void channelRead0(final

[GitHub] flink pull request #6189: [FLINK-9599][rest] RestClient supports FileUploads...

2018-06-21 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6189#discussion_r197095206 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/FileUploadHandler.java --- @@ -106,7 +106,7 @@ protected void channelRead0(final

[GitHub] flink pull request #6178: [FLINK-9599][rest] Implement generic mechanism to ...

2018-06-21 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6178#discussion_r197085237 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/FileUploadHandler.java --- @@ -151,18 +143,26 @@ protected void channelRead0(final

[GitHub] flink pull request #6189: [FLINK-9599][rest] RestClient supports FileUploads...

2018-06-21 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6189#discussion_r197076585 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/FileUploadHandler.java --- @@ -106,7 +106,7 @@ protected void channelRead0(final

[GitHub] flink pull request #6189: [FLINK-9599][rest] RestClient supports FileUploads...

2018-06-21 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6189#discussion_r197065693 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/AbstractHandler.java --- @@ -103,77 +102,68 @@ protected void respondAsLeader

[GitHub] flink issue #6178: [FLINK-9599][rest] Implement generic mechanism to access ...

2018-06-21 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/6178 @tillrohrmann Ready for another review. ---

[GitHub] flink pull request #6178: [FLINK-9599][rest] Implement generic mechanism to ...

2018-06-21 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6178#discussion_r197054770 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/rest/FileUploadHandlerTest.java --- @@ -259,6 +271,29 @@ public void testFileMultipart

[GitHub] flink pull request #6178: [FLINK-9599][rest] Implement generic mechanism to ...

2018-06-21 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6178#discussion_r197053400 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/rest/AbstractHandlerTest.java --- @@ -0,0 +1,190 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #6189: [FLINK-9599][rest] RestClient supports FileUploads...

2018-06-21 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6189#discussion_r197029723 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/AbstractHandler.java --- @@ -103,77 +102,68 @@ protected void respondAsLeader

[GitHub] flink pull request #6178: [FLINK-9599][rest] Implement generic mechanism to ...

2018-06-20 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6178#discussion_r196868266 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/rest/FileUploadHandlerTest.java --- @@ -0,0 +1,483 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #6178: [FLINK-9599][rest] Implement generic mechanism to ...

2018-06-20 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6178#discussion_r196849558 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/rest/FileUploadHandlerTest.java --- @@ -0,0 +1,483 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #6178: [FLINK-9599][rest] Implement generic mechanism to ...

2018-06-20 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6178#discussion_r196836698 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/FileUploads.java --- @@ -0,0 +1,108 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #6178: [FLINK-9599][rest] Implement generic mechanism to ...

2018-06-20 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6178#discussion_r196836575 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/FileUploadHandler.java --- @@ -70,51 +84,103 @@ public FileUploadHandler(final Path

[GitHub] flink pull request #6189: [FLINK-9599][rest] RestClient supports FileUploads...

2018-06-20 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6189#discussion_r196793605 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/RestClient.java --- @@ -162,13 +205,25 @@ public void shutdown(Time timeout

[GitHub] flink pull request #6189: [FLINK-9599][rest] RestClient supports FileUploads...

2018-06-20 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6189#discussion_r196793648 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/RestClient.java --- @@ -162,13 +205,25 @@ public void shutdown(Time timeout

[GitHub] flink pull request #6189: [FLINK-9599][rest] RestClient supports FileUploads...

2018-06-20 Thread zentol
GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/6189 [FLINK-9599][rest] RestClient supports FileUploads This PR is based on a squashed #6178. ## What is the purpose of the change This PR extends the `RestClient` to allow sending

[GitHub] flink pull request #6187: FLINK-9623][runtime] Move zipping logic out of blo...

2018-06-20 Thread zentol
GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/6187 FLINK-9623][runtime] Move zipping logic out of blobservice ## What is the purpose of the change This PR moves the zipping logic for local user directory artifacts out of the blobservice

[GitHub] flink issue #5857: [FLINK-9187][METRICS] add prometheus pushgateway reporter

2018-06-20 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5857 If you created another fork and are no longer able to access the previous one then yes, you will need a new PR. ---

[GitHub] flink issue #6178: [FLINK-9599][rest] Implement generic mechanism to access ...

2018-06-20 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/6178 @tillrohrmann I believe I've addressed all your comments. ---

[GitHub] flink pull request #6178: [FLINK-9599][rest] Implement generic mechanism to ...

2018-06-20 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6178#discussion_r196712002 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/FileUploadHandler.java --- @@ -95,14 +107,22 @@ protected void channelRead0(final

[GitHub] flink pull request #6178: [FLINK-9599][rest] Implement generic mechanism to ...

2018-06-20 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6178#discussion_r196698434 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/FileUploadHandler.java --- @@ -72,10 +82,12 @@ public FileUploadHandler(final Path

[GitHub] flink pull request #6178: [FLINK-9599][rest] Implement generic mechanism to ...

2018-06-20 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6178#discussion_r196696248 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/FileUploadHandler.java --- @@ -116,5 +136,16 @@ private void reset

[GitHub] flink pull request #6178: [FLINK-9599][rest] Implement generic mechanism to ...

2018-06-20 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6178#discussion_r196681937 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/rest/FileUploadHandlerTest.java --- @@ -0,0 +1,471 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #6178: [FLINK-9599][rest] Implement generic mechanism to ...

2018-06-20 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6178#discussion_r196667391 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/FileUploadHandler.java --- @@ -95,14 +107,22 @@ protected void channelRead0(final

[GitHub] flink pull request #6178: [FLINK-9599][rest] Implement generic mechanism to ...

2018-06-20 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6178#discussion_r196667307 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/FileUploadHandler.java --- @@ -116,5 +136,16 @@ private void reset

[GitHub] flink pull request #6178: [FLINK-9599][rest] Implement generic mechanism to ...

2018-06-20 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6178#discussion_r196667205 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/FileUploadHandler.java --- @@ -95,14 +107,22 @@ protected void channelRead0(final

[GitHub] flink pull request #6147: [FLINK-9280][rest] Rework JobSubmitHandler to acce...

2018-06-19 Thread zentol
Github user zentol closed the pull request at: https://github.com/apache/flink/pull/6147 ---

[GitHub] flink issue #6147: [FLINK-9280][rest] Rework JobSubmitHandler to accept jar/...

2018-06-19 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/6147 I will split this PR to address the various issues separately. ---

[GitHub] flink issue #5857: [FLINK-9187][METRICS] add prometheus pushgateway reporter

2018-06-19 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5857 I I see the value of a `cluster_id` but you're mixing concerns here. It is not the responsibility of a `reporter` to introduce a `cluster_id` tag. Reporters are to faithfully report the metric

[GitHub] flink issue #5857: [FLINK-9187][METRICS] add prometheus pushgateway reporter

2018-06-19 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5857 Why do you prefer random ID's to differentiate between JM/TM than their actual unique ID? ---

[GitHub] flink pull request #6178: [FLINK-9599][rest] Implement generic mechanism to ...

2018-06-18 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6178#discussion_r196129193 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/FileUploads.java --- @@ -0,0 +1,136 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #6178: [FLINK-9599][rest] Implement generic mechanism to ...

2018-06-18 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6178#discussion_r196090706 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/FileUploadHandler.java --- @@ -52,7 +57,10 @@ --- End diff -- should

[GitHub] flink pull request #6178: [FLINK-9599][rest] Implement generic mechanism to ...

2018-06-18 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6178#discussion_r196081080 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/rest/FileUploadHandlerTest.java --- @@ -0,0 +1,455 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #6178: [FLINK-9599][rest] Implement generic mechanism to ...

2018-06-18 Thread zentol
GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/6178 [FLINK-9599][rest] Implement generic mechanism to access uploaded files ## What is the purpose of the change This PR extends the existing multipart handling to also support mixed multipart

[GitHub] flink pull request #6170: [FLINK-9563]: Using a custom sink function for tes...

2018-06-15 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6170#discussion_r195826270 --- Diff: flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/CEPITCase.java --- @@ -708,10 +724,32 @@ public boolean filter(Tuple2 rec) throws

[GitHub] flink issue #6170: [FLINK-9563]: Using a custom sink function for tests in C...

2018-06-15 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/6170 env.execute() should block until the job has finished execution, so your analysis may be incorrect. I can take a deeper look at possible semantic changes, but there are some conceptual

[GitHub] flink pull request #6170: [FLINK-9563]: Using a custom sink function for tes...

2018-06-15 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6170#discussion_r195824665 --- Diff: flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/CEPITCase.java --- @@ -658,20 +668,26 @@ public String select(Map> patt

[GitHub] flink pull request #6170: [FLINK-9563]: Using a custom sink function for tes...

2018-06-15 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6170#discussion_r195823948 --- Diff: flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/CEPITCase.java --- @@ -360,27 +345,30 @@ public boolean filter(Event value) throws

[GitHub] flink pull request #6170: [FLINK-9563]: Using a custom sink function for tes...

2018-06-15 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6170#discussion_r195824079 --- Diff: flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/CEPITCase.java --- @@ -504,20 +498,30 @@ public String select(Map> patt

[GitHub] flink pull request #6170: [FLINK-9563]: Using a custom sink function for tes...

2018-06-15 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6170#discussion_r195824130 --- Diff: flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/CEPITCase.java --- @@ -573,19 +577,25 @@ public String select(Map> patt

[GitHub] flink pull request #6170: [FLINK-9563]: Using a custom sink function for tes...

2018-06-15 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6170#discussion_r195824580 --- Diff: flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/CEPITCase.java --- @@ -708,10 +724,32 @@ public boolean filter(Tuple2 rec) throws

[GitHub] flink pull request #6172: [FLINK-9594][E2E tests] Improve docs for new test ...

2018-06-15 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6172#discussion_r195823386 --- Diff: flink-end-to-end-tests/README.md --- @@ -33,6 +33,53 @@ $ FLINK_DIR= flink-end-to-end-tests/test-scripts/test_batch_wordcount ## Writing

[GitHub] flink pull request #6172: [FLINK-9594][E2E tests] Improve docs for new test ...

2018-06-15 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6172#discussion_r195823151 --- Diff: flink-end-to-end-tests/README.md --- @@ -33,6 +33,53 @@ $ FLINK_DIR= flink-end-to-end-tests/test-scripts/test_batch_wordcount ## Writing

[GitHub] flink pull request #5857: [FLINK-9187][METRICS] add prometheus pushgateway r...

2018-06-14 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5857#discussion_r195644101 --- Diff: flink-metrics/flink-metrics-prometheus/src/main/java/org/apache/flink/metrics/prometheus/PrometheusPushGatewayReporter.java --- @@ -0,0 +1,79

[GitHub] flink pull request #5857: [FLINK-9187][METRICS] add prometheus pushgateway r...

2018-06-14 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5857#discussion_r195643808 --- Diff: flink-metrics/flink-metrics-prometheus/src/main/java/org/apache/flink/metrics/prometheus/PrometheusPushGatewayReporter.java --- @@ -0,0 +1,79

[GitHub] flink issue #5845: [FLINK-9168][flink-connectors]Pulsar Sink connector

2018-06-14 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5845 it is not possible to create a PR against a non-existing branch. We will either have to create a pulsar-connector branch up front, or open the first PR against master and merge it into a new branch

[GitHub] flink issue #5843: [FLINK-8744][docs] Generate "Common Option" section

2018-06-14 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5843 merging. ---

[GitHub] flink issue #6126: [FLINK-9530][metrics] Fix numRecords task metric for chai...

2018-06-14 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/6126 merging. ---

[GitHub] flink issue #6053: [FLINK-9257][E2E Tests] Fix wrong "All tests pass" messag...

2018-06-14 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/6053 merging. ---

[GitHub] flink issue #6165: [FLINK-9577] Divide-by-zero in PageRank

2018-06-14 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/6165 How have you verified that this does not affect the semantics of the algorithm? ---

[GitHub] flink pull request #6167: [FLINK-9582][build] Rework flink-dist assemblies

2018-06-14 Thread zentol
GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/6167 [FLINK-9582][build] Rework flink-dist assemblies ## What is the purpose of the change This PR reworks the `flink-dist` assemblies to not access specific jars outside of the `flink-dist

[GitHub] flink pull request #6158: [FLINK-8785][rest] Handle JobSubmissionExceptions

2018-06-14 Thread zentol
Github user zentol closed the pull request at: https://github.com/apache/flink/pull/6158 ---

[GitHub] flink pull request #5857: [FLINK-9187][METRICS] add prometheus pushgateway r...

2018-06-13 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5857#discussion_r195229711 --- Diff: flink-metrics/flink-metrics-prometheus/src/main/java/org/apache/flink/metrics/prometheus/PrometheusPushGatewayReporter.java --- @@ -0,0 +1,79

[GitHub] flink issue #6053: [FLINK-9257][E2E Tests] Fix wrong "All tests pass" messag...

2018-06-13 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/6053 Looks good to me, let's see what travis says. ---

[GitHub] flink pull request #6081: [FLINK-8067] User code ClassLoader not set before ...

2018-06-13 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6081#discussion_r195125463 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/StreamTaskTest.java --- @@ -806,6 +811,44 @@ public void

[GitHub] flink pull request #6147: [FLINK-9280][rest] Rework JobSubmitHandler to acce...

2018-06-13 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6147#discussion_r19537 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/JobSubmitHandler.java --- @@ -65,7 +86,96 @@ public JobSubmitHandler

[GitHub] flink pull request #6147: [FLINK-9280][rest] Rework JobSubmitHandler to acce...

2018-06-13 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6147#discussion_r195101445 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/RestClient.java --- @@ -197,6 +208,88 @@ public void shutdown(Time timeout

[GitHub] flink pull request #6147: [FLINK-9280][rest] Rework JobSubmitHandler to acce...

2018-06-13 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6147#discussion_r195107099 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/filecache/FileCacheDirectoriesTest.java --- @@ -206,4 +200,49 @@ public void

[GitHub] flink pull request #6147: [FLINK-9280][rest] Rework JobSubmitHandler to acce...

2018-06-13 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6147#discussion_r195098933 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/RestClient.java --- @@ -197,6 +208,88 @@ public void shutdown(Time timeout

[GitHub] flink pull request #6147: [FLINK-9280][rest] Rework JobSubmitHandler to acce...

2018-06-13 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6147#discussion_r195083682 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/FileUploadHandler.java --- @@ -89,7 +89,7 @@ protected void channelRead0(final

[GitHub] flink pull request #6147: [FLINK-9280][rest] Rework JobSubmitHandler to acce...

2018-06-13 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6147#discussion_r195080163 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/util/RestConstants.java --- @@ -25,4 +25,6 @@ */ public class RestConstants

[GitHub] flink pull request #6053: [FLINK-9257][E2E Tests] Fix wrong "All tests pass"...

2018-06-13 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6053#discussion_r195079715 --- Diff: flink-end-to-end-tests/test-scripts/test-runner-common.sh --- @@ -0,0 +1,76 @@ +#!/usr/bin/env bash

[GitHub] flink pull request #6053: [FLINK-9257][E2E Tests] Fix wrong "All tests pass"...

2018-06-13 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6053#discussion_r195079963 --- Diff: flink-end-to-end-tests/test-scripts/test-runner-common.sh --- @@ -0,0 +1,76 @@ +#!/usr/bin/env bash

[GitHub] flink pull request #6053: [FLINK-9257][E2E Tests] Fix wrong "All tests pass"...

2018-06-13 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6053#discussion_r195079122 --- Diff: flink-end-to-end-tests/test-scripts/test_local_recovery_and_scheduling.sh --- @@ -71,8 +69,14 @@ function run_local_recovery_test { local

[GitHub] flink pull request #6053: [FLINK-9257][E2E Tests] Fix wrong "All tests pass"...

2018-06-13 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6053#discussion_r195071781 --- Diff: flink-end-to-end-tests/test-scripts/test_local_recovery_and_scheduling.sh --- @@ -71,8 +69,14 @@ function run_local_recovery_test { local

[GitHub] flink pull request #6053: [FLINK-9257][E2E Tests] Fix wrong "All tests pass"...

2018-06-13 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6053#discussion_r195071307 --- Diff: flink-end-to-end-tests/run-nightly-tests.sh --- @@ -25,180 +25,65 @@ if [ -z "$END_TO_END_DIR" ] ; then exit 1 # fa

[GitHub] flink issue #6053: [FLINK-9257][E2E Tests] Fix wrong "All tests pass" messag...

2018-06-13 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/6053 Oh you already rebased it in the mean-time. neat. ---

[GitHub] flink pull request #6053: [FLINK-9257][E2E Tests] Fix wrong "All tests pass"...

2018-06-13 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6053#discussion_r195060959 --- Diff: flink-end-to-end-tests/run-nightly-tests.sh --- @@ -30,168 +30,57 @@ if [ -z "$FLINK_DIR" ] ; then exit 1 fi

[GitHub] flink pull request #6147: [FLINK-9280][rest] Rework JobSubmitHandler to acce...

2018-06-13 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6147#discussion_r195070782 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/JobGraph.java --- @@ -581,6 +582,8 @@ public String toString

[GitHub] flink pull request #6147: [FLINK-9280][rest] Rework JobSubmitHandler to acce...

2018-06-13 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6147#discussion_r195069312 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/filecache/FileCache.java --- @@ -253,13 +249,13 @@ public void releaseJob(JobID jobId

[GitHub] flink pull request #6147: [FLINK-9280][rest] Rework JobSubmitHandler to acce...

2018-06-13 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6147#discussion_r195068231 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/filecache/FileCache.java --- @@ -273,26 +269,8 @@ public Path call() throws IOException

[GitHub] flink pull request #6147: [FLINK-9280][rest] Rework JobSubmitHandler to acce...

2018-06-13 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6147#discussion_r195066482 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/JobGraph.java --- @@ -581,6 +582,8 @@ public String toString

[GitHub] flink pull request #6147: [FLINK-9280][rest] Rework JobSubmitHandler to acce...

2018-06-13 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6147#discussion_r195065850 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/FileUploadHandler.java --- @@ -89,7 +89,7 @@ protected void channelRead0(final

[GitHub] flink pull request #6147: [FLINK-9280][rest] Rework JobSubmitHandler to acce...

2018-06-13 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6147#discussion_r195054956 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/JobGraph.java --- @@ -581,6 +582,8 @@ public String toString

[GitHub] flink pull request #6147: [FLINK-9280][rest] Rework JobSubmitHandler to acce...

2018-06-13 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6147#discussion_r195054416 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/filecache/FileCache.java --- @@ -342,4 +320,54 @@ public void run

[GitHub] flink pull request #6147: [FLINK-9280][rest] Rework JobSubmitHandler to acce...

2018-06-13 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6147#discussion_r195052699 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/filecache/FileCache.java --- @@ -253,13 +249,13 @@ public void releaseJob(JobID jobId

[GitHub] flink pull request #6147: [FLINK-9280][rest] Rework JobSubmitHandler to acce...

2018-06-13 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6147#discussion_r195052490 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/filecache/FileCache.java --- @@ -273,26 +269,8 @@ public Path call() throws IOException

[GitHub] flink pull request #6158: [FLINK-8785][rest] Handle JobSubmissionExceptions

2018-06-13 Thread zentol
GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/6158 [FLINK-8785][rest] Handle JobSubmissionExceptions ## What is the purpose of the change Currently, if a `JobSubmissionException` occurs the `JobSubmissionHandler` only returns `505 Internal

[GitHub] flink pull request #6107: [FLINK-9366] DistributedCache works with Distribut...

2018-06-12 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6107#discussion_r194703701 --- Diff: flink-fs-tests/src/test/java/org/apache/flink/hdfstests/DistributedCacheDfsTest.java --- @@ -0,0 +1,160 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #6107: [FLINK-9366] DistributedCache works with Distribut...

2018-06-12 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6107#discussion_r194705137 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/JobGraph.java --- @@ -584,17 +584,25 @@ public void uploadUserArtifacts

[GitHub] flink pull request #6076: [hotfix][docs] Specify operators behaviour on proc...

2018-06-12 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6076#discussion_r194702812 --- Diff: docs/dev/event_time.md --- @@ -213,10 +213,36 @@ arrive after the system's event time clock (as signaled by the watermarks) has a time

[GitHub] flink pull request #6076: [hotfix][docs] Specify operators behaviour on proc...

2018-06-12 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6076#discussion_r194702541 --- Diff: docs/dev/event_time.md --- @@ -213,10 +213,36 @@ arrive after the system's event time clock (as signaled by the watermarks) has a time

[GitHub] flink pull request #6076: [hotfix][docs] Specify operators behaviour on proc...

2018-06-12 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6076#discussion_r194702106 --- Diff: docs/dev/event_time.md --- @@ -213,10 +213,36 @@ arrive after the system's event time clock (as signaled by the watermarks) has a time

[GitHub] flink pull request #6076: [hotfix][docs] Specify operators behaviour on proc...

2018-06-12 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6076#discussion_r194702199 --- Diff: docs/dev/event_time.md --- @@ -213,10 +213,36 @@ arrive after the system's event time clock (as signaled by the watermarks) has a time

[GitHub] flink pull request #6076: [hotfix][docs] Specify operators behaviour on proc...

2018-06-12 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6076#discussion_r194702405 --- Diff: docs/dev/event_time.md --- @@ -213,10 +213,36 @@ arrive after the system's event time clock (as signaled by the watermarks) has a time

[GitHub] flink issue #6129: [FLINK-9503] Migrate integration tests for iterative aggr...

2018-06-12 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/6129 +1 ---

[GitHub] flink pull request #6129: [FLINK-9503] Migrate integration tests for iterati...

2018-06-12 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6129#discussion_r194694357 --- Diff: flink-tests/src/test/java/org/apache/flink/test/iterative/aggregators/AggregatorsITCase.java --- @@ -170,12 +162,12 @@ public void

[GitHub] flink pull request #6152: 9467

2018-06-12 Thread zentol
GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/6152 9467 ## What is the purpose of the change This PR fixes the watermark display in the WebUI. When we reworked the watermark metrics we renamed the metrics and moved them to the

[GitHub] flink issue #6127: [FLINK-9368][py][tests] Add Python API E2E test

2018-06-12 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/6127 merging. ---

[GitHub] flink issue #6146: [FLINK-9564][tests] Expose flink-end-to-end module direct...

2018-06-12 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/6146 merging. ---

[GitHub] flink pull request #6146: [FLINK-9564][tests] Expose flink-end-to-end module...

2018-06-12 Thread zentol
Github user zentol closed the pull request at: https://github.com/apache/flink/pull/6146 ---

<    1   2   3   4   5   6   7   8   9   10   >