[GitHub] [flink] 1996fanrui commented on a diff in pull request #20233: [FLINK-28474][checkpoint] Fix the bug ChannelStateWriteResult might not fail after checkpoint abort

2022-10-06 Thread GitBox
1996fanrui commented on code in PR #20233: URL: https://github.com/apache/flink/pull/20233#discussion_r989067790 ## flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/SubtaskCheckpointCoordinatorTest.java: ## @@ -569,6 +571,58 @@ public void snapshotStat

[GitHub] [flink] 1996fanrui commented on a diff in pull request #20233: [FLINK-28474][checkpoint] Fix the bug ChannelStateWriteResult might not fail after checkpoint abort

2022-10-06 Thread GitBox
1996fanrui commented on code in PR #20233: URL: https://github.com/apache/flink/pull/20233#discussion_r988935163 ## flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/SubtaskCheckpointCoordinatorTest.java: ## @@ -568,6 +572,53 @@ public void snapshotStat

[GitHub] [flink] 1996fanrui commented on a diff in pull request #20233: [FLINK-28474][checkpoint] Fix the bug ChannelStateWriteResult might not fail after checkpoint abort

2022-10-05 Thread GitBox
1996fanrui commented on code in PR #20233: URL: https://github.com/apache/flink/pull/20233#discussion_r988603332 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/SubtaskCheckpointCoordinatorImpl.java: ## @@ -209,6 +213,7 @@ class SubtaskCheckpointCo

[GitHub] [flink] 1996fanrui commented on a diff in pull request #20233: [FLINK-28474][checkpoint] Fix the bug ChannelStateWriteResult might not fail after checkpoint abort

2022-07-13 Thread GitBox
1996fanrui commented on code in PR #20233: URL: https://github.com/apache/flink/pull/20233#discussion_r920275634 ## flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/SubtaskCheckpointCoordinatorTest.java: ## @@ -568,6 +572,53 @@ public void snapshotStat

[GitHub] [flink] 1996fanrui commented on a diff in pull request #20233: [FLINK-28474][checkpoint] Fix the bug ChannelStateWriteResult might not fail after checkpoint abort

2022-07-13 Thread GitBox
1996fanrui commented on code in PR #20233: URL: https://github.com/apache/flink/pull/20233#discussion_r920260335 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/SubtaskCheckpointCoordinatorImpl.java: ## @@ -316,6 +316,10 @@ public void checkpointSt

[GitHub] [flink] 1996fanrui commented on a diff in pull request #20233: [FLINK-28474][checkpoint] Fix the bug ChannelStateWriteResult might not fail after checkpoint abort

2022-07-13 Thread GitBox
1996fanrui commented on code in PR #20233: URL: https://github.com/apache/flink/pull/20233#discussion_r920121363 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/SubtaskCheckpointCoordinatorImpl.java: ## @@ -316,6 +316,10 @@ public void checkpointSt

[GitHub] [flink] 1996fanrui commented on a diff in pull request #20233: [FLINK-28474][checkpoint] Fix the bug ChannelStateWriteResult might not fail after checkpoint abort

2022-07-13 Thread GitBox
1996fanrui commented on code in PR #20233: URL: https://github.com/apache/flink/pull/20233#discussion_r920121363 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/SubtaskCheckpointCoordinatorImpl.java: ## @@ -316,6 +316,10 @@ public void checkpointSt

[GitHub] [flink] 1996fanrui commented on a diff in pull request #20233: [FLINK-28474][checkpoint] Fix the bug ChannelStateWriteResult might not fail after checkpoint abort

2022-07-13 Thread GitBox
1996fanrui commented on code in PR #20233: URL: https://github.com/apache/flink/pull/20233#discussion_r920121363 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/SubtaskCheckpointCoordinatorImpl.java: ## @@ -316,6 +316,10 @@ public void checkpointSt