1996fanrui commented on PR #21368:
URL: https://github.com/apache/flink/pull/21368#issuecomment-1345078542
Thanks everyone who reviewed 👍🏻
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
1996fanrui commented on PR #21368:
URL: https://github.com/apache/flink/pull/21368#issuecomment-1344305894
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
1996fanrui commented on PR #21368:
URL: https://github.com/apache/flink/pull/21368#issuecomment-1343929889
> Thanks for the PR and for pulling me in. I've left only some minor
comments, PTAL.
Hi @rkhachatryan , thanks for your review, I have updated.
--
This is an automated message
1996fanrui commented on PR #21368:
URL: https://github.com/apache/flink/pull/21368#issuecomment-1337695133
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
1996fanrui commented on PR #21368:
URL: https://github.com/apache/flink/pull/21368#issuecomment-1337693383
> Thanks for addressing my comments. The PR looks good. 👍
>
> @1996fanrui just as hint for future PRs. It helps to add new commits while
being in the review process and only do a
1996fanrui commented on PR #21368:
URL: https://github.com/apache/flink/pull/21368#issuecomment-1337161593
> I replied to your comments, @1996fanrui. I'm looking forward to your
response.
@XComp , thanks for your hard review, update~
--
This is an automated message from the Apache
1996fanrui commented on PR #21368:
URL: https://github.com/apache/flink/pull/21368#issuecomment-1332191540
Hi @XComp , thanks for your hard review. I have addressed all comments.
And thanks @XComp @snuyanzin @reswqa and @RocMarshal again, I learned a lot
in this PR. It will be useful
1996fanrui commented on PR #21368:
URL: https://github.com/apache/flink/pull/21368#issuecomment-1328427197
Hi @XComp @snuyanzin , I have addressed all comments, please help take a
look, thanks~
--
This is an automated message from the Apache Git Service.
To respond to the message, please
1996fanrui commented on PR #21368:
URL: https://github.com/apache/flink/pull/21368#issuecomment-1326506661
Hi @RocMarshal @reswqa , thanks a lot for your review, I have updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
1996fanrui commented on PR #21368:
URL: https://github.com/apache/flink/pull/21368#issuecomment-1326370887
Hi @snuyanzin , Thanks for your review. I have addressed all comments.
> Is there a way to determine which tests are related to unaligned
checkpoint and which are not based e.g.
1996fanrui commented on PR #21368:
URL: https://github.com/apache/flink/pull/21368#issuecomment-1326037817
Hi @RocMarshal , please help take a look in your free time, thanks~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
1996fanrui commented on PR #21368:
URL: https://github.com/apache/flink/pull/21368#issuecomment-1325168462
Hi @XComp , please help take a look in your free time, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
12 matches
Mail list logo
