[GitHub] [flink] AHeise commented on a change in pull request #13228: [FLINK-19026][network] Improve threading model of CheckpointBarrierUnaligner

AHeise commented on a change in pull request #13228: URL: https://github.com/apache/flink/pull/13228#discussion_r489203616 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/StreamTaskNetworkInput.java ## @@ -159,10 +158,12 @@ public InputSt

[GitHub] [flink] AHeise commented on a change in pull request #13228: [FLINK-19026][network] Improve threading model of CheckpointBarrierUnaligner

AHeise commented on a change in pull request #13228: URL: https://github.com/apache/flink/pull/13228#discussion_r489230779 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/source/coordinator/SourceCoordinatorContext.java ## @@ -261,8 +260,7 @@ void registerSo

[GitHub] [flink] AHeise commented on a change in pull request #13228: [FLINK-19026][network] Improve threading model of CheckpointBarrierUnaligner

AHeise commented on a change in pull request #13228: URL: https://github.com/apache/flink/pull/13228#discussion_r492481729 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/source/coordinator/SourceCoordinatorContext.java ## @@ -261,8 +260,7 @@ void registerSo

[GitHub] [flink] AHeise commented on a change in pull request #13228: [FLINK-19026][network] Improve threading model of CheckpointBarrierUnaligner

AHeise commented on a change in pull request #13228: URL: https://github.com/apache/flink/pull/13228#discussion_r492569960 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/SingleInputGate.java ## @@ -779,34 +820,56 @@ void trigge

[GitHub] [flink] AHeise commented on a change in pull request #13228: [FLINK-19026][network] Improve threading model of CheckpointBarrierUnaligner

AHeise commented on a change in pull request #13228: URL: https://github.com/apache/flink/pull/13228#discussion_r492570334 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/BufferAvailabilityListener.java ## @@ -34,11 +30,8 @@ void

[GitHub] [flink] AHeise commented on a change in pull request #13228: [FLINK-19026][network] Improve threading model of CheckpointBarrierUnaligner

AHeise commented on a change in pull request #13228: URL: https://github.com/apache/flink/pull/13228#discussion_r492571952 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/StreamMultipleInputProcessor.java ## @@ -147,6 +148,14 @@ else if (

[GitHub] [flink] AHeise commented on a change in pull request #13228: [FLINK-19026][network] Improve threading model of CheckpointBarrierUnaligner

AHeise commented on a change in pull request #13228: URL: https://github.com/apache/flink/pull/13228#discussion_r492591478 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartition.java ## @@ -173,50 +181,51 @@ private boolea

[GitHub] [flink] AHeise commented on a change in pull request #13228: [FLINK-19026][network] Improve threading model of CheckpointBarrierUnaligner

AHeise commented on a change in pull request #13228: URL: https://github.com/apache/flink/pull/13228#discussion_r492593809 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/LocalInputChannel.java ## @@ -210,15 +221,25 @@ public vo

[GitHub] [flink] AHeise commented on a change in pull request #13228: [FLINK-19026][network] Improve threading model of CheckpointBarrierUnaligner

AHeise commented on a change in pull request #13228: URL: https://github.com/apache/flink/pull/13228#discussion_r492593809 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/LocalInputChannel.java ## @@ -210,15 +221,25 @@ public vo

[GitHub] [flink] AHeise commented on a change in pull request #13228: [FLINK-19026][network] Improve threading model of CheckpointBarrierUnaligner

AHeise commented on a change in pull request #13228: URL: https://github.com/apache/flink/pull/13228#discussion_r492595477 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java ## @@ -454,42 +431,106 @@ public

[GitHub] [flink] AHeise commented on a change in pull request #13228: [FLINK-19026][network] Improve threading model of CheckpointBarrierUnaligner

AHeise commented on a change in pull request #13228: URL: https://github.com/apache/flink/pull/13228#discussion_r492595313 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java ## @@ -89,17 +96,15 @@ /*

[GitHub] [flink] AHeise commented on a change in pull request #13228: [FLINK-19026][network] Improve threading model of CheckpointBarrierUnaligner

AHeise commented on a change in pull request #13228: URL: https://github.com/apache/flink/pull/13228#discussion_r492596462 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java ## @@ -454,42 +431,106 @@ public

[GitHub] [flink] AHeise commented on a change in pull request #13228: [FLINK-19026][network] Improve threading model of CheckpointBarrierUnaligner

AHeise commented on a change in pull request #13228: URL: https://github.com/apache/flink/pull/13228#discussion_r492601594 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/StreamMultipleInputProcessor.java ## @@ -171,10 +183,36 @@ public I

[GitHub] [flink] AHeise commented on a change in pull request #13228: [FLINK-19026][network] Improve threading model of CheckpointBarrierUnaligner

AHeise commented on a change in pull request #13228: URL: https://github.com/apache/flink/pull/13228#discussion_r492601080 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/StreamMultipleInputProcessor.java ## @@ -171,10 +183,36 @@ public I

[GitHub] [flink] AHeise commented on a change in pull request #13228: [FLINK-19026][network] Improve threading model of CheckpointBarrierUnaligner

AHeise commented on a change in pull request #13228: URL: https://github.com/apache/flink/pull/13228#discussion_r492602447 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CheckpointBarrierUnaligner.java ## @@ -113,7 +113,11 @@ public void

[GitHub] [flink] AHeise commented on a change in pull request #13228: [FLINK-19026][network] Improve threading model of CheckpointBarrierUnaligner

AHeise commented on a change in pull request #13228: URL: https://github.com/apache/flink/pull/13228#discussion_r493025464 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/InputChannel.java ## @@ -361,4 +360,89 @@ public String t

[GitHub] [flink] AHeise commented on a change in pull request #13228: [FLINK-19026][network] Improve threading model of CheckpointBarrierUnaligner

AHeise commented on a change in pull request #13228: URL: https://github.com/apache/flink/pull/13228#discussion_r493035866 ## File path: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/io/StreamTaskNetworkInputTest.java ## @@ -120,67 +112,10 @@ public voi

[GitHub] [flink] AHeise commented on a change in pull request #13228: [FLINK-19026][network] Improve threading model of CheckpointBarrierUnaligner

AHeise commented on a change in pull request #13228: URL: https://github.com/apache/flink/pull/13228#discussion_r493039856 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/consumer/SingleInputGateTest.java ## @@ -812,242 +788,13 @@ public

[GitHub] [flink] AHeise commented on a change in pull request #13228: [FLINK-19026][network] Improve threading model of CheckpointBarrierUnaligner

AHeise commented on a change in pull request #13228: URL: https://github.com/apache/flink/pull/13228#discussion_r493044470 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CheckpointedInputGate.java ## @@ -62,9 +65,37 @@ */

[GitHub] [flink] AHeise commented on a change in pull request #13228: [FLINK-19026][network] Improve threading model of CheckpointBarrierUnaligner

AHeise commented on a change in pull request #13228: URL: https://github.com/apache/flink/pull/13228#discussion_r492481729 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/source/coordinator/SourceCoordinatorContext.java ## @@ -261,8 +260,7 @@ void registerSo

[GitHub] [flink] AHeise commented on a change in pull request #13228: [FLINK-19026][network] Improve threading model of CheckpointBarrierUnaligner

AHeise commented on a change in pull request #13228: URL: https://github.com/apache/flink/pull/13228#discussion_r476657231 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartition.java ## @@ -171,19 +175,42 @@ private void h

[GitHub] [flink] AHeise commented on a change in pull request #13228: [FLINK-19026][network] Improve threading model of CheckpointBarrierUnaligner

AHeise commented on a change in pull request #13228: URL: https://github.com/apache/flink/pull/13228#discussion_r476659669 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartition.java ## @@ -171,19 +175,42 @@ private void h

[GitHub] [flink] AHeise commented on a change in pull request #13228: [FLINK-19026][network] Improve threading model of CheckpointBarrierUnaligner

AHeise commented on a change in pull request #13228: URL: https://github.com/apache/flink/pull/13228#discussion_r476660921 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/SingleInputGate.java ## @@ -621,61 +626,84 @@ public bool

[GitHub] [flink] AHeise commented on a change in pull request #13228: [FLINK-19026][network] Improve threading model of CheckpointBarrierUnaligner

AHeise commented on a change in pull request #13228: URL: https://github.com/apache/flink/pull/13228#discussion_r476660758 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CreditBasedSequenceNumberingViewReader.java ## @@ -133,14 +136,14 @@ p

[GitHub] [flink] AHeise commented on a change in pull request #13228: [FLINK-19026][network] Improve threading model of CheckpointBarrierUnaligner

AHeise commented on a change in pull request #13228: URL: https://github.com/apache/flink/pull/13228#discussion_r476662192 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/SingleInputGate.java ## @@ -770,34 +808,50 @@ void trigge

[GitHub] [flink] AHeise commented on a change in pull request #13228: [FLINK-19026][network] Improve threading model of CheckpointBarrierUnaligner

AHeise commented on a change in pull request #13228: URL: https://github.com/apache/flink/pull/13228#discussion_r476665640 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java ## @@ -195,28 +193,27 @@ void ret

[GitHub] [flink] AHeise commented on a change in pull request #13228: [FLINK-19026][network] Improve threading model of CheckpointBarrierUnaligner

AHeise commented on a change in pull request #13228: URL: https://github.com/apache/flink/pull/13228#discussion_r476673355 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CheckpointedInputGate.java ## @@ -63,9 +66,38 @@ */

[GitHub] [flink] AHeise commented on a change in pull request #13228: [FLINK-19026][network] Improve threading model of CheckpointBarrierUnaligner

AHeise commented on a change in pull request #13228: URL: https://github.com/apache/flink/pull/13228#discussion_r476674004 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CheckpointedInputGate.java ## @@ -74,34 +106,34 @@ public Checkpoin

[GitHub] [flink] AHeise commented on a change in pull request #13228: [FLINK-19026][network] Improve threading model of CheckpointBarrierUnaligner

AHeise commented on a change in pull request #13228: URL: https://github.com/apache/flink/pull/13228#discussion_r476675096 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CheckpointedInputGate.java ## @@ -63,9 +66,38 @@ */

[GitHub] [flink] AHeise commented on a change in pull request #13228: [FLINK-19026][network] Improve threading model of CheckpointBarrierUnaligner

AHeise commented on a change in pull request #13228: URL: https://github.com/apache/flink/pull/13228#discussion_r476674004 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CheckpointedInputGate.java ## @@ -74,34 +106,34 @@ public Checkpoin

[GitHub] [flink] AHeise commented on a change in pull request #13228: [FLINK-19026][network] Improve threading model of CheckpointBarrierUnaligner

AHeise commented on a change in pull request #13228: URL: https://github.com/apache/flink/pull/13228#discussion_r476677925 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CheckpointedInputGate.java ## @@ -74,34 +106,34 @@ public Checkpoin

[GitHub] [flink] AHeise commented on a change in pull request #13228: [FLINK-19026][network] Improve threading model of CheckpointBarrierUnaligner

AHeise commented on a change in pull request #13228: URL: https://github.com/apache/flink/pull/13228#discussion_r476678903 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/StreamTaskNetworkInput.java ## @@ -159,10 +158,12 @@ public InputSt

[GitHub] [flink] AHeise commented on a change in pull request #13228: [FLINK-19026][network] Improve threading model of CheckpointBarrierUnaligner

AHeise commented on a change in pull request #13228: URL: https://github.com/apache/flink/pull/13228#discussion_r476683415 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CheckpointBarrierUnaligner.java ## @@ -92,306 +90,173 @@