[GitHub] [flink] Airblader commented on a change in pull request #16046: [FLINK-22737][table-planner-blink] Introduce CURRENT_WATERMARK()

2021-06-10 Thread GitBox
Airblader commented on a change in pull request #16046: URL: https://github.com/apache/flink/pull/16046#discussion_r649090357 ## File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/CalcITCase.scala ## @@ -433,4 +435

[GitHub] [flink] Airblader commented on a change in pull request #16046: [FLINK-22737][table-planner-blink] Introduce CURRENT_WATERMARK()

2021-06-10 Thread GitBox
Airblader commented on a change in pull request #16046: URL: https://github.com/apache/flink/pull/16046#discussion_r649149621 ## File path: flink-table/flink-table-common/src/test/java/org/apache/flink/table/types/inference/TypeStrategiesTest.java ## @@ -311,7 +315,21 @@

[GitHub] [flink] Airblader commented on a change in pull request #16046: [FLINK-22737][table-planner-blink] Introduce CURRENT_WATERMARK()

2021-06-10 Thread GitBox
Airblader commented on a change in pull request #16046: URL: https://github.com/apache/flink/pull/16046#discussion_r649097736 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/CurrentWatermarkInputTypeStrategy.java ##

[GitHub] [flink] Airblader commented on a change in pull request #16046: [FLINK-22737][table-planner-blink] Introduce CURRENT_WATERMARK()

2021-06-10 Thread GitBox
Airblader commented on a change in pull request #16046: URL: https://github.com/apache/flink/pull/16046#discussion_r649090357 ## File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/CalcITCase.scala ## @@ -433,4 +435

[GitHub] [flink] Airblader commented on a change in pull request #16046: [FLINK-22737][table-planner-blink] Introduce CURRENT_WATERMARK()

2021-06-10 Thread GitBox
Airblader commented on a change in pull request #16046: URL: https://github.com/apache/flink/pull/16046#discussion_r649081779 ## File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/codegen/GenerateUtils.scala ## @@ -543,6 +543,32 @@ o

[GitHub] [flink] Airblader commented on a change in pull request #16046: [FLINK-22737][table-planner-blink] Introduce CURRENT_WATERMARK()

2021-06-10 Thread GitBox
Airblader commented on a change in pull request #16046: URL: https://github.com/apache/flink/pull/16046#discussion_r649080052 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/Expressions.java ## @@ -211,6 +211,27 @@ public static ApiExpre

[GitHub] [flink] Airblader commented on a change in pull request #16046: [FLINK-22737][table-planner-blink] Introduce CURRENT_WATERMARK()

2021-06-10 Thread GitBox
Airblader commented on a change in pull request #16046: URL: https://github.com/apache/flink/pull/16046#discussion_r648905113 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/CurrentWatermarkInputTypeStrategy.java ##

[GitHub] [flink] Airblader commented on a change in pull request #16046: [FLINK-22737][table-planner-blink] Introduce CURRENT_WATERMARK()

2021-06-10 Thread GitBox
Airblader commented on a change in pull request #16046: URL: https://github.com/apache/flink/pull/16046#discussion_r648903537 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/CurrentWatermarkInputTypeStrategy.java ##

[GitHub] [flink] Airblader commented on a change in pull request #16046: [FLINK-22737][table-planner-blink] Introduce CURRENT_WATERMARK()

2021-06-09 Thread GitBox
Airblader commented on a change in pull request #16046: URL: https://github.com/apache/flink/pull/16046#discussion_r648889963 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinition.java ## @@ -53,19 +53,23 @@

[GitHub] [flink] Airblader commented on a change in pull request #16046: [FLINK-22737][table-planner-blink] Introduce CURRENT_WATERMARK()

2021-06-09 Thread GitBox
Airblader commented on a change in pull request #16046: URL: https://github.com/apache/flink/pull/16046#discussion_r648871106 ## File path: docs/data/sql_functions.yml ## @@ -485,6 +485,14 @@ temporal: description: "Converts a epoch seconds or epoch milliseconds to a TIME

[GitHub] [flink] Airblader commented on a change in pull request #16046: [FLINK-22737][table-planner-blink] Introduce CURRENT_WATERMARK()

2021-06-09 Thread GitBox
Airblader commented on a change in pull request #16046: URL: https://github.com/apache/flink/pull/16046#discussion_r648858367 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinition.java ## @@ -53,19 +53,23 @@