Airblader commented on a change in pull request #16793:
URL: https://github.com/apache/flink/pull/16793#discussion_r688307794
##########
File path:
flink-table/flink-table-api-java-bridge/src/main/java/org/apache/flink/table/api/bridge/java/internal/StreamTableEnvironmentImpl.java
##########
@@ -125,11 +125,6 @@ public static StreamTableEnvironment create(
EnvironmentSettings settings,
TableConfig tableConfig) {
- if (!settings.isStreamingMode()) {
Review comment:
:tada:
##########
File path:
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/calcite/FlinkContext.scala
##########
@@ -28,6 +28,11 @@ import org.apache.calcite.plan.Context
*/
trait FlinkContext extends Context {
+ /**
+ * Returns whether the planner runs in batch mode.
+ */
+ def isBatchMode: Boolean
Review comment:
nit: why not stick with the `isStreamingMode` terminology we seem to be
using in other places already?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
