[GitHub] [flink] Airblader commented on pull request #17186: [FLINK-16203][table] Support JSON_OBJECT()

2021-09-16 Thread GitBox
Airblader commented on pull request #17186: URL: https://github.com/apache/flink/pull/17186#issuecomment-920833517 I've opened https://issues.apache.org/jira/browse/FLINK-24311 to track that part. -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [flink] Airblader commented on pull request #17186: [FLINK-16203][table] Support JSON_OBJECT()

2021-09-16 Thread GitBox
Airblader commented on pull request #17186: URL: https://github.com/apache/flink/pull/17186#issuecomment-920783832 I see. Thanks, I'll create the issue. Documenting a rough idea will also be helpful! -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [flink] Airblader commented on pull request #17186: [FLINK-16203][table] Support JSON_OBJECT()

2021-09-16 Thread GitBox
Airblader commented on pull request #17186: URL: https://github.com/apache/flink/pull/17186#issuecomment-920756220 > We can create a JIRA for supporting JSON_OBJECT expression reducing. I don't know how that would possibly work, though? We'd somehow have to "tag" the RexLiteral so we

[GitHub] [flink] Airblader commented on pull request #17186: [FLINK-16203][table] Support JSON_OBJECT()

2021-09-15 Thread GitBox
Airblader commented on pull request #17186: URL: https://github.com/apache/flink/pull/17186#issuecomment-920601084 @JingsongLi Thanks for taking care of this PR! I squashed the fixup commits now. > This is interesting. Can we create a JIRA to track this issue? We can try to fix this

[GitHub] [flink] Airblader commented on pull request #17186: [FLINK-16203][table] Support JSON_OBJECT()

2021-09-14 Thread GitBox
Airblader commented on pull request #17186: URL: https://github.com/apache/flink/pull/17186#issuecomment-919139597 There is one interesting point still: ``` -- '{"A":{"K":"V"}}' JSON_OBJECT('A' VALUE JSON_OBJECT('K' VALUE 'V')) -- '{"A":"{\"K\":\"V\"},\"EXPR$0\":1}' JS

[GitHub] [flink] Airblader commented on pull request #17186: [FLINK-16203][table] Support JSON_OBJECT()

2021-09-09 Thread GitBox
Airblader commented on pull request #17186: URL: https://github.com/apache/flink/pull/17186#issuecomment-916143656 As discussed offline I will investigate if we can reproduce the funky, but admittedly more convenient behavior other implementations expose. -- This is an automated message