[GitHub] [flink] Aitozi commented on a change in pull request #16894: [FLINK-23871][Runtime/Coordination]Dispatcher should handle finishing…

2021-08-20 Thread GitBox
Aitozi commented on a change in pull request #16894: URL: https://github.com/apache/flink/pull/16894#discussion_r693277592 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobAlreadyDoneException.java ## @@ -0,0 +1,35 @@ +/* + * Licensed to the Apac

[GitHub] [flink] Aitozi commented on a change in pull request #16894: [FLINK-23871][Runtime/Coordination]Dispatcher should handle finishing…

2021-08-20 Thread GitBox
Aitozi commented on a change in pull request #16894: URL: https://github.com/apache/flink/pull/16894#discussion_r692876011 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/DefaultJobMasterServiceProcess.java ## @@ -214,15 +214,6 @@ public void jobR

[GitHub] [flink] Aitozi commented on a change in pull request #16894: [FLINK-23871][Runtime/Coordination]Dispatcher should handle finishing…

2021-08-20 Thread GitBox
Aitozi commented on a change in pull request #16894: URL: https://github.com/apache/flink/pull/16894#discussion_r692873731 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/DispatcherTest.java ## @@ -578,6 +579,45 @@ public void testFatalErrorIfReco

[GitHub] [flink] Aitozi commented on a change in pull request #16894: [FLINK-23871][Runtime/Coordination]Dispatcher should handle finishing…

2021-08-20 Thread GitBox
Aitozi commented on a change in pull request #16894: URL: https://github.com/apache/flink/pull/16894#discussion_r692873178 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobFinishingException.java ## @@ -0,0 +1,31 @@ +/* + * Licensed to the Apache

[GitHub] [flink] Aitozi commented on a change in pull request #16894: [FLINK-23871][Runtime/Coordination]Dispatcher should handle finishing…

2021-08-20 Thread GitBox
Aitozi commented on a change in pull request #16894: URL: https://github.com/apache/flink/pull/16894#discussion_r692873064 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java ## @@ -446,9 +446,13 @@ private CleanupJobState handleJobMan