[GitHub] [flink] Aitozi commented on a diff in pull request #21522: [FLINK-29585][hive] Migrate TableSchema to Schema for Hive connector

Aitozi commented on code in PR #21522: URL: https://github.com/apache/flink/pull/21522#discussion_r1139884241 ## flink-table/flink-table-common/src/test/java/org/apache/flink/table/catalog/TestSchemaResolver.java: ## @@ -0,0 +1,199 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [flink] Aitozi commented on a diff in pull request #21522: [FLINK-29585][hive] Migrate TableSchema to Schema for Hive connector

Aitozi commented on code in PR #21522: URL: https://github.com/apache/flink/pull/21522#discussion_r1139876700 ## flink-table/flink-table-common/src/test/java/org/apache/flink/table/catalog/TestSchemaResolver.java: ## @@ -0,0 +1,199 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [flink] Aitozi commented on a diff in pull request #21522: [FLINK-29585][hive] Migrate TableSchema to Schema for Hive connector

Aitozi commented on code in PR #21522: URL: https://github.com/apache/flink/pull/21522#discussion_r1139726153 ## flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/table/catalog/hive/HiveCatalogITCase.java: ## @@ -503,16 +522,16 @@ public void testViewSchema()

[GitHub] [flink] Aitozi commented on a diff in pull request #21522: [FLINK-29585][hive] Migrate TableSchema to Schema for Hive connector

Aitozi commented on code in PR #21522: URL: https://github.com/apache/flink/pull/21522#discussion_r1139716355 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/util/HiveTableUtil.java: ## @@ -96,11 +106,104 @@ public class HiveTableUtil {

[GitHub] [flink] Aitozi commented on a diff in pull request #21522: [FLINK-29585][hive] Migrate TableSchema to Schema for Hive connector

Aitozi commented on code in PR #21522: URL: https://github.com/apache/flink/pull/21522#discussion_r1139710984 ## flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/table/catalog/hive/HiveCatalogITCase.java: ## @@ -503,16 +522,16 @@ public void testViewSchema()

[GitHub] [flink] Aitozi commented on a diff in pull request #21522: [FLINK-29585][hive] Migrate TableSchema to Schema for Hive connector

Aitozi commented on code in PR #21522: URL: https://github.com/apache/flink/pull/21522#discussion_r1139706415 ## flink-table/flink-table-common/src/test/java/org/apache/flink/table/catalog/TestSchemaResolver.java: ## @@ -0,0 +1,199 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [flink] Aitozi commented on a diff in pull request #21522: [FLINK-29585][hive] Migrate TableSchema to Schema for Hive connector

Aitozi commented on code in PR #21522: URL: https://github.com/apache/flink/pull/21522#discussion_r1139701322 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/util/HiveTableUtil.java: ## @@ -96,11 +106,104 @@ public class HiveTableUtil {

[GitHub] [flink] Aitozi commented on a diff in pull request #21522: [FLINK-29585][hive] Migrate TableSchema to Schema for Hive connector

Aitozi commented on code in PR #21522: URL: https://github.com/apache/flink/pull/21522#discussion_r1139685134 ## flink-table/flink-table-common/src/test/java/org/apache/flink/table/catalog/TestSchemaResolver.java: ## @@ -0,0 +1,199 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [flink] Aitozi commented on a diff in pull request #21522: [FLINK-29585][hive] Migrate TableSchema to Schema for Hive connector

Aitozi commented on code in PR #21522: URL: https://github.com/apache/flink/pull/21522#discussion_r1139678740 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/CatalogPropertiesUtil.java: ## @@ -91,16 +91,50 @@ public static Map serializeCatalogTabl

[GitHub] [flink] Aitozi commented on a diff in pull request #21522: [FLINK-29585][hive] Migrate TableSchema to Schema for Hive connector

Aitozi commented on code in PR #21522: URL: https://github.com/apache/flink/pull/21522#discussion_r1139673570 ## flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/table/catalog/hive/HiveCatalogITCase.java: ## @@ -503,16 +522,16 @@ public void testViewSchema()

[GitHub] [flink] Aitozi commented on a diff in pull request #21522: [FLINK-29585][hive] Migrate TableSchema to Schema for Hive connector

Aitozi commented on code in PR #21522: URL: https://github.com/apache/flink/pull/21522#discussion_r1139668108 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/planner/delegation/hive/HiveParserDMLHelper.java: ## @@ -682,11 +682,11 @@ private RelNode

[GitHub] [flink] Aitozi commented on a diff in pull request #21522: [FLINK-29585][hive] Migrate TableSchema to Schema for Hive connector

Aitozi commented on code in PR #21522: URL: https://github.com/apache/flink/pull/21522#discussion_r1138429963 ## flink-table/flink-table-common/src/test/java/org/apache/flink/table/catalog/TestSchemaResolver.java: ## @@ -0,0 +1,199 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [flink] Aitozi commented on a diff in pull request #21522: [FLINK-29585][hive] Migrate TableSchema to Schema for Hive connector

Aitozi commented on code in PR #21522: URL: https://github.com/apache/flink/pull/21522#discussion_r1138424847 ## flink-table/flink-table-common/src/test/java/org/apache/flink/table/catalog/CatalogTestUtil.java: ## @@ -63,7 +79,22 @@ public static void checkEquals(CatalogTable t1

[GitHub] [flink] Aitozi commented on a diff in pull request #21522: [FLINK-29585][hive] Migrate TableSchema to Schema for Hive connector

Aitozi commented on code in PR #21522: URL: https://github.com/apache/flink/pull/21522#discussion_r1138419530 ## flink-table/flink-table-common/src/test/java/org/apache/flink/table/catalog/TestSchemaResolver.java: ## @@ -0,0 +1,199 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [flink] Aitozi commented on a diff in pull request #21522: [FLINK-29585][hive] Migrate TableSchema to Schema for Hive connector

Aitozi commented on code in PR #21522: URL: https://github.com/apache/flink/pull/21522#discussion_r1138416501 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/util/HiveTableUtil.java: ## @@ -111,25 +192,20 @@ public static TableSchema cr

[GitHub] [flink] Aitozi commented on a diff in pull request #21522: [FLINK-29585][hive] Migrate TableSchema to Schema for Hive connector

Aitozi commented on code in PR #21522: URL: https://github.com/apache/flink/pull/21522#discussion_r1138315797 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/planner/delegation/hive/HiveParserDMLHelper.java: ## @@ -154,11 +154,12 @@ public HiveParse

[GitHub] [flink] Aitozi commented on a diff in pull request #21522: [FLINK-29585][hive] Migrate TableSchema to Schema for Hive connector

Aitozi commented on code in PR #21522: URL: https://github.com/apache/flink/pull/21522#discussion_r1138306100 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/HiveSourceBuilder.java: ## @@ -150,13 +150,13 @@ public HiveSourceBuilder(

[GitHub] [flink] Aitozi commented on a diff in pull request #21522: [FLINK-29585][hive] Migrate TableSchema to Schema for Hive connector

Aitozi commented on code in PR #21522: URL: https://github.com/apache/flink/pull/21522#discussion_r1138305194 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/HiveTableSink.java: ## @@ -703,7 +704,7 @@ private CompactReader.Factory createC

[GitHub] [flink] Aitozi commented on a diff in pull request #21522: [FLINK-29585][hive] Migrate TableSchema to Schema for Hive connector

Aitozi commented on code in PR #21522: URL: https://github.com/apache/flink/pull/21522#discussion_r1137252363 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/planner/delegation/hive/HiveParserDMLHelper.java: ## @@ -154,11 +154,12 @@ public HiveParse

[GitHub] [flink] Aitozi commented on a diff in pull request #21522: [FLINK-29585][hive] Migrate TableSchema to Schema for Hive connector

Aitozi commented on code in PR #21522: URL: https://github.com/apache/flink/pull/21522#discussion_r1137138190 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/planner/delegation/hive/HiveParserCalcitePlanner.java: ## @@ -821,13 +823,15 @@ private Rel

[GitHub] [flink] Aitozi commented on a diff in pull request #21522: [FLINK-29585][hive] Migrate TableSchema to Schema for Hive connector

Aitozi commented on code in PR #21522: URL: https://github.com/apache/flink/pull/21522#discussion_r1137123345 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/HiveTableSource.java: ## @@ -348,13 +330,16 @@ public TableStats reportStatistics

[GitHub] [flink] Aitozi commented on a diff in pull request #21522: [FLINK-29585][hive] Migrate TableSchema to Schema for Hive connector

Aitozi commented on code in PR #21522: URL: https://github.com/apache/flink/pull/21522#discussion_r1137119837 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/HiveTableSource.java: ## @@ -348,13 +330,16 @@ public TableStats reportStatistics

[GitHub] [flink] Aitozi commented on a diff in pull request #21522: [FLINK-29585][hive] Migrate TableSchema to Schema for Hive connector

Aitozi commented on code in PR #21522: URL: https://github.com/apache/flink/pull/21522#discussion_r1137118817 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/HiveTableSource.java: ## @@ -127,6 +128,7 @@ public HiveTableSource(

[GitHub] [flink] Aitozi commented on a diff in pull request #21522: [FLINK-29585][hive] Migrate TableSchema to Schema for Hive connector

Aitozi commented on code in PR #21522: URL: https://github.com/apache/flink/pull/21522#discussion_r1137117080 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/HiveSourceBuilder.java: ## @@ -150,13 +150,13 @@ public HiveSourceBuilder(

[GitHub] [flink] Aitozi commented on a diff in pull request #21522: [FLINK-29585][hive] Migrate TableSchema to Schema for Hive connector

Aitozi commented on code in PR #21522: URL: https://github.com/apache/flink/pull/21522#discussion_r1137115733 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/HiveTableSink.java: ## @@ -703,7 +704,7 @@ private CompactReader.Factory createC

[GitHub] [flink] Aitozi commented on a diff in pull request #21522: [FLINK-29585][hive] Migrate TableSchema to Schema for Hive connector

Aitozi commented on code in PR #21522: URL: https://github.com/apache/flink/pull/21522#discussion_r1137091668 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/HiveLookupTableSource.java: ## @@ -258,8 +256,12 @@ private TableFunction getLook

[GitHub] [flink] Aitozi commented on a diff in pull request #21522: [FLINK-29585][hive] Migrate TableSchema to Schema for Hive connector

Aitozi commented on code in PR #21522: URL: https://github.com/apache/flink/pull/21522#discussion_r1137044316 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/CatalogPropertiesUtil.java: ## @@ -176,30 +211,32 @@ private static List deserializeParti

[GitHub] [flink] Aitozi commented on a diff in pull request #21522: [FLINK-29585][hive] Migrate TableSchema to Schema for Hive connector

Aitozi commented on code in PR #21522: URL: https://github.com/apache/flink/pull/21522#discussion_r1137044316 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/CatalogPropertiesUtil.java: ## @@ -176,30 +211,32 @@ private static List deserializeParti

[GitHub] [flink] Aitozi commented on a diff in pull request #21522: [FLINK-29585][hive] Migrate TableSchema to Schema for Hive connector

Aitozi commented on code in PR #21522: URL: https://github.com/apache/flink/pull/21522#discussion_r1137041528 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/CatalogPropertiesUtil.java: ## @@ -472,7 +510,8 @@ private static int getCount(Map map, St

[GitHub] [flink] Aitozi commented on a diff in pull request #21522: [FLINK-29585][hive] Migrate TableSchema to Schema for Hive connector

Aitozi commented on code in PR #21522: URL: https://github.com/apache/flink/pull/21522#discussion_r1137037538 ## flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/catalog/GenericInMemoryCatalogTest.java: ## @@ -50,6 +51,7 @@ class GenericInMemoryCatalogTest e

[GitHub] [flink] Aitozi commented on a diff in pull request #21522: [FLINK-29585][hive] Migrate TableSchema to Schema for Hive connector

Aitozi commented on code in PR #21522: URL: https://github.com/apache/flink/pull/21522#discussion_r1135799561 ## flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/table/catalog/hive/HiveCatalogMetadataTestBase.java: ## @@ -60,4 +65,50 @@ public void testCreate

[GitHub] [flink] Aitozi commented on a diff in pull request #21522: [FLINK-29585][hive] Migrate TableSchema to Schema for Hive connector

Aitozi commented on code in PR #21522: URL: https://github.com/apache/flink/pull/21522#discussion_r1135797952 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/HiveCatalog.java: ## @@ -763,7 +783,7 @@ CatalogBaseTable instantiateCatalogTa

[GitHub] [flink] Aitozi commented on a diff in pull request #21522: [FLINK-29585][hive] Migrate TableSchema to Schema for Hive connector

Aitozi commented on code in PR #21522: URL: https://github.com/apache/flink/pull/21522#discussion_r1134809157 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/utils/OperationConverterUtils.java: ## @@ -157,12 +165,12 @@ public static Operation conv

[GitHub] [flink] Aitozi commented on a diff in pull request #21522: [FLINK-29585][hive] Migrate TableSchema to Schema for Hive connector

Aitozi commented on code in PR #21522: URL: https://github.com/apache/flink/pull/21522#discussion_r1134803012 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/utils/OperationConverterUtils.java: ## @@ -69,67 +69,75 @@ private OperationConverterUtil

[GitHub] [flink] Aitozi commented on a diff in pull request #21522: [FLINK-29585][hive] Migrate TableSchema to Schema for Hive connector

Aitozi commented on code in PR #21522: URL: https://github.com/apache/flink/pull/21522#discussion_r1134309529 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/HiveSourceBuilder.java: ## @@ -281,12 +278,12 @@ public HiveSourceBuilder setLimi

[GitHub] [flink] Aitozi commented on a diff in pull request #21522: [FLINK-29585][hive] Migrate TableSchema to Schema for Hive connector

Aitozi commented on code in PR #21522: URL: https://github.com/apache/flink/pull/21522#discussion_r1134283226 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/utils/OperationConverterUtils.java: ## @@ -69,67 +69,75 @@ private OperationConverterUtil

[GitHub] [flink] Aitozi commented on a diff in pull request #21522: [FLINK-29585][hive] Migrate TableSchema to Schema for Hive connector

Aitozi commented on code in PR #21522: URL: https://github.com/apache/flink/pull/21522#discussion_r1134279553 ## flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/table/catalog/hive/HiveCatalogMetadataTestBase.java: ## @@ -60,4 +65,50 @@ public void testCreate

[GitHub] [flink] Aitozi commented on a diff in pull request #21522: [FLINK-29585][hive] Migrate TableSchema to Schema for Hive connector

Aitozi commented on code in PR #21522: URL: https://github.com/apache/flink/pull/21522#discussion_r1134269897 ## flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveLookupJoinITCase.java: ## @@ -205,10 +208,22 @@ public void testPartitionFetc

[GitHub] [flink] Aitozi commented on a diff in pull request #21522: [FLINK-29585][hive] Migrate TableSchema to Schema for Hive connector

Aitozi commented on code in PR #21522: URL: https://github.com/apache/flink/pull/21522#discussion_r1134257301 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/planner/delegation/hive/HiveParserCalcitePlanner.java: ## @@ -821,13 +823,15 @@ private Rel

[GitHub] [flink] Aitozi commented on a diff in pull request #21522: [FLINK-29585][hive] Migrate TableSchema to Schema for Hive connector

Aitozi commented on code in PR #21522: URL: https://github.com/apache/flink/pull/21522#discussion_r1134248086 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/util/HiveTableUtil.java: ## @@ -97,7 +102,54 @@ public class HiveTableUtil {

[GitHub] [flink] Aitozi commented on a diff in pull request #21522: [FLINK-29585][hive] Migrate TableSchema to Schema for Hive connector

Aitozi commented on code in PR #21522: URL: https://github.com/apache/flink/pull/21522#discussion_r1134219628 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/HiveCatalog.java: ## @@ -763,7 +783,7 @@ CatalogBaseTable instantiateCatalogTa

[GitHub] [flink] Aitozi commented on a diff in pull request #21522: [FLINK-29585][hive] Migrate TableSchema to Schema for Hive connector

Aitozi commented on code in PR #21522: URL: https://github.com/apache/flink/pull/21522#discussion_r1134212972 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/HiveCatalog.java: ## @@ -473,27 +476,37 @@ public void createTable(ObjectPath

[GitHub] [flink] Aitozi commented on a diff in pull request #21522: [FLINK-29585][hive] Migrate TableSchema to Schema for Hive connector

Aitozi commented on code in PR #21522: URL: https://github.com/apache/flink/pull/21522#discussion_r1130546283 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/api/Schema.java: ## @@ -611,7 +611,9 @@ private void addResolvedColumns(List columns) {

[GitHub] [flink] Aitozi commented on a diff in pull request #21522: [FLINK-29585][hive] Migrate TableSchema to Schema for Hive connector

Aitozi commented on code in PR #21522: URL: https://github.com/apache/flink/pull/21522#discussion_r1130546283 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/api/Schema.java: ## @@ -611,7 +611,9 @@ private void addResolvedColumns(List columns) {

[GitHub] [flink] Aitozi commented on a diff in pull request #21522: [FLINK-29585][hive] Migrate TableSchema to Schema for Hive connector

Aitozi commented on code in PR #21522: URL: https://github.com/apache/flink/pull/21522#discussion_r1129605975 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/planner/delegation/hive/parse/HiveParserDDLSemanticAnalyzer.java: ## @@ -1966,61 +1982,60 @

[GitHub] [flink] Aitozi commented on a diff in pull request #21522: [FLINK-29585][hive] Migrate TableSchema to Schema for Hive connector

Aitozi commented on code in PR #21522: URL: https://github.com/apache/flink/pull/21522#discussion_r1129582760 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/planner/delegation/hive/copy/HiveParserBaseSemanticAnalyzer.java: ## @@ -2106,7 +2111,7 @@

[GitHub] [flink] Aitozi commented on a diff in pull request #21522: [FLINK-29585][hive] Migrate TableSchema to Schema for Hive connector

Aitozi commented on code in PR #21522: URL: https://github.com/apache/flink/pull/21522#discussion_r1122955305 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/HiveTableSink.java: ## @@ -558,14 +559,14 @@ private HadoopFileSystemFactory fsFa

[GitHub] [flink] Aitozi commented on a diff in pull request #21522: [FLINK-29585][hive] Migrate TableSchema to Schema for Hive connector

Aitozi commented on code in PR #21522: URL: https://github.com/apache/flink/pull/21522#discussion_r1122954392 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/HiveTableSink.java: ## @@ -558,14 +559,14 @@ private HadoopFileSystemFactory fsFa