[GitHub] [flink] CrynetLogistics commented on a change in pull request #18553: [FLINK-25846][FLINK-25848] Async Sink does not gracefully shutdown on Cancel, KDS Sink does not fast fail when invalid co

2022-02-10 Thread GitBox
CrynetLogistics commented on a change in pull request #18553: URL: https://github.com/apache/flink/pull/18553#discussion_r803916593 ## File path: flink-connectors/flink-connector-aws-kinesis-firehose/src/test/java/org/apache/flink/connector/firehose/sink/KinesisFirehoseSinkITCase.java

[GitHub] [flink] CrynetLogistics commented on a change in pull request #18553: [FLINK-25846][FLINK-25848] Async Sink does not gracefully shutdown on Cancel, KDS Sink does not fast fail when invalid co

2022-02-10 Thread GitBox
CrynetLogistics commented on a change in pull request #18553: URL: https://github.com/apache/flink/pull/18553#discussion_r803912203 ## File path: flink-connectors/flink-connector-aws-kinesis-firehose/src/test/java/org/apache/flink/connector/firehose/sink/KinesisFirehoseSinkITCase.java

[GitHub] [flink] CrynetLogistics commented on a change in pull request #18553: [FLINK-25846][FLINK-25848] Async Sink does not gracefully shutdown on Cancel, KDS Sink does not fast fail when invalid co

2022-02-10 Thread GitBox
CrynetLogistics commented on a change in pull request #18553: URL: https://github.com/apache/flink/pull/18553#discussion_r803892402 ## File path: flink-connectors/flink-connector-aws-kinesis-firehose/src/test/java/org/apache/flink/connector/firehose/sink/KinesisFirehoseSinkITCase.java

[GitHub] [flink] CrynetLogistics commented on a change in pull request #18553: [FLINK-25846][FLINK-25848] Async Sink does not gracefully shutdown on Cancel, KDS Sink does not fast fail when invalid co

2022-02-10 Thread GitBox
CrynetLogistics commented on a change in pull request #18553: URL: https://github.com/apache/flink/pull/18553#discussion_r803884132 ## File path: flink-connectors/flink-connector-aws-kinesis-firehose/src/test/java/org/apache/flink/connector/firehose/sink/KinesisFirehoseSinkITCase.java

[GitHub] [flink] CrynetLogistics commented on a change in pull request #18553: [FLINK-25846][FLINK-25848] Async Sink does not gracefully shutdown on Cancel, KDS Sink does not fast fail when invalid co

2022-02-10 Thread GitBox
CrynetLogistics commented on a change in pull request #18553: URL: https://github.com/apache/flink/pull/18553#discussion_r803882048 ## File path: flink-connectors/flink-connector-aws-kinesis-firehose/src/test/java/org/apache/flink/connector/firehose/sink/KinesisFirehoseSinkITCase.java

[GitHub] [flink] CrynetLogistics commented on a change in pull request #18553: [FLINK-25846][FLINK-25848] Async Sink does not gracefully shutdown on Cancel, KDS Sink does not fast fail when invalid co

2022-02-10 Thread GitBox
CrynetLogistics commented on a change in pull request #18553: URL: https://github.com/apache/flink/pull/18553#discussion_r803742615 ## File path: flink-connectors/flink-connector-aws-kinesis-firehose/src/test/java/org/apache/flink/connector/firehose/sink/KinesisFirehoseSinkITCase.java

[GitHub] [flink] CrynetLogistics commented on a change in pull request #18553: [FLINK-25846][FLINK-25848] Async Sink does not gracefully shutdown on Cancel, KDS Sink does not fast fail when invalid co

2022-02-10 Thread GitBox
CrynetLogistics commented on a change in pull request #18553: URL: https://github.com/apache/flink/pull/18553#discussion_r803629071 ## File path: flink-connectors/flink-connector-aws-kinesis-firehose/src/test/java/org/apache/flink/connector/firehose/sink/KinesisFirehoseSinkITCase.java

[GitHub] [flink] CrynetLogistics commented on a change in pull request #18553: [FLINK-25846][FLINK-25848] Async Sink does not gracefully shutdown on Cancel, KDS Sink does not fast fail when invalid co

2022-02-10 Thread GitBox
CrynetLogistics commented on a change in pull request #18553: URL: https://github.com/apache/flink/pull/18553#discussion_r803545078 ## File path: flink-connectors/flink-connector-aws-kinesis-firehose/src/test/java/org/apache/flink/connector/firehose/sink/testutils/KinesisFirehoseTestU

[GitHub] [flink] CrynetLogistics commented on a change in pull request #18553: [FLINK-25846][FLINK-25848] Async Sink does not gracefully shutdown on Cancel, KDS Sink does not fast fail when invalid co

2022-02-09 Thread GitBox
CrynetLogistics commented on a change in pull request #18553: URL: https://github.com/apache/flink/pull/18553#discussion_r802714499 ## File path: flink-connectors/flink-connector-aws-kinesis-firehose/src/test/java/org/apache/flink/connector/firehose/sink/KinesisFirehoseSinkITCase.java

[GitHub] [flink] CrynetLogistics commented on a change in pull request #18553: [FLINK-25846][FLINK-25848] Async Sink does not gracefully shutdown on Cancel, KDS Sink does not fast fail when invalid co

2022-02-09 Thread GitBox
CrynetLogistics commented on a change in pull request #18553: URL: https://github.com/apache/flink/pull/18553#discussion_r802478252 ## File path: flink-connectors/flink-connector-aws-kinesis-firehose/src/test/java/org/apache/flink/connector/firehose/sink/KinesisFirehoseSinkITCase.java

[GitHub] [flink] CrynetLogistics commented on a change in pull request #18553: [FLINK-25846][FLINK-25848] Async Sink does not gracefully shutdown on Cancel, KDS Sink does not fast fail when invalid co

2022-02-09 Thread GitBox
CrynetLogistics commented on a change in pull request #18553: URL: https://github.com/apache/flink/pull/18553#discussion_r802478252 ## File path: flink-connectors/flink-connector-aws-kinesis-firehose/src/test/java/org/apache/flink/connector/firehose/sink/KinesisFirehoseSinkITCase.java

[GitHub] [flink] CrynetLogistics commented on a change in pull request #18553: [FLINK-25846][FLINK-25848] Async Sink does not gracefully shutdown on Cancel, KDS Sink does not fast fail when invalid co

2022-02-09 Thread GitBox
CrynetLogistics commented on a change in pull request #18553: URL: https://github.com/apache/flink/pull/18553#discussion_r802478022 ## File path: flink-connectors/flink-connector-aws-kinesis-firehose/src/test/java/org/apache/flink/connector/firehose/sink/KinesisFirehoseSinkITCase.java

[GitHub] [flink] CrynetLogistics commented on a change in pull request #18553: [FLINK-25846][FLINK-25848] Async Sink does not gracefully shutdown on Cancel, KDS Sink does not fast fail when invalid co

2022-01-31 Thread GitBox
CrynetLogistics commented on a change in pull request #18553: URL: https://github.com/apache/flink/pull/18553#discussion_r795529758 ## File path: flink-connectors/flink-connector-aws-kinesis-data-streams/src/main/java/org/apache/flink/connector/kinesis/sink/KinesisDataStreamsException

[GitHub] [flink] CrynetLogistics commented on a change in pull request #18553: [FLINK-25846][FLINK-25848] Async Sink does not gracefully shutdown on Cancel, KDS Sink does not fast fail when invalid co

2022-01-31 Thread GitBox
CrynetLogistics commented on a change in pull request #18553: URL: https://github.com/apache/flink/pull/18553#discussion_r795522964 ## File path: flink-connectors/flink-connector-aws-kinesis-data-streams/src/main/java/org/apache/flink/connector/kinesis/sink/KinesisDataStreamsException