[GitHub] [flink] CrynetLogistics commented on pull request #17345: [FLINK-24227][connectors] FLIP-171: Added Kinesis Data Streams Sink i…

2021-10-11 Thread GitBox
CrynetLogistics commented on pull request #17345: URL: https://github.com/apache/flink/pull/17345#issuecomment-940378397 Tests now passing. Will deal with the rest of the comments tomorrow! -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [flink] CrynetLogistics commented on pull request #17345: [FLINK-24227][connectors] FLIP-171: Added Kinesis Data Streams Sink i…

2021-10-04 Thread GitBox
CrynetLogistics commented on pull request #17345: URL: https://github.com/apache/flink/pull/17345#issuecomment-933406220 Comment From Nuno `KinesisDataStreamsSinkConfig` Should we change the variable `DEFAULT_MAX_TimeInBufferMS` to `DEFAULT_MAX_TIME_IN_BUFFER_MS`? `KinesisDataStrea

[GitHub] [flink] CrynetLogistics commented on pull request #17345: [FLINK-24227][connectors] FLIP-171: Added Kinesis Data Streams Sink i…

2021-09-23 Thread GitBox
CrynetLogistics commented on pull request #17345: URL: https://github.com/apache/flink/pull/17345#issuecomment-926092248 For the reviewer, please note, **reflection** is used in `KinesisDataStreamsSinkITCase` to access a `private static final` client in `KinesisDataStreamsSinkWriter`. The