subject:"\[GitHub\] \[flink\] Cyberness commented on pull request #20257\: \[FLINK\-24943\]\[Connectors \/ Kinesis\] Explicitly create KryoSerializer for SequenceNumber class in Kinesis Consumer"

[GitHub] [flink] Cyberness commented on pull request #20257: [FLINK-24943][Connectors / Kinesis] Explicitly create KryoSerializer for SequenceNumber class in Kinesis Consumer

2023-01-11 Thread GitBox

Cyberness commented on PR #20257: URL: https://github.com/apache/flink/pull/20257#issuecomment-1379570234 Does it still make sense to work on merging this change considering [FLINK-30557](https://github.com/apache/flink/pull/21600)? -- This is an automated message from the Apache Git

[GitHub] [flink] Cyberness commented on pull request #20257: [FLINK-24943][Connectors / Kinesis] Explicitly create KryoSerializer for SequenceNumber class in Kinesis Consumer

2022-10-11 Thread GitBox

Cyberness commented on PR #20257: URL: https://github.com/apache/flink/pull/20257#issuecomment-1275379856 > The code changes look good. Recognise that we specify a KryoSerializer instead of making the SequenceNumber a POJO to maintain backwards compatibility. Given that we are changing the