[GitHub] [flink] JingsongLi commented on a change in pull request #17542: [FLINK-17782] Add array,map,row types support for parquet row writer

2021-12-02 Thread GitBox
JingsongLi commented on a change in pull request #17542: URL: https://github.com/apache/flink/pull/17542#discussion_r761700468 ## File path: flink-formats/flink-parquet/src/test/java/org/apache/flink/formats/parquet/row/ParquetRowDataWriterTest.java ## @@ -158,6 +190,65 @@

[GitHub] [flink] JingsongLi commented on a change in pull request #17542: [FLINK-17782] Add array,map,row types support for parquet row writer

2021-12-02 Thread GitBox
JingsongLi commented on a change in pull request #17542: URL: https://github.com/apache/flink/pull/17542#discussion_r761699867 ## File path: flink-formats/flink-parquet/src/test/java/org/apache/flink/formats/parquet/row/ParquetRowDataWriterTest.java ## @@ -158,6 +190,65 @@

[GitHub] [flink] JingsongLi commented on a change in pull request #17542: [FLINK-17782] Add array,map,row types support for parquet row writer

2021-12-02 Thread GitBox
JingsongLi commented on a change in pull request #17542: URL: https://github.com/apache/flink/pull/17542#discussion_r761651214 ## File path: flink-formats/flink-parquet/src/main/java/org/apache/flink/formats/parquet/row/ParquetRowDataWriter.java ## @@ -224,6 +277,153 @@

[GitHub] [flink] JingsongLi commented on a change in pull request #17542: [FLINK-17782] Add array,map,row types support for parquet row writer

2021-12-02 Thread GitBox
JingsongLi commented on a change in pull request #17542: URL: https://github.com/apache/flink/pull/17542#discussion_r761612653 ## File path: flink-formats/flink-parquet/src/main/java/org/apache/flink/formats/parquet/row/ParquetRowDataWriter.java ## @@ -165,6 +187,11 @@ public

[GitHub] [flink] JingsongLi commented on a change in pull request #17542: [FLINK-17782] Add array,map,row types support for parquet row writer

2021-12-01 Thread GitBox
JingsongLi commented on a change in pull request #17542: URL: https://github.com/apache/flink/pull/17542#discussion_r760729158 ## File path: flink-formats/flink-parquet/src/test/java/org/apache/flink/formats/parquet/row/ParquetRowDataWriterTest.java ## @@ -120,15 +144,18 @@

[GitHub] [flink] JingsongLi commented on a change in pull request #17542: [FLINK-17782] Add array,map,row types support for parquet row writer

2021-12-01 Thread GitBox
JingsongLi commented on a change in pull request #17542: URL: https://github.com/apache/flink/pull/17542#discussion_r760727608 ## File path: flink-formats/flink-parquet/src/main/java/org/apache/flink/formats/parquet/row/ParquetRowDataWriter.java ## @@ -224,6 +293,176 @@

[GitHub] [flink] JingsongLi commented on a change in pull request #17542: [FLINK-17782] Add array,map,row types support for parquet row writer

2021-12-01 Thread GitBox
JingsongLi commented on a change in pull request #17542: URL: https://github.com/apache/flink/pull/17542#discussion_r760727340 ## File path: flink-formats/flink-parquet/src/main/java/org/apache/flink/formats/parquet/row/ParquetRowDataWriter.java ## @@ -224,6 +293,176 @@

[GitHub] [flink] JingsongLi commented on a change in pull request #17542: [FLINK-17782] Add array,map,row types support for parquet row writer

2021-12-01 Thread GitBox
JingsongLi commented on a change in pull request #17542: URL: https://github.com/apache/flink/pull/17542#discussion_r760725974 ## File path: flink-formats/flink-parquet/src/main/java/org/apache/flink/formats/parquet/row/ParquetRowDataWriter.java ## @@ -224,6 +293,176 @@

[GitHub] [flink] JingsongLi commented on a change in pull request #17542: [FLINK-17782] Add array,map,row types support for parquet row writer

2021-12-01 Thread GitBox
JingsongLi commented on a change in pull request #17542: URL: https://github.com/apache/flink/pull/17542#discussion_r760725040 ## File path: flink-formats/flink-parquet/src/main/java/org/apache/flink/formats/parquet/utils/ParquetSchemaConverter.java ## @@ -101,11 +110,32 @@

[GitHub] [flink] JingsongLi commented on a change in pull request #17542: [FLINK-17782] Add array,map,row types support for parquet row writer

2021-12-01 Thread GitBox
JingsongLi commented on a change in pull request #17542: URL: https://github.com/apache/flink/pull/17542#discussion_r760724189 ## File path: flink-formats/flink-parquet/src/main/java/org/apache/flink/formats/parquet/row/ParquetRowDataWriter.java ## @@ -224,6 +293,176 @@

[GitHub] [flink] JingsongLi commented on a change in pull request #17542: [FLINK-17782] Add array,map,row types support for parquet row writer

2021-12-01 Thread GitBox
JingsongLi commented on a change in pull request #17542: URL: https://github.com/apache/flink/pull/17542#discussion_r760714379 ## File path: flink-formats/flink-parquet/src/main/java/org/apache/flink/formats/parquet/row/ParquetRowDataWriter.java ## @@ -189,6 +243,11 @@ public

[GitHub] [flink] JingsongLi commented on a change in pull request #17542: [FLINK-17782] Add array,map,row types support for parquet row writer

2021-12-01 Thread GitBox
JingsongLi commented on a change in pull request #17542: URL: https://github.com/apache/flink/pull/17542#discussion_r760713947 ## File path: flink-formats/flink-parquet/src/main/java/org/apache/flink/formats/parquet/row/ParquetRowDataWriter.java ## @@ -126,13 +134,29 @@