subject:"\[GitHub\] \[flink\] JingsongLi commented on a diff in pull request #20119\: \[FLINK\-28322\]\[table\-api\] DataStreamScan\(Sink\)Provider's new method is not compatible"

[GitHub] [flink] JingsongLi commented on a diff in pull request #20119: [FLINK-28322][table-api] DataStreamScan(Sink)Provider's new method is not compatible

2022-07-05 Thread GitBox

JingsongLi commented on code in PR #20119: URL: https://github.com/apache/flink/pull/20119#discussion_r914348586 ## flink-table/flink-table-api-java-bridge/src/main/java/org/apache/flink/table/connector/source/DataStreamScanProvider.java: ## @@ -48,8 +48,10 @@ public interface D

[GitHub] [flink] JingsongLi commented on a diff in pull request #20119: [FLINK-28322][table-api] DataStreamScan(Sink)Provider's new method is not compatible

2022-07-03 Thread GitBox

JingsongLi commented on code in PR #20119: URL: https://github.com/apache/flink/pull/20119#discussion_r912568525 ## flink-table/flink-table-api-java-bridge/src/main/java/org/apache/flink/table/connector/sink/DataStreamSinkProvider.java: ## @@ -54,8 +54,10 @@ * * @see