[GitHub] [flink] MartijnVisser commented on a diff in pull request #19571: [FLINK-27394] Integrate the Flink Elasticsearch documentation in the Flink documentation

2022-05-02 Thread GitBox
MartijnVisser commented on code in PR #19571: URL: https://github.com/apache/flink/pull/19571#discussion_r862834393 ## docs/setup_docs.sh: ## @@ -0,0 +1,43 @@ +#!/usr/bin/env bash + +# Licensed to t

[GitHub] [flink] MartijnVisser commented on a diff in pull request #19571: [FLINK-27394] Integrate the Flink Elasticsearch documentation in the Flink documentation

2022-05-02 Thread GitBox
MartijnVisser commented on code in PR #19571: URL: https://github.com/apache/flink/pull/19571#discussion_r862768062 ## docs/setup_docs.sh: ## @@ -0,0 +1,50 @@ +#!/usr/bin/env bash + +# Licensed to t

[GitHub] [flink] MartijnVisser commented on a diff in pull request #19571: [FLINK-27394] Integrate the Flink Elasticsearch documentation in the Flink documentation

2022-05-02 Thread GitBox
MartijnVisser commented on code in PR #19571: URL: https://github.com/apache/flink/pull/19571#discussion_r862767191 ## tools/ci/docs.sh: ## @@ -28,10 +28,11 @@ fi tar -zxvf $HUGO_ARTIFACT git submodule update --init --recursive +# Setup the external documentation modules +so

[GitHub] [flink] MartijnVisser commented on a diff in pull request #19571: [FLINK-27394] Integrate the Flink Elasticsearch documentation in the Flink documentation

2022-05-02 Thread GitBox
MartijnVisser commented on code in PR #19571: URL: https://github.com/apache/flink/pull/19571#discussion_r862766972 ## docs/setup_docs.sh: ## @@ -0,0 +1,54 @@ +#!/usr/bin/env bash + +# Licensed to t

[GitHub] [flink] MartijnVisser commented on a diff in pull request #19571: [FLINK-27394] Integrate the Flink Elasticsearch documentation in the Flink documentation

2022-04-26 Thread GitBox
MartijnVisser commented on code in PR #19571: URL: https://github.com/apache/flink/pull/19571#discussion_r858835514 ## docs/build_docs.sh: ## @@ -24,5 +24,6 @@ then exit 1 fi git submodule update --init --recursive - +source ./setup_docs.sh Review Comment: No, I ju

[GitHub] [flink] MartijnVisser commented on a diff in pull request #19571: [FLINK-27394] Integrate the Flink Elasticsearch documentation in the Flink documentation

2022-04-26 Thread GitBox
MartijnVisser commented on code in PR #19571: URL: https://github.com/apache/flink/pull/19571#discussion_r858566738 ## docs/go.mod: ## @@ -0,0 +1,8 @@ +module github.com/apache/flink + +go 1.18 + +require ( + github.com/apache/flink-connector-elasticsearch v0.0.0-20220406

[GitHub] [flink] MartijnVisser commented on a diff in pull request #19571: [FLINK-27394] Integrate the Flink Elasticsearch documentation in the Flink documentation

2022-04-26 Thread GitBox
MartijnVisser commented on code in PR #19571: URL: https://github.com/apache/flink/pull/19571#discussion_r858419194 ## .github/workflows/docs.sh: ## @@ -31,6 +31,13 @@ if ! curl --fail -OL $HUGO_REPO ; then fi tar -zxvf $HUGO_ARTIFACT git submodule update --init --recursive +

[GitHub] [flink] MartijnVisser commented on a diff in pull request #19571: [FLINK-27394] Integrate the Flink Elasticsearch documentation in the Flink documentation

2022-04-25 Thread GitBox
MartijnVisser commented on code in PR #19571: URL: https://github.com/apache/flink/pull/19571#discussion_r857873472 ## docs/README.md: ## @@ -32,6 +32,79 @@ $ ./build_docs.sh The site can be viewed at http://localhost:1313/ +## Include externally hosted documentation + +Wit

[GitHub] [flink] MartijnVisser commented on a diff in pull request #19571: [FLINK-27394] Integrate the Flink Elasticsearch documentation in the Flink documentation

2022-04-25 Thread GitBox
MartijnVisser commented on code in PR #19571: URL: https://github.com/apache/flink/pull/19571#discussion_r857871231 ## docs/README.md: ## @@ -32,6 +32,79 @@ $ ./build_docs.sh The site can be viewed at http://localhost:1313/ +## Include externally hosted documentation + +Wit

[GitHub] [flink] MartijnVisser commented on a diff in pull request #19571: [FLINK-27394] Integrate the Flink Elasticsearch documentation in the Flink documentation

2022-04-25 Thread GitBox
MartijnVisser commented on code in PR #19571: URL: https://github.com/apache/flink/pull/19571#discussion_r857867821 ## docs/go.mod: ## @@ -0,0 +1,8 @@ +module github.com/apache/flink + +go 1.18 + +require ( + github.com/apache/flink-connector-elasticsearch v0.0.0-20220406

[GitHub] [flink] MartijnVisser commented on a diff in pull request #19571: [FLINK-27394] Integrate the Flink Elasticsearch documentation in the Flink documentation

2022-04-25 Thread GitBox
MartijnVisser commented on code in PR #19571: URL: https://github.com/apache/flink/pull/19571#discussion_r857867821 ## docs/go.mod: ## @@ -0,0 +1,8 @@ +module github.com/apache/flink + +go 1.18 + +require ( + github.com/apache/flink-connector-elasticsearch v0.0.0-20220406

[GitHub] [flink] MartijnVisser commented on a diff in pull request #19571: [FLINK-27394] Integrate the Flink Elasticsearch documentation in the Flink documentation

2022-04-25 Thread GitBox
MartijnVisser commented on code in PR #19571: URL: https://github.com/apache/flink/pull/19571#discussion_r857860887 ## docs/README.md: ## @@ -32,6 +32,79 @@ $ ./build_docs.sh The site can be viewed at http://localhost:1313/ +## Include externally hosted documentation + +Wit

[GitHub] [flink] MartijnVisser commented on a diff in pull request #19571: [FLINK-27394] Integrate the Flink Elasticsearch documentation in the Flink documentation

2022-04-25 Thread GitBox
MartijnVisser commented on code in PR #19571: URL: https://github.com/apache/flink/pull/19571#discussion_r857686481 ## .github/workflows/docs.sh: ## @@ -31,6 +31,13 @@ if ! curl --fail -OL $HUGO_REPO ; then fi tar -zxvf $HUGO_ARTIFACT git submodule update --init --recursive +

[GitHub] [flink] MartijnVisser commented on a diff in pull request #19571: [FLINK-27394] Integrate the Flink Elasticsearch documentation in the Flink documentation

2022-04-25 Thread GitBox
MartijnVisser commented on code in PR #19571: URL: https://github.com/apache/flink/pull/19571#discussion_r857641210 ## docs/README.md: ## @@ -32,6 +32,79 @@ $ ./build_docs.sh The site can be viewed at http://localhost:1313/ +## Include externally hosted documentation + +Wit

[GitHub] [flink] MartijnVisser commented on a diff in pull request #19571: [FLINK-27394] Integrate the Flink Elasticsearch documentation in the Flink documentation

2022-04-25 Thread GitBox
MartijnVisser commented on code in PR #19571: URL: https://github.com/apache/flink/pull/19571#discussion_r857625021 ## docs/README.md: ## @@ -32,6 +32,79 @@ $ ./build_docs.sh The site can be viewed at http://localhost:1313/ +## Include externally hosted documentation + +Wit

[GitHub] [flink] MartijnVisser commented on a diff in pull request #19571: [FLINK-27394] Integrate the Flink Elasticsearch documentation in the Flink documentation

2022-04-25 Thread GitBox
MartijnVisser commented on code in PR #19571: URL: https://github.com/apache/flink/pull/19571#discussion_r857623653 ## docs/go.mod: ## @@ -0,0 +1,8 @@ +module github.com/apache/flink + +go 1.18 + +require ( + github.com/apache/flink-connector-elasticsearch v0.0.0-20220406