[GitHub] [flink] Myasuka commented on pull request #16371: [FLINK-23198][Documentation] Fix the demo of ConfigurableRocksDBOptionsFactory in Documentation.

2021-08-16 Thread GitBox
Myasuka commented on pull request #16371: URL: https://github.com/apache/flink/pull/16371#issuecomment-899955417 @yanchenyun as I said before, you should use **force push** to update. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [flink] Myasuka commented on pull request #16371: [FLINK-23198][Documentation] Fix the demo of ConfigurableRocksDBOptionsFactory in Documentation.

2021-08-16 Thread GitBox
Myasuka commented on pull request #16371: URL: https://github.com/apache/flink/pull/16371#issuecomment-899486015 @yanchenyun Unfortunately not correct. You could use `git rebase` to rebase your local master branch with current apache/flink master branch. And use `git rebase -i xxx` to

[GitHub] [flink] Myasuka commented on pull request #16371: [FLINK-23198][Documentation] Fix the demo of ConfigurableRocksDBOptionsFactory in Documentation.

2021-08-15 Thread GitBox
Myasuka commented on pull request #16371: URL: https://github.com/apache/flink/pull/16371#issuecomment-899180969 @yanchenyun Thanks for your update! However, this PR has conflicts with master branch, would you please rebase to latest flink master branch? BTW, you could also squash

[GitHub] [flink] Myasuka commented on pull request #16371: [FLINK-23198][Documentation] Fix the demo of ConfigurableRocksDBOptionsFactory in Documentation.

2021-08-05 Thread GitBox
Myasuka commented on pull request #16371: URL: https://github.com/apache/flink/pull/16371#issuecomment-894015343 @yanchenyun could you update this PR with the comments? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use