[GitHub] [flink] PatrickRen commented on a diff in pull request #20205: [FLINK-28250][Connector/Kafka] Fix exactly-once Kafka Sink out of memory

2022-07-11 Thread GitBox
PatrickRen commented on code in PR #20205: URL: https://github.com/apache/flink/pull/20205#discussion_r917610468 ## flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/sink/KafkaCommitterTest.java: ## @@ -85,6 +87,26 @@ public void testFailJobOn

[GitHub] [flink] PatrickRen commented on a diff in pull request #20205: [FLINK-28250][Connector/Kafka] Fix exactly-once Kafka Sink out of memory

2022-07-07 Thread GitBox
PatrickRen commented on code in PR #20205: URL: https://github.com/apache/flink/pull/20205#discussion_r916412313 ## flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/KafkaCommitter.java: ## @@ -112,6 +112,8 @@ public void commit(Collecti