[GitHub] [flink] PatrickRen commented on pull request #16115: [FLINK-22766][connector/kafka] Report offsets and Kafka consumer metrics in Flink metric group

2021-06-29 Thread GitBox
PatrickRen commented on pull request #16115: URL: https://github.com/apache/flink/pull/16115#issuecomment-870277421 Thanks @becketqin for reviewing~ I split the patch into two commits: 2b460b5 for adding test util class `MetricListener` 43036001425b for offset and KafkaConsumer metrics

[GitHub] [flink] PatrickRen commented on pull request #16115: [FLINK-22766][connector/kafka] Report offsets and Kafka consumer metrics in Flink metric group

2021-06-28 Thread GitBox
PatrickRen commented on pull request #16115: URL: https://github.com/apache/flink/pull/16115#issuecomment-870277421 Thanks @becketqin for reviewing~ I split the patch into two commits: 2b460b5 for adding test util class `MetricListener` 43036001425b for offset and KafkaConsumer metrics

[GitHub] [flink] PatrickRen commented on pull request #16115: [FLINK-22766][connector/kafka] Report offsets and Kafka consumer metrics in Flink metric group

2021-06-14 Thread GitBox
PatrickRen commented on pull request #16115: URL: https://github.com/apache/flink/pull/16115#issuecomment-859303486 Hi @becketqin, could you have a review on this PR? Thank~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and