[GitHub] [flink] RocMarshal commented on pull request #21999: [FLINK-29816][streaming] Fix the bug that StreamTask doesn't handle exception during restoring

2023-02-27 Thread via GitHub
RocMarshal commented on PR #21999: URL: https://github.com/apache/flink/pull/21999#issuecomment-1446413820 Hi, @reswqa I drive the BP patches in https://github.com/apache/flink/pull/22035 & https://github.com/apache/flink/pull/22036 PTAL if you're in free time. Thank you~. CC @akalash

[GitHub] [flink] RocMarshal commented on pull request #21999: [FLINK-29816][streaming] Fix the bug that StreamTask doesn't handle exception during restoring

2023-02-26 Thread via GitHub
RocMarshal commented on PR #21999: URL: https://github.com/apache/flink/pull/21999#issuecomment-1445562489 > @RocMarshal Would you mind creating the `backport` pull request of `release-1.17` and `release-1.16` after all reviewers approved. @reswqa Yes. I'm glad to ~ -- This is an

[GitHub] [flink] RocMarshal commented on pull request #21999: [FLINK-29816][streaming] Fix the bug that StreamTask doesn't handle exception during restoring

2023-02-25 Thread via GitHub
RocMarshal commented on PR #21999: URL: https://github.com/apache/flink/pull/21999#issuecomment-1445265696 Hi, @1996fanrui @reswqa thanks for the comments & help. I make change based on your suggestion. PTAL if you're in free time. CC @akalash -- This is an automated message from

[GitHub] [flink] RocMarshal commented on pull request #21999: [FLINK-29816][streaming] Fix the bug that StreamTask doesn't handle exception during restoring

2023-02-23 Thread via GitHub
RocMarshal commented on PR #21999: URL: https://github.com/apache/flink/pull/21999#issuecomment-1441965644 > What do you mean by `hotfix-ticket`? For the current case, we do not need another jira ticket or another PR. In my opinion, this PR will eventually have two commits in the following

[GitHub] [flink] RocMarshal commented on pull request #21999: [FLINK-29816][streaming] Fix the bug that StreamTask doesn't handle exception during restoring

2023-02-23 Thread via GitHub
RocMarshal commented on PR #21999: URL: https://github.com/apache/flink/pull/21999#issuecomment-1441946575 > Thanks @RocMarshal. If you like, you'd better migrate all the tests in `StreamTaskTest` to `Junit5` and `AssertJ` in a hotfix commit. No matter what, the newly introduced test should