[GitHub] [flink] RyanSkraba commented on pull request #20805: [FLINK-29198][test] Fail after maximum RetryOnException

2022-11-03 Thread GitBox
RyanSkraba commented on PR #20805: URL: https://github.com/apache/flink/pull/20805#issuecomment-1301800271 Rebased and changed the commit messages to the suggested text. Thanks for your attention! In fact, for testing correctness, I would suggest that all three commits be cherry-pic

[GitHub] [flink] RyanSkraba commented on pull request #20805: [FLINK-29198][test] Fail after maximum RetryOnException

2022-10-21 Thread GitBox
RyanSkraba commented on PR #20805: URL: https://github.com/apache/flink/pull/20805#issuecomment-1287136423 Rebased again and moved some modifications to their own separate commit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [flink] RyanSkraba commented on pull request #20805: [FLINK-29198][test] Fail after maximum RetryOnException

2022-10-20 Thread GitBox
RyanSkraba commented on PR #20805: URL: https://github.com/apache/flink/pull/20805#issuecomment-1285085672 Rebased again and edited the commit messages! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [flink] RyanSkraba commented on pull request #20805: [FLINK-29198][test] Fail after maximum RetryOnException

2022-10-17 Thread GitBox
RyanSkraba commented on PR #20805: URL: https://github.com/apache/flink/pull/20805#issuecomment-1280916628 Sorry for the delay! I've merge/squashed all of the commits (with @snuyanzin now as co-author, thanks!). The only changes were 1 javadoc clarification and the small requested simplif

[GitHub] [flink] RyanSkraba commented on pull request #20805: [FLINK-29198][test] Fail after maximum RetryOnException

2022-09-21 Thread GitBox
RyanSkraba commented on PR #20805: URL: https://github.com/apache/flink/pull/20805#issuecomment-1254602564 > Thanks for the contribution. I think it would be great to have a test here confirming that the change fixes the issue Thanks Sergey, especially for the collaboration! This was