[GitHub] [flink] Shawn-Hx commented on pull request #14235: [FLINK-20298][docs] Replace usage of {{ site.baseurl }} in documentation

2020-12-01 Thread GitBox
Shawn-Hx commented on pull request #14235: URL: https://github.com/apache/flink/pull/14235#issuecomment-736642560 @dawidwys I noticed that the problem has been fixed and resolved the conflicts. Now `./build_docs.sh` and `./check_links.sh` can be executed without error, PTAL :)

[GitHub] [flink] Shawn-Hx commented on pull request #14235: [FLINK-20298][docs] Replace usage of {{ site.baseurl }} in documentation

2020-12-01 Thread GitBox
Shawn-Hx commented on pull request #14235: URL: https://github.com/apache/flink/pull/14235#issuecomment-736511325 @dawidwys I have resolved the conflicts, but I fount that `deployment/resource-providers/hadoop.md` don't exist so `build_docs.sh` will fail.

[GitHub] [flink] Shawn-Hx commented on pull request #14235: [FLINK-20298][docs] Replace usage of {{ site.baseurl }} in documentation

2020-11-30 Thread GitBox
Shawn-Hx commented on pull request #14235: URL: https://github.com/apache/flink/pull/14235#issuecomment-735708730 Thanks @dawidwys I have created [FLINK-20422](https://issues.apache.org/jira/browse/FLINK-20422). Please take a look.

[GitHub] [flink] Shawn-Hx commented on pull request #14235: [FLINK-20298][docs] Replace usage of {{ site.baseurl }} in documentation

2020-11-27 Thread GitBox
Shawn-Hx commented on pull request #14235: URL: https://github.com/apache/flink/pull/14235#issuecomment-734892872 Thanks for the review @dawidwys I need some time to be familiar with the grammar of Jekyll. I wonder if I could open another JIRA ticket to solve the remaining problems

[GitHub] [flink] Shawn-Hx commented on pull request #14235: [FLINK-20298][docs] Replace usage of {{ site.baseurl }} in documentation

2020-11-26 Thread GitBox
Shawn-Hx commented on pull request #14235: URL: https://github.com/apache/flink/pull/14235#issuecomment-734301881 Hi, @dawidwys @sjwiesman Could you help to review at your convenience ? Thanks~ This is an automated