[GitHub] [flink] SmirAlex commented on a diff in pull request #20919: [FLINK-29405] Fix unstable test InputFormatCacheLoaderTest

2023-01-27 Thread via GitHub
SmirAlex commented on code in PR #20919: URL: https://github.com/apache/flink/pull/20919#discussion_r1089061628 ## flink-table/flink-table-runtime/src/test/java/org/apache/flink/table/runtime/functions/table/fullcache/inputformat/InputFormatCacheLoaderTest.java: ## @@ -178,12 +1

[GitHub] [flink] SmirAlex commented on a diff in pull request #20919: [FLINK-29405] Fix unstable test InputFormatCacheLoaderTest

2023-01-27 Thread via GitHub
SmirAlex commented on code in PR #20919: URL: https://github.com/apache/flink/pull/20919#discussion_r1089061320 ## flink-table/flink-table-runtime/src/test/java/org/apache/flink/table/runtime/functions/table/fullcache/inputformat/FullCacheTestInputFormat.java: ## @@ -41,18 +41,2

[GitHub] [flink] SmirAlex commented on a diff in pull request #20919: [FLINK-29405] Fix unstable test InputFormatCacheLoaderTest

2023-01-27 Thread via GitHub
SmirAlex commented on code in PR #20919: URL: https://github.com/apache/flink/pull/20919#discussion_r1089060751 ## flink-table/flink-table-runtime/src/test/java/org/apache/flink/table/runtime/functions/table/fullcache/inputformat/FullCacheTestInputFormat.java: ## @@ -41,18 +41,2

[GitHub] [flink] SmirAlex commented on a diff in pull request #20919: [FLINK-29405] Fix unstable test InputFormatCacheLoaderTest

2023-01-27 Thread via GitHub
SmirAlex commented on code in PR #20919: URL: https://github.com/apache/flink/pull/20919#discussion_r1089060316 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/table/lookup/fullcache/ReloadTriggerContext.java: ## @@ -26,11 +26,11 @@ /**

[GitHub] [flink] SmirAlex commented on a diff in pull request #20919: [FLINK-29405] Fix unstable test InputFormatCacheLoaderTest

2023-01-24 Thread via GitHub
SmirAlex commented on code in PR #20919: URL: https://github.com/apache/flink/pull/20919#discussion_r1085082904 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/table/lookup/CachingLookupFunction.java: ## @@ -107,12 +107,12 @@ public void

[GitHub] [flink] SmirAlex commented on a diff in pull request #20919: [FLINK-29405] Fix unstable test InputFormatCacheLoaderTest

2023-01-23 Thread via GitHub
SmirAlex commented on code in PR #20919: URL: https://github.com/apache/flink/pull/20919#discussion_r1084842995 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/table/lookup/fullcache/LookupFullCache.java: ## @@ -109,7 +116,9 @@ public lo

[GitHub] [flink] SmirAlex commented on a diff in pull request #20919: [FLINK-29405] Fix unstable test InputFormatCacheLoaderTest

2023-01-23 Thread via GitHub
SmirAlex commented on code in PR #20919: URL: https://github.com/apache/flink/pull/20919#discussion_r1084842890 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/table/lookup/CachingLookupFunction.java: ## @@ -107,12 +107,12 @@ public void

[GitHub] [flink] SmirAlex commented on a diff in pull request #20919: [FLINK-29405] Fix unstable test InputFormatCacheLoaderTest

2023-01-23 Thread via GitHub
SmirAlex commented on code in PR #20919: URL: https://github.com/apache/flink/pull/20919#discussion_r1084842647 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/table/lookup/CachingLookupFunction.java: ## @@ -107,12 +107,12 @@ public void

[GitHub] [flink] SmirAlex commented on a diff in pull request #20919: [FLINK-29405] Fix unstable test InputFormatCacheLoaderTest

2023-01-23 Thread via GitHub
SmirAlex commented on code in PR #20919: URL: https://github.com/apache/flink/pull/20919#discussion_r1084842440 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/table/lookup/fullcache/inputformat/InputFormatCacheLoader.java: ## @@ -71,56

[GitHub] [flink] SmirAlex commented on a diff in pull request #20919: [FLINK-29405] Fix unstable test InputFormatCacheLoaderTest

2023-01-11 Thread GitBox
SmirAlex commented on code in PR #20919: URL: https://github.com/apache/flink/pull/20919#discussion_r1066988928 ## flink-table/flink-table-runtime/src/test/java/org/apache/flink/table/runtime/functions/table/fullcache/inputformat/InputFormatCacheLoaderTest.java: ## @@ -77,43 +77

[GitHub] [flink] SmirAlex commented on a diff in pull request #20919: [FLINK-29405] Fix unstable test InputFormatCacheLoaderTest

2023-01-11 Thread GitBox
SmirAlex commented on code in PR #20919: URL: https://github.com/apache/flink/pull/20919#discussion_r1066989149 ## flink-table/flink-table-runtime/src/test/java/org/apache/flink/table/runtime/functions/table/fullcache/inputformat/InputFormatCacheLoaderTest.java: ## @@ -123,46 +1

[GitHub] [flink] SmirAlex commented on a diff in pull request #20919: [FLINK-29405] Fix unstable test InputFormatCacheLoaderTest

2023-01-11 Thread GitBox
SmirAlex commented on code in PR #20919: URL: https://github.com/apache/flink/pull/20919#discussion_r1066988436 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/table/lookup/fullcache/LookupFullCache.java: ## @@ -57,7 +57,7 @@ public sync

[GitHub] [flink] SmirAlex commented on a diff in pull request #20919: [FLINK-29405] Fix unstable test InputFormatCacheLoaderTest

2023-01-11 Thread GitBox
SmirAlex commented on code in PR #20919: URL: https://github.com/apache/flink/pull/20919#discussion_r1066988174 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/table/lookup/fullcache/inputformat/InputFormatCacheLoader.java: ## @@ -71,58

[GitHub] [flink] SmirAlex commented on a diff in pull request #20919: [FLINK-29405] Fix unstable test InputFormatCacheLoaderTest

2022-12-09 Thread GitBox
SmirAlex commented on code in PR #20919: URL: https://github.com/apache/flink/pull/20919#discussion_r1044681283 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/table/lookup/fullcache/CacheLoader.java: ## @@ -59,11 +65,11 @@ public abstra

[GitHub] [flink] SmirAlex commented on a diff in pull request #20919: [FLINK-29405] Fix unstable test InputFormatCacheLoaderTest

2022-12-06 Thread GitBox
SmirAlex commented on code in PR #20919: URL: https://github.com/apache/flink/pull/20919#discussion_r1041843449 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/table/lookup/fullcache/inputformat/InputFormatCacheLoader.java: ## @@ -107,7

[GitHub] [flink] SmirAlex commented on a diff in pull request #20919: [FLINK-29405] Fix unstable test InputFormatCacheLoaderTest

2022-12-06 Thread GitBox
SmirAlex commented on code in PR #20919: URL: https://github.com/apache/flink/pull/20919#discussion_r1041842260 ## flink-table/flink-table-runtime/src/test/java/org/apache/flink/table/runtime/functions/table/fullcache/inputformat/InputFormatCacheLoaderTest.java: ## @@ -149,19 +1

[GitHub] [flink] SmirAlex commented on a diff in pull request #20919: [FLINK-29405] Fix unstable test InputFormatCacheLoaderTest

2022-12-06 Thread GitBox
SmirAlex commented on code in PR #20919: URL: https://github.com/apache/flink/pull/20919#discussion_r1041840764 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/table/lookup/fullcache/inputformat/InputFormatCacheLoader.java: ## @@ -107,7

[GitHub] [flink] SmirAlex commented on a diff in pull request #20919: [FLINK-29405] Fix unstable test InputFormatCacheLoaderTest

2022-12-06 Thread GitBox
SmirAlex commented on code in PR #20919: URL: https://github.com/apache/flink/pull/20919#discussion_r1041838205 ## flink-table/flink-table-runtime/src/test/java/org/apache/flink/table/runtime/functions/table/fullcache/inputformat/InputFormatCacheLoaderTest.java: ## @@ -131,15 +1

[GitHub] [flink] SmirAlex commented on a diff in pull request #20919: [FLINK-29405] Fix unstable test InputFormatCacheLoaderTest

2022-12-06 Thread GitBox
SmirAlex commented on code in PR #20919: URL: https://github.com/apache/flink/pull/20919#discussion_r1041837426 ## flink-table/flink-table-runtime/src/test/java/org/apache/flink/table/runtime/functions/table/fullcache/inputformat/InputFormatCacheLoaderTest.java: ## @@ -149,19 +1

[GitHub] [flink] SmirAlex commented on a diff in pull request #20919: [FLINK-29405] Fix unstable test InputFormatCacheLoaderTest

2022-11-30 Thread GitBox
SmirAlex commented on code in PR #20919: URL: https://github.com/apache/flink/pull/20919#discussion_r1036684740 ## flink-table/flink-table-runtime/src/test/java/org/apache/flink/table/runtime/functions/table/fullcache/inputformat/InputFormatCacheLoaderTest.java: ## @@ -149,19 +1

[GitHub] [flink] SmirAlex commented on a diff in pull request #20919: [FLINK-29405] Fix unstable test InputFormatCacheLoaderTest

2022-11-30 Thread GitBox
SmirAlex commented on code in PR #20919: URL: https://github.com/apache/flink/pull/20919#discussion_r1036683826 ## flink-table/flink-table-runtime/src/test/java/org/apache/flink/table/runtime/functions/table/fullcache/inputformat/InputFormatCacheLoaderTest.java: ## @@ -149,19 +1

[GitHub] [flink] SmirAlex commented on a diff in pull request #20919: [FLINK-29405] Fix unstable test InputFormatCacheLoaderTest

2022-11-27 Thread GitBox
SmirAlex commented on code in PR #20919: URL: https://github.com/apache/flink/pull/20919#discussion_r1033131501 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/table/lookup/fullcache/inputformat/InputFormatCacheLoader.java: ## @@ -107,7

[GitHub] [flink] SmirAlex commented on a diff in pull request #20919: [FLINK-29405] Fix unstable test InputFormatCacheLoaderTest

2022-11-27 Thread GitBox
SmirAlex commented on code in PR #20919: URL: https://github.com/apache/flink/pull/20919#discussion_r1033131501 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/table/lookup/fullcache/inputformat/InputFormatCacheLoader.java: ## @@ -107,7

[GitHub] [flink] SmirAlex commented on a diff in pull request #20919: [FLINK-29405] Fix unstable test InputFormatCacheLoaderTest

2022-11-27 Thread GitBox
SmirAlex commented on code in PR #20919: URL: https://github.com/apache/flink/pull/20919#discussion_r1033120828 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/table/lookup/fullcache/inputformat/InputFormatCacheLoader.java: ## @@ -39,12