[GitHub] [flink] SteNicholas commented on a change in pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract

2020-12-02 Thread GitBox
SteNicholas commented on a change in pull request #14028: URL: https://github.com/apache/flink/pull/14028#discussion_r534270664 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/client/JobExecutionException.java ## @@ -19,41 +19,67 @@ package

[GitHub] [flink] SteNicholas commented on a change in pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract

2020-12-01 Thread GitBox
SteNicholas commented on a change in pull request #14028: URL: https://github.com/apache/flink/pull/14028#discussion_r533853218 ## File path: flink-clients/src/main/java/org/apache/flink/client/deployment/ClusterClientJobClientAdapter.java ## @@ -116,8 +115,7 @@ public JobID

[GitHub] [flink] SteNicholas commented on a change in pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract

2020-12-01 Thread GitBox
SteNicholas commented on a change in pull request #14028: URL: https://github.com/apache/flink/pull/14028#discussion_r533853218 ## File path: flink-clients/src/main/java/org/apache/flink/client/deployment/ClusterClientJobClientAdapter.java ## @@ -116,8 +115,7 @@ public JobID

[GitHub] [flink] SteNicholas commented on a change in pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract

2020-12-01 Thread GitBox
SteNicholas commented on a change in pull request #14028: URL: https://github.com/apache/flink/pull/14028#discussion_r533851974 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/client/JobExecutionException.java ## @@ -19,41 +19,67 @@ package

[GitHub] [flink] SteNicholas commented on a change in pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract

2020-12-01 Thread GitBox
SteNicholas commented on a change in pull request #14028: URL: https://github.com/apache/flink/pull/14028#discussion_r533851974 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/client/JobExecutionException.java ## @@ -19,41 +19,67 @@ package

[GitHub] [flink] SteNicholas commented on a change in pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract

2020-12-01 Thread GitBox
SteNicholas commented on a change in pull request #14028: URL: https://github.com/apache/flink/pull/14028#discussion_r533850366 ## File path: flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaConsumerTestBase.java ## @@

[GitHub] [flink] SteNicholas commented on a change in pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract

2020-11-24 Thread GitBox
SteNicholas commented on a change in pull request #14028: URL: https://github.com/apache/flink/pull/14028#discussion_r529622200 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/client/JobExecutionException.java ## @@ -19,41 +19,67 @@ package

[GitHub] [flink] SteNicholas commented on a change in pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract

2020-11-24 Thread GitBox
SteNicholas commented on a change in pull request #14028: URL: https://github.com/apache/flink/pull/14028#discussion_r529622200 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/client/JobExecutionException.java ## @@ -19,41 +19,67 @@ package

[GitHub] [flink] SteNicholas commented on a change in pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract

2020-11-24 Thread GitBox
SteNicholas commented on a change in pull request #14028: URL: https://github.com/apache/flink/pull/14028#discussion_r529620715 ## File path: flink-clients/src/main/java/org/apache/flink/client/deployment/ClusterClientJobClientAdapter.java ## @@ -116,8 +115,7 @@ public JobID

[GitHub] [flink] SteNicholas commented on a change in pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract

2020-11-24 Thread GitBox
SteNicholas commented on a change in pull request #14028: URL: https://github.com/apache/flink/pull/14028#discussion_r529613521 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraphBuilder.java ## @@ -221,7 +222,7 @@ public static

[GitHub] [flink] SteNicholas commented on a change in pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract

2020-11-24 Thread GitBox
SteNicholas commented on a change in pull request #14028: URL: https://github.com/apache/flink/pull/14028#discussion_r529610784 ## File path: flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaConsumerTestBase.java ## @@

[GitHub] [flink] SteNicholas commented on a change in pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract

2020-11-24 Thread GitBox
SteNicholas commented on a change in pull request #14028: URL: https://github.com/apache/flink/pull/14028#discussion_r529610196 ## File path: flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaConsumerTestBase.java ## @@

[GitHub] [flink] SteNicholas commented on a change in pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract

2020-11-24 Thread GitBox
SteNicholas commented on a change in pull request #14028: URL: https://github.com/apache/flink/pull/14028#discussion_r529610196 ## File path: flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaConsumerTestBase.java ## @@

[GitHub] [flink] SteNicholas commented on a change in pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract

2020-11-17 Thread GitBox
SteNicholas commented on a change in pull request #14028: URL: https://github.com/apache/flink/pull/14028#discussion_r525647349 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java ## @@ -669,13 +669,14 @@ public JobExecutionResult

[GitHub] [flink] SteNicholas commented on a change in pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract

2020-11-17 Thread GitBox
SteNicholas commented on a change in pull request #14028: URL: https://github.com/apache/flink/pull/14028#discussion_r525646088 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobResult.java ## @@ -133,26 +132,32 @@ public JobExecutionResult