[GitHub] [flink] SteNicholas commented on pull request #16286: [FLINK-21445] Refactors the PackagedProgramRetriever implementation and adds configuration to PackagedProgram

2021-06-29 Thread GitBox
SteNicholas commented on pull request #16286: URL: https://github.com/apache/flink/pull/16286#issuecomment-870142926 LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] SteNicholas commented on pull request #16286: [FLINK-21445] Refactors the PackagedProgramRetriever implementation and adds configuration to PackagedProgram

2021-06-28 Thread GitBox
SteNicholas commented on pull request #16286: URL: https://github.com/apache/flink/pull/16286#issuecomment-870142926 LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] SteNicholas commented on pull request #16286: [FLINK-21445] Refactors the PackagedProgramRetriever implementation and adds configuration to PackagedProgram

2021-06-28 Thread GitBox
SteNicholas commented on pull request #16286: URL: https://github.com/apache/flink/pull/16286#issuecomment-869623576 @XComp , thanks for your efforts to update the pull request again me. I have reviewed the changes of the refactors. I have confusion about why not validate whether to retrev