StephanEwen commented on pull request #13574:
URL: https://github.com/apache/flink/pull/13574#issuecomment-723506656
Thanks a lot, @becketqin for taking these comments into account.
The current solution looks good to me. +1 to merge this.
StephanEwen commented on pull request #13574:
URL: https://github.com/apache/flink/pull/13574#issuecomment-715423024
We need to rethink the Maven Module setup here:
The `flink-connector-base` is not Scala-versioned (has no Scala version
suffix). Because of that it must not release an
StephanEwen commented on pull request #13574:
URL: https://github.com/apache/flink/pull/13574#issuecomment-715432448
A quick question in the closing behavior of the Kafka Enumerator.
The code here is handling the closing in a separate thread, but blocks for a
timeout. I am not sure if th
StephanEwen commented on pull request #13574:
URL: https://github.com/apache/flink/pull/13574#issuecomment-718205400
Thanks for all the thoughts and input. This is a very important discussion
and critical to get right for a good behavior in the long-term.
@becketqin We are probably
StephanEwen commented on pull request #13574:
URL: https://github.com/apache/flink/pull/13574#issuecomment-718210093
@stevenzwu You are right, this tradeoff exists. It exists in lot's of places
in Flink (and I believe other systems as well).
Either you have synchronous error reporting on
