[GitHub] [flink] Tartarus0zm commented on pull request #12146: [FLINK-17968][hbase] Fix Hadoop Configuration is not properly serialized in HBaseRowInputFormat

2020-05-31 Thread GitBox
Tartarus0zm commented on pull request #12146: URL: https://github.com/apache/flink/pull/12146#issuecomment-636584737 @wuchong Thank you very much for your review, I have fixed these issues, please review again This is an aut

[GitHub] [flink] Tartarus0zm commented on pull request #12146: [FLINK-17968][hbase] Fix Hadoop Configuration is not properly serialized in HBaseRowInputFormat

2020-05-29 Thread GitBox
Tartarus0zm commented on pull request #12146: URL: https://github.com/apache/flink/pull/12146#issuecomment-635982323 @wuchong @rmetzger I removed the logic of generating hbase-site.xml in the unit test, and must set Hbase configuration when initialize HbaseInputFormat . please take a look