Thesharing commented on pull request #1:
URL: https://github.com/apache/flink/pull/1#issuecomment-1010846811
> Why is the order of units important?
Because
[tests](https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=29288&view=logs&j=0c940707-2659-5648-cbe6
Thesharing commented on pull request #1:
URL: https://github.com/apache/flink/pull/1#issuecomment-1010705038
> hi @Thesharing , orignial commits are 4, i just reset the first commit and
rebase code, then ci is running and you can see the log
Thank you for the rebasing the cod
Thesharing commented on pull request #1:
URL: https://github.com/apache/flink/pull/1#issuecomment-1009779106
> hi @Thesharing @tillrohrmann sorry for late response. if we do not want to
make changes such as docs and many file, we can change code from
MINUTES(ChronoUnit.MINUTES, sin
Thesharing commented on pull request #1:
URL: https://github.com/apache/flink/pull/1#issuecomment-971248094
I think it's great to support using "m" to denote minutes. But I think we
shouldn't change the existing configurations from "min" to "m". It breaks
consistency of configurati
