[GitHub] [flink] TisonKun commented on a change in pull request #10104: [FLINK-14629][client] Refactor ScalaShellRemote(Stream)Environment to simplify inheritance

2019-11-13 Thread GitBox
TisonKun commented on a change in pull request #10104: [FLINK-14629][client] Refactor ScalaShellRemote(Stream)Environment to simplify inheritance URL: https://github.com/apache/flink/pull/10104#discussion_r346158809 ## File path: flink-scala-shell/src/main/java/org/apache/flink/api

[GitHub] [flink] TisonKun commented on a change in pull request #10104: [FLINK-14629][client] Refactor ScalaShellRemote(Stream)Environment to simplify inheritance

2019-11-13 Thread GitBox
TisonKun commented on a change in pull request #10104: [FLINK-14629][client] Refactor ScalaShellRemote(Stream)Environment to simplify inheritance URL: https://github.com/apache/flink/pull/10104#discussion_r346158429 ## File path: flink-scala-shell/src/main/java/org/apache/flink/api

[GitHub] [flink] TisonKun commented on a change in pull request #10104: [FLINK-14629][client] Refactor ScalaShellRemote(Stream)Environment to simplify inheritance

2019-11-13 Thread GitBox
TisonKun commented on a change in pull request #10104: [FLINK-14629][client] Refactor ScalaShellRemote(Stream)Environment to simplify inheritance URL: https://github.com/apache/flink/pull/10104#discussion_r346158429 ## File path: flink-scala-shell/src/main/java/org/apache/flink/api

[GitHub] [flink] TisonKun commented on a change in pull request #10104: [FLINK-14629][client] Refactor ScalaShellRemote(Stream)Environment to simplify inheritance

2019-11-13 Thread GitBox
TisonKun commented on a change in pull request #10104: [FLINK-14629][client] Refactor ScalaShellRemote(Stream)Environment to simplify inheritance URL: https://github.com/apache/flink/pull/10104#discussion_r346153834 ## File path: flink-core/src/main/java/org/apache/flink/util/JarUti

[GitHub] [flink] TisonKun commented on a change in pull request #10104: [FLINK-14629][client] Refactor ScalaShellRemote(Stream)Environment to simplify inheritance

2019-11-13 Thread GitBox
TisonKun commented on a change in pull request #10104: [FLINK-14629][client] Refactor ScalaShellRemote(Stream)Environment to simplify inheritance URL: https://github.com/apache/flink/pull/10104#discussion_r346139740 ## File path: flink-scala-shell/src/main/java/org/apache/flink/api

[GitHub] [flink] TisonKun commented on a change in pull request #10104: [FLINK-14629][client] Refactor ScalaShellRemote(Stream)Environment to simplify inheritance

2019-11-13 Thread GitBox
TisonKun commented on a change in pull request #10104: [FLINK-14629][client] Refactor ScalaShellRemote(Stream)Environment to simplify inheritance URL: https://github.com/apache/flink/pull/10104#discussion_r346140200 ## File path: flink-clients/src/main/java/org/apache/flink/client/

[GitHub] [flink] TisonKun commented on a change in pull request #10104: [FLINK-14629][client] Refactor ScalaShellRemote(Stream)Environment to simplify inheritance

2019-11-13 Thread GitBox
TisonKun commented on a change in pull request #10104: [FLINK-14629][client] Refactor ScalaShellRemote(Stream)Environment to simplify inheritance URL: https://github.com/apache/flink/pull/10104#discussion_r346139932 ## File path: flink-core/src/main/java/org/apache/flink/util/JarUti

[GitHub] [flink] TisonKun commented on a change in pull request #10104: [FLINK-14629][client] Refactor ScalaShellRemote(Stream)Environment to simplify inheritance

2019-11-13 Thread GitBox
TisonKun commented on a change in pull request #10104: [FLINK-14629][client] Refactor ScalaShellRemote(Stream)Environment to simplify inheritance URL: https://github.com/apache/flink/pull/10104#discussion_r346139740 ## File path: flink-scala-shell/src/main/java/org/apache/flink/api

[GitHub] [flink] TisonKun commented on a change in pull request #10104: [FLINK-14629][client] Refactor ScalaShellRemote(Stream)Environment to simplify inheritance

2019-11-13 Thread GitBox
TisonKun commented on a change in pull request #10104: [FLINK-14629][client] Refactor ScalaShellRemote(Stream)Environment to simplify inheritance URL: https://github.com/apache/flink/pull/10104#discussion_r346139693 ## File path: flink-scala-shell/src/main/java/org/apache/flink/api

[GitHub] [flink] TisonKun commented on a change in pull request #10104: [FLINK-14629][client] Refactor ScalaShellRemote(Stream)Environment to simplify inheritance

2019-11-12 Thread GitBox
TisonKun commented on a change in pull request #10104: [FLINK-14629][client] Refactor ScalaShellRemote(Stream)Environment to simplify inheritance URL: https://github.com/apache/flink/pull/10104#discussion_r345259780 ## File path: flink-streaming-java/src/main/java/org/apache/flink/

[GitHub] [flink] TisonKun commented on a change in pull request #10104: [FLINK-14629][client] Refactor ScalaShellRemote(Stream)Environment to simplify inheritance

2019-11-11 Thread GitBox
TisonKun commented on a change in pull request #10104: [FLINK-14629][client] Refactor ScalaShellRemote(Stream)Environment to simplify inheritance URL: https://github.com/apache/flink/pull/10104#discussion_r344983911 ## File path: flink-streaming-java/src/main/java/org/apache/flink/

[GitHub] [flink] TisonKun commented on a change in pull request #10104: [FLINK-14629][client] Refactor ScalaShellRemote(Stream)Environment to simplify inheritance

2019-11-11 Thread GitBox
TisonKun commented on a change in pull request #10104: [FLINK-14629][client] Refactor ScalaShellRemote(Stream)Environment to simplify inheritance URL: https://github.com/apache/flink/pull/10104#discussion_r344983165 ## File path: flink-streaming-java/src/main/java/org/apache/flink/

[GitHub] [flink] TisonKun commented on a change in pull request #10104: [FLINK-14629][client] Refactor ScalaShellRemote(Stream)Environment to simplify inheritance

2019-11-11 Thread GitBox
TisonKun commented on a change in pull request #10104: [FLINK-14629][client] Refactor ScalaShellRemote(Stream)Environment to simplify inheritance URL: https://github.com/apache/flink/pull/10104#discussion_r344982976 ## File path: flink-java/src/main/java/org/apache/flink/api/java/R

[GitHub] [flink] TisonKun commented on a change in pull request #10104: [FLINK-14629][client] Refactor ScalaShellRemote(Stream)Environment to simplify inheritance

2019-11-11 Thread GitBox
TisonKun commented on a change in pull request #10104: [FLINK-14629][client] Refactor ScalaShellRemote(Stream)Environment to simplify inheritance URL: https://github.com/apache/flink/pull/10104#discussion_r344983030 ## File path: flink-streaming-java/src/main/java/org/apache/flink/

[GitHub] [flink] TisonKun commented on a change in pull request #10104: [FLINK-14629][client] Refactor ScalaShellRemote(Stream)Environment to simplify inheritance

2019-11-11 Thread GitBox
TisonKun commented on a change in pull request #10104: [FLINK-14629][client] Refactor ScalaShellRemote(Stream)Environment to simplify inheritance URL: https://github.com/apache/flink/pull/10104#discussion_r344982933 ## File path: flink-clients/src/main/java/org/apache/flink/client/

[GitHub] [flink] TisonKun commented on a change in pull request #10104: [FLINK-14629][client] Refactor ScalaShellRemote(Stream)Environment to simplify inheritance

2019-11-06 Thread GitBox
TisonKun commented on a change in pull request #10104: [FLINK-14629][client] Refactor ScalaShellRemote(Stream)Environment to simplify inheritance URL: https://github.com/apache/flink/pull/10104#discussion_r343005964 ## File path: flink-clients/src/main/java/org/apache/flink/client/C