[GitHub] [flink] TisonKun commented on issue #10100: [FLINK-14627][tests] Refactor ExecutionGraph creation in tests as TestingExecutionGraphBuilder

2019-11-13 Thread GitBox
TisonKun commented on issue #10100: [FLINK-14627][tests] Refactor ExecutionGraph creation in tests as TestingExecutionGraphBuilder URL: https://github.com/apache/flink/pull/10100#issuecomment-553642940 Thanks for your review @zhuzhurk ! -

[GitHub] [flink] TisonKun commented on issue #10100: [FLINK-14627][tests] Refactor ExecutionGraph creation in tests as TestingExecutionGraphBuilder

2019-11-13 Thread GitBox
TisonKun commented on issue #10100: [FLINK-14627][tests] Refactor ExecutionGraph creation in tests as TestingExecutionGraphBuilder URL: https://github.com/apache/flink/pull/10100#issuecomment-553370824 @flink run travis This

[GitHub] [flink] TisonKun commented on issue #10100: [FLINK-14627][tests] Refactor ExecutionGraph creation in tests as TestingExecutionGraphBuilder

2019-11-13 Thread GitBox
TisonKun commented on issue #10100: [FLINK-14627][tests] Refactor ExecutionGraph creation in tests as TestingExecutionGraphBuilder URL: https://github.com/apache/flink/pull/10100#issuecomment-553370899 @flinkbot run travis Th

[GitHub] [flink] TisonKun commented on issue #10100: [FLINK-14627][tests] Refactor ExecutionGraph creation in tests as TestingExecutionGraphBuilder

2019-11-13 Thread GitBox
TisonKun commented on issue #10100: [FLINK-14627][tests] Refactor ExecutionGraph creation in tests as TestingExecutionGraphBuilder URL: https://github.com/apache/flink/pull/10100#issuecomment-553292537 @zhuzhurk I take a look at the only ongoing issue FLINK-14594 a.k.a #10079 which has no

[GitHub] [flink] TisonKun commented on issue #10100: [FLINK-14627][tests] Refactor ExecutionGraph creation in tests as TestingExecutionGraphBuilder

2019-11-13 Thread GitBox
TisonKun commented on issue #10100: [FLINK-14627][tests] Refactor ExecutionGraph creation in tests as TestingExecutionGraphBuilder URL: https://github.com/apache/flink/pull/10100#issuecomment-553291835 @zhuzhurk is it hard to rebase FLINK-14314 on this pr? Could you verify the overhead? Ot

[GitHub] [flink] TisonKun commented on issue #10100: [FLINK-14627][tests] Refactor ExecutionGraph creation in tests as TestingExecutionGraphBuilder

2019-11-12 Thread GitBox
TisonKun commented on issue #10100: [FLINK-14627][tests] Refactor ExecutionGraph creation in tests as TestingExecutionGraphBuilder URL: https://github.com/apache/flink/pull/10100#issuecomment-553223133 @flinkbot run travis Th

[GitHub] [flink] TisonKun commented on issue #10100: [FLINK-14627][tests] Refactor ExecutionGraph creation in tests as TestingExecutionGraphBuilder

2019-11-12 Thread GitBox
TisonKun commented on issue #10100: [FLINK-14627][tests] Refactor ExecutionGraph creation in tests as TestingExecutionGraphBuilder URL: https://github.com/apache/flink/pull/10100#issuecomment-553223085 @zhuzhurk @zhijiangW could you please help on reviewing this pull request? I'm afraid th