[GitHub] [flink] TisonKun commented on issue #11174: [FLINK-16199][sql] Support IS JSON predicate for blink planner

2020-03-09 Thread GitBox
TisonKun commented on issue #11174: [FLINK-16199][sql] Support IS JSON predicate for blink planner URL: https://github.com/apache/flink/pull/11174#issuecomment-596415232 @wuchong Thanks for your review! This is an automated m

[GitHub] [flink] TisonKun commented on issue #11174: [FLINK-16199][sql] Support IS JSON predicate for blink planner

2020-03-02 Thread GitBox
TisonKun commented on issue #11174: [FLINK-16199][sql] Support IS JSON predicate for blink planner URL: https://github.com/apache/flink/pull/11174#issuecomment-593325287 @wuchong thanks for your review! I've addressed comments. Please take another took :-)

[GitHub] [flink] TisonKun commented on issue #11174: [FLINK-16199][sql] Support IS JSON predicate for blink planner

2020-02-23 Thread GitBox
TisonKun commented on issue #11174: [FLINK-16199][sql] Support IS JSON predicate for blink planner URL: https://github.com/apache/flink/pull/11174#issuecomment-590075145 @libenchao you're right the fixup commit helps on review. The community doesn't have a literal guide on this part but I

[GitHub] [flink] TisonKun commented on issue #11174: [FLINK-16199][sql] Support IS JSON predicate for blink planner

2020-02-21 Thread GitBox
TisonKun commented on issue #11174: [FLINK-16199][sql] Support IS JSON predicate for blink planner URL: https://github.com/apache/flink/pull/11174#issuecomment-589641231 Hi @wuchong please give it a review when you have spare time. Besides, I'll appreciate it if anyone can guide me t