[GitHub] [flink] TisonKun commented on issue #9684: [FLINK-13992][coordination] Refactor Optional parameter in InputGateWithMetrics#updateMetrics

2019-09-18 Thread GitBox
TisonKun commented on issue #9684: [FLINK-13992][coordination] Refactor Optional parameter in InputGateWithMetrics#updateMetrics URL: https://github.com/apache/flink/pull/9684#issuecomment-532922137 ping @azagrebin as a reminder :-) -

[GitHub] [flink] TisonKun commented on issue #9684: [FLINK-13992][coordination] Refactor Optional parameter in InputGateWithMetrics#updateMetrics

2019-09-16 Thread GitBox
TisonKun commented on issue #9684: [FLINK-13992][coordination] Refactor Optional parameter in InputGateWithMetrics#updateMetrics URL: https://github.com/apache/flink/pull/9684#issuecomment-531803145 Thanks for your review @azagrebin! I'm not very sure about your addition. IMO it is g