[GitHub] [flink] XComp commented on a diff in pull request #21742: [FLINK-30765][runtime] Aligns the LeaderElectionService.stop() contract

XComp commented on code in PR #21742: URL: https://github.com/apache/flink/pull/21742#discussion_r1163923621 ## flink-runtime/src/main/java/org/apache/flink/runtime/leaderelection/DefaultLeaderElectionService.java: ## @@ -205,20 +208,7 @@ public void onGrantLeadership(UUID newLe

[GitHub] [flink] XComp commented on a diff in pull request #21742: [FLINK-30765][runtime] Aligns the LeaderElectionService.stop() contract

XComp commented on code in PR #21742: URL: https://github.com/apache/flink/pull/21742#discussion_r1163923621 ## flink-runtime/src/main/java/org/apache/flink/runtime/leaderelection/DefaultLeaderElectionService.java: ## @@ -205,20 +208,7 @@ public void onGrantLeadership(UUID newLe

[GitHub] [flink] XComp commented on a diff in pull request #21742: [FLINK-30765][runtime] Aligns the LeaderElectionService.stop() contract

XComp commented on code in PR #21742: URL: https://github.com/apache/flink/pull/21742#discussion_r1163923621 ## flink-runtime/src/main/java/org/apache/flink/runtime/leaderelection/DefaultLeaderElectionService.java: ## @@ -205,20 +208,7 @@ public void onGrantLeadership(UUID newLe

[GitHub] [flink] XComp commented on a diff in pull request #21742: [FLINK-30765][runtime] Aligns the LeaderElectionService.stop() contract

XComp commented on code in PR #21742: URL: https://github.com/apache/flink/pull/21742#discussion_r1162646690 ## flink-runtime/src/main/java/org/apache/flink/runtime/leaderelection/DefaultLeaderElectionService.java: ## @@ -100,6 +100,7 @@ public final void stop() throws Exception

[GitHub] [flink] XComp commented on a diff in pull request #21742: [FLINK-30765][runtime] Aligns the LeaderElectionService.stop() contract

XComp commented on code in PR #21742: URL: https://github.com/apache/flink/pull/21742#discussion_r1162646690 ## flink-runtime/src/main/java/org/apache/flink/runtime/leaderelection/DefaultLeaderElectionService.java: ## @@ -100,6 +100,7 @@ public final void stop() throws Exception

[GitHub] [flink] XComp commented on a diff in pull request #21742: [FLINK-30765][runtime] Aligns the LeaderElectionService.stop() contract

XComp commented on code in PR #21742: URL: https://github.com/apache/flink/pull/21742#discussion_r1104142315 ## flink-runtime/src/main/java/org/apache/flink/runtime/leaderelection/DefaultLeaderElectionService.java: ## @@ -100,6 +100,7 @@ public final void stop() throws Exception

[GitHub] [flink] XComp commented on a diff in pull request #21742: [FLINK-30765][runtime] Aligns the LeaderElectionService.stop() contract

XComp commented on code in PR #21742: URL: https://github.com/apache/flink/pull/21742#discussion_r1099989601 ## flink-runtime/src/main/java/org/apache/flink/runtime/leaderelection/DefaultLeaderElectionService.java: ## @@ -100,6 +100,7 @@ public final void stop() throws Exception

[GitHub] [flink] XComp commented on a diff in pull request #21742: [FLINK-30765][runtime] Aligns the LeaderElectionService.stop() contract

XComp commented on code in PR #21742: URL: https://github.com/apache/flink/pull/21742#discussion_r1099989601 ## flink-runtime/src/main/java/org/apache/flink/runtime/leaderelection/DefaultLeaderElectionService.java: ## @@ -100,6 +100,7 @@ public final void stop() throws Exception

[GitHub] [flink] XComp commented on a diff in pull request #21742: [FLINK-30765][runtime] Aligns the LeaderElectionService.stop() contract

XComp commented on code in PR #21742: URL: https://github.com/apache/flink/pull/21742#discussion_r1098595984 ## flink-runtime/src/main/java/org/apache/flink/runtime/leaderelection/DefaultLeaderElectionService.java: ## @@ -100,6 +100,7 @@ public final void stop() throws Exception

[GitHub] [flink] XComp commented on a diff in pull request #21742: [FLINK-30765][runtime] Aligns the LeaderElectionService.stop() contract

XComp commented on code in PR #21742: URL: https://github.com/apache/flink/pull/21742#discussion_r1082832944 ## flink-runtime/src/main/java/org/apache/flink/runtime/leaderelection/DefaultLeaderElectionService.java: ## @@ -100,6 +100,7 @@ public final void stop() throws Exception

[GitHub] [flink] XComp commented on a diff in pull request #21742: [FLINK-30765][runtime] Aligns the LeaderElectionService.stop() contract

XComp commented on code in PR #21742: URL: https://github.com/apache/flink/pull/21742#discussion_r1082832944 ## flink-runtime/src/main/java/org/apache/flink/runtime/leaderelection/DefaultLeaderElectionService.java: ## @@ -100,6 +100,7 @@ public final void stop() throws Exception

[GitHub] [flink] XComp commented on a diff in pull request #21742: [FLINK-30765][runtime] Aligns the LeaderElectionService.stop() contract

XComp commented on code in PR #21742: URL: https://github.com/apache/flink/pull/21742#discussion_r1082832944 ## flink-runtime/src/main/java/org/apache/flink/runtime/leaderelection/DefaultLeaderElectionService.java: ## @@ -100,6 +100,7 @@ public final void stop() throws Exception

[GitHub] [flink] XComp commented on a diff in pull request #21742: [FLINK-30765][runtime] Aligns the LeaderElectionService.stop() contract

XComp commented on code in PR #21742: URL: https://github.com/apache/flink/pull/21742#discussion_r1082817072 ## flink-runtime/src/main/java/org/apache/flink/runtime/leaderelection/DefaultLeaderElectionService.java: ## @@ -100,6 +100,7 @@ public final void stop() throws Exception