[GitHub] [flink] XComp commented on a diff in pull request #22380: [FLINK-31773][runtime] Separate DefaultLeaderElectionService.start(LeaderContender) into two separate methods for starting the driver

XComp commented on code in PR #22380: URL: https://github.com/apache/flink/pull/22380#discussion_r1193867705 ## flink-runtime/src/test/java/org/apache/flink/runtime/leaderelection/TestingLeaderBase.java: ## @@ -80,6 +84,20 @@ public Throwable getError() { return error

[GitHub] [flink] XComp commented on a diff in pull request #22380: [FLINK-31773][runtime] Separate DefaultLeaderElectionService.start(LeaderContender) into two separate methods for starting the driver

XComp commented on code in PR #22380: URL: https://github.com/apache/flink/pull/22380#discussion_r1193866384 ## flink-runtime/src/main/java/org/apache/flink/runtime/leaderelection/DefaultLeaderElectionService.java: ## @@ -270,65 +390,73 @@ public void

[GitHub] [flink] XComp commented on a diff in pull request #22380: [FLINK-31773][runtime] Separate DefaultLeaderElectionService.start(LeaderContender) into two separate methods for starting the driver

XComp commented on code in PR #22380: URL: https://github.com/apache/flink/pull/22380#discussion_r1193863651 ## flink-runtime/src/main/java/org/apache/flink/runtime/leaderelection/DefaultLeaderElectionService.java: ## @@ -32,49 +31,73 @@ import javax.annotation.Nullable;

[GitHub] [flink] XComp commented on a diff in pull request #22380: [FLINK-31773][runtime] Separate DefaultLeaderElectionService.start(LeaderContender) into two separate methods for starting the driver

XComp commented on code in PR #22380: URL: https://github.com/apache/flink/pull/22380#discussion_r1169887689 ## flink-runtime/src/test/java/org/apache/flink/runtime/leaderelection/TestingLeaderElectionDriver.java: ## @@ -70,22 +77,37 @@ public LeaderInformation

[GitHub] [flink] XComp commented on a diff in pull request #22380: [FLINK-31773][runtime] Separate DefaultLeaderElectionService.start(LeaderContender) into two separate methods for starting the driver

XComp commented on code in PR #22380: URL: https://github.com/apache/flink/pull/22380#discussion_r1169887689 ## flink-runtime/src/test/java/org/apache/flink/runtime/leaderelection/TestingLeaderElectionDriver.java: ## @@ -70,22 +77,37 @@ public LeaderInformation

[GitHub] [flink] XComp commented on a diff in pull request #22380: [FLINK-31773][runtime] Separate DefaultLeaderElectionService.start(LeaderContender) into two separate methods for starting the driver

XComp commented on code in PR #22380: URL: https://github.com/apache/flink/pull/22380#discussion_r1169874448 ## flink-runtime/src/test/java/org/apache/flink/runtime/leaderelection/TestingLeaderElectionDriver.java: ## @@ -70,22 +77,37 @@ public LeaderInformation

[GitHub] [flink] XComp commented on a diff in pull request #22380: [FLINK-31773][runtime] Separate DefaultLeaderElectionService.start(LeaderContender) into two separate methods for starting the driver

XComp commented on code in PR #22380: URL: https://github.com/apache/flink/pull/22380#discussion_r1169874448 ## flink-runtime/src/test/java/org/apache/flink/runtime/leaderelection/TestingLeaderElectionDriver.java: ## @@ -70,22 +77,37 @@ public LeaderInformation

[GitHub] [flink] XComp commented on a diff in pull request #22380: [FLINK-31773][runtime] Separate DefaultLeaderElectionService.start(LeaderContender) into two separate methods for starting the driver

XComp commented on code in PR #22380: URL: https://github.com/apache/flink/pull/22380#discussion_r1169862792 ## flink-runtime/src/main/java/org/apache/flink/runtime/leaderelection/DefaultLeaderElectionService.java: ## @@ -37,35 +37,58 @@ * Default implementation for leader

[GitHub] [flink] XComp commented on a diff in pull request #22380: [FLINK-31773][runtime] Separate DefaultLeaderElectionService.start(LeaderContender) into two separate methods for starting the driver

XComp commented on code in PR #22380: URL: https://github.com/apache/flink/pull/22380#discussion_r1169844096 ## flink-runtime/src/test/java/org/apache/flink/runtime/leaderelection/ZooKeeperLeaderElectionTest.java: ## @@ -302,6 +303,8 @@ void

[GitHub] [flink] XComp commented on a diff in pull request #22380: [FLINK-31773][runtime] Separate DefaultLeaderElectionService.start(LeaderContender) into two separate methods for starting the driver

XComp commented on code in PR #22380: URL: https://github.com/apache/flink/pull/22380#discussion_r1169837248 ## flink-runtime/src/main/java/org/apache/flink/runtime/leaderelection/DefaultLeaderElectionService.java: ## @@ -145,96 +222,122 @@ public void confirmLeadership(UUID

[GitHub] [flink] XComp commented on a diff in pull request #22380: [FLINK-31773][runtime] Separate DefaultLeaderElectionService.start(LeaderContender) into two separate methods for starting the driver

XComp commented on code in PR #22380: URL: https://github.com/apache/flink/pull/22380#discussion_r1169834833 ## flink-runtime/src/main/java/org/apache/flink/runtime/leaderelection/DefaultLeaderElectionService.java: ## @@ -37,35 +37,58 @@ * Default implementation for leader

[GitHub] [flink] XComp commented on a diff in pull request #22380: [FLINK-31773][runtime] Separate DefaultLeaderElectionService.start(LeaderContender) into two separate methods for starting the driver

XComp commented on code in PR #22380: URL: https://github.com/apache/flink/pull/22380#discussion_r1169832741 ## flink-runtime/src/main/java/org/apache/flink/runtime/leaderelection/DefaultLeaderElectionService.java: ## @@ -145,96 +222,122 @@ public void confirmLeadership(UUID

[GitHub] [flink] XComp commented on a diff in pull request #22380: [FLINK-31773][runtime] Separate DefaultLeaderElectionService.start(LeaderContender) into two separate methods for starting the driver

XComp commented on code in PR #22380: URL: https://github.com/apache/flink/pull/22380#discussion_r1169826770 ## flink-runtime/src/main/java/org/apache/flink/runtime/leaderelection/DefaultLeaderElectionService.java: ## @@ -77,22 +100,48 @@ public

[GitHub] [flink] XComp commented on a diff in pull request #22380: [FLINK-31773][runtime] Separate DefaultLeaderElectionService.start(LeaderContender) into two separate methods for starting the driver

XComp commented on code in PR #22380: URL: https://github.com/apache/flink/pull/22380#discussion_r1169800445 ## flink-runtime/src/main/java/org/apache/flink/runtime/leaderelection/DefaultLeaderElectionService.java: ## @@ -37,35 +37,58 @@ * Default implementation for leader

[GitHub] [flink] XComp commented on a diff in pull request #22380: [FLINK-31773][runtime] Separate DefaultLeaderElectionService.start(LeaderContender) into two separate methods for starting the driver

XComp commented on code in PR #22380: URL: https://github.com/apache/flink/pull/22380#discussion_r1169800445 ## flink-runtime/src/main/java/org/apache/flink/runtime/leaderelection/DefaultLeaderElectionService.java: ## @@ -37,35 +37,58 @@ * Default implementation for leader

[GitHub] [flink] XComp commented on a diff in pull request #22380: [FLINK-31773][runtime] Separate DefaultLeaderElectionService.start(LeaderContender) into two separate methods for starting the driver

XComp commented on code in PR #22380: URL: https://github.com/apache/flink/pull/22380#discussion_r1169789210 ## flink-runtime/src/main/java/org/apache/flink/runtime/leaderelection/DefaultLeaderElectionService.java: ## @@ -37,35 +37,58 @@ * Default implementation for leader

[GitHub] [flink] XComp commented on a diff in pull request #22380: [FLINK-31773][runtime] Separate DefaultLeaderElectionService.start(LeaderContender) into two separate methods for starting the driver

XComp commented on code in PR #22380: URL: https://github.com/apache/flink/pull/22380#discussion_r1169789210 ## flink-runtime/src/main/java/org/apache/flink/runtime/leaderelection/DefaultLeaderElectionService.java: ## @@ -37,35 +37,58 @@ * Default implementation for leader

[GitHub] [flink] XComp commented on a diff in pull request #22380: [FLINK-31773][runtime] Separate DefaultLeaderElectionService.start(LeaderContender) into two separate methods for starting the driver

XComp commented on code in PR #22380: URL: https://github.com/apache/flink/pull/22380#discussion_r1169784060 ## flink-runtime/src/test/java/org/apache/flink/runtime/leaderelection/DefaultLeaderElectionServiceTest.java: ## @@ -69,6 +71,118 @@ void

[GitHub] [flink] XComp commented on a diff in pull request #22380: [FLINK-31773][runtime] Separate DefaultLeaderElectionService.start(LeaderContender) into two separate methods for starting the driver

XComp commented on code in PR #22380: URL: https://github.com/apache/flink/pull/22380#discussion_r1169775001 ## flink-runtime/src/test/java/org/apache/flink/runtime/leaderelection/DefaultLeaderElectionServiceTest.java: ## @@ -69,6 +71,118 @@ void

[GitHub] [flink] XComp commented on a diff in pull request #22380: [FLINK-31773][runtime] Separate DefaultLeaderElectionService.start(LeaderContender) into two separate methods for starting the driver

XComp commented on code in PR #22380: URL: https://github.com/apache/flink/pull/22380#discussion_r1169762851 ## flink-runtime/src/test/java/org/apache/flink/runtime/leaderelection/DefaultLeaderElectionServiceTest.java: ## @@ -69,6 +71,118 @@ void

[GitHub] [flink] XComp commented on a diff in pull request #22380: [FLINK-31773][runtime] Separate DefaultLeaderElectionService.start(LeaderContender) into two separate methods for starting the driver

XComp commented on code in PR #22380: URL: https://github.com/apache/flink/pull/22380#discussion_r1169762851 ## flink-runtime/src/test/java/org/apache/flink/runtime/leaderelection/DefaultLeaderElectionServiceTest.java: ## @@ -69,6 +71,118 @@ void

[GitHub] [flink] XComp commented on a diff in pull request #22380: [FLINK-31773][runtime] Separate DefaultLeaderElectionService.start(LeaderContender) into two separate methods for starting the driver

XComp commented on code in PR #22380: URL: https://github.com/apache/flink/pull/22380#discussion_r1169638735 ## flink-runtime/src/test/java/org/apache/flink/runtime/leaderelection/DefaultLeaderElectionServiceTest.java: ## @@ -69,6 +71,118 @@ void

[GitHub] [flink] XComp commented on a diff in pull request #22380: [FLINK-31773][runtime] Separate DefaultLeaderElectionService.start(LeaderContender) into two separate methods for starting the driver

XComp commented on code in PR #22380: URL: https://github.com/apache/flink/pull/22380#discussion_r1169042058 ## flink-runtime/src/test/java/org/apache/flink/runtime/leaderelection/TestingLeaderElectionDriver.java: ## @@ -70,22 +77,37 @@ public LeaderInformation

[GitHub] [flink] XComp commented on a diff in pull request #22380: [FLINK-31773][runtime] Separate DefaultLeaderElectionService.start(LeaderContender) into two separate methods for starting the driver

XComp commented on code in PR #22380: URL: https://github.com/apache/flink/pull/22380#discussion_r1169042058 ## flink-runtime/src/test/java/org/apache/flink/runtime/leaderelection/TestingLeaderElectionDriver.java: ## @@ -70,22 +77,37 @@ public LeaderInformation

[GitHub] [flink] XComp commented on a diff in pull request #22380: [FLINK-31773][runtime] Separate DefaultLeaderElectionService.start(LeaderContender) into two separate methods for starting the driver

XComp commented on code in PR #22380: URL: https://github.com/apache/flink/pull/22380#discussion_r1169023770 ## flink-runtime/src/test/java/org/apache/flink/runtime/jobmaster/JobMasterServiceLeadershipRunnerTest.java: ## @@ -772,7 +773,11 @@ void