[GitHub] [flink] XComp commented on pull request #15020: [FLINK-21445][kubernetes] Application mode does not set the configuration when building PackagedProgram

2021-06-22 Thread GitBox
XComp commented on pull request #15020: URL: https://github.com/apache/flink/pull/15020#issuecomment-864806544 Hi @SteNicholas , I'm going to pick up that one if that's ok with you. ...just to have it off the list. -- This is an automated message from the Apache Git Service. To respond t

[GitHub] [flink] XComp commented on pull request #15020: [FLINK-21445][kubernetes] Application mode does not set the configuration when building PackagedProgram

2021-06-21 Thread GitBox
XComp commented on pull request #15020: URL: https://github.com/apache/flink/pull/15020#issuecomment-864806544 Hi @SteNicholas , I'm going to pick up that one if that's ok with you. ...just to have it off the list. -- This is an automated message from the Apache Git Service. To respond t

[GitHub] [flink] XComp commented on pull request #15020: [FLINK-21445][kubernetes] Application mode does not set the configuration when building PackagedProgram

2021-06-02 Thread GitBox
XComp commented on pull request #15020: URL: https://github.com/apache/flink/pull/15020#issuecomment-852804780 Hi @SteNicholas , how is the this issue's progress? I'm wondering whether you could give a time estimate on when you're able to close it. I understand that there are other things

[GitHub] [flink] XComp commented on pull request #15020: [FLINK-21445][kubernetes] Application mode does not set the configuration when building PackagedProgram

2021-05-05 Thread GitBox
XComp commented on pull request #15020: URL: https://github.com/apache/flink/pull/15020#issuecomment-833264629 @SteNicholas just a kind ping. :-) do you have an idea when you could continue working on this issue? -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [flink] XComp commented on pull request #15020: [FLINK-21445][kubernetes] Application mode does not set the configuration when building PackagedProgram

2021-04-12 Thread GitBox
XComp commented on pull request #15020: URL: https://github.com/apache/flink/pull/15020#issuecomment-817822215 @SteNicholas Did you have a chance to work on it? Or do you have an idea when to proceed? -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [flink] XComp commented on pull request #15020: [FLINK-21445][kubernetes] Application mode does not set the configuration when building PackagedProgram

2021-04-05 Thread GitBox
XComp commented on pull request #15020: URL: https://github.com/apache/flink/pull/15020#issuecomment-813454338 Any updates from your side, @SteNicholas ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [flink] XComp commented on pull request #15020: [FLINK-21445][kubernetes] Application mode does not set the configuration when building PackagedProgram

2021-03-28 Thread GitBox
XComp commented on pull request #15020: URL: https://github.com/apache/flink/pull/15020#issuecomment-809117295 Ok, thanks @SteNicholas . I'll give it another pass when you're done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [flink] XComp commented on pull request #15020: [FLINK-21445][kubernetes] Application mode does not set the configuration when building PackagedProgram

2021-02-26 Thread GitBox
XComp commented on pull request #15020: URL: https://github.com/apache/flink/pull/15020#issuecomment-787030241 Sorry for not getting back earlier: I second @wangyang0918 proposal. The code should be easier to test after the proposed change. Additionally, the `JarsOnClassPath` singleton see