[GitHub] [flink] XComp commented on pull request #15134: [FLINK-21654][test] Added @throws information to tests

2021-03-18 Thread GitBox
XComp commented on pull request #15134: URL: https://github.com/apache/flink/pull/15134#issuecomment-802007409 Now I got your point. I just checked the `YarnTestBase`-internal calls but didn't check other classes. I updated the code accordingly. -- This is an automated message from the

[GitHub] [flink] XComp commented on pull request #15134: [FLINK-21654][test] Added @throws information to tests

2021-03-12 Thread GitBox
XComp commented on pull request #15134: URL: https://github.com/apache/flink/pull/15134#issuecomment-797634153 I applied your comments, squashed the commits and rebased the branch. This is an automated message from the

[GitHub] [flink] XComp commented on pull request #15134: [FLINK-21654][test] Added @throws information to tests

2021-03-12 Thread GitBox
XComp commented on pull request #15134: URL: https://github.com/apache/flink/pull/15134#issuecomment-797633919 > Thanks for creating this PR @XComp. I think the change makes sense. I had a few minor comments. > > Why is this problem only limited to when we close the `YarnTestBase`?

[GitHub] [flink] XComp commented on pull request #15134: [FLINK-21654][test] Added @throws information to tests

2021-03-10 Thread GitBox
XComp commented on pull request #15134: URL: https://github.com/apache/flink/pull/15134#issuecomment-796530551 I left the commits unsquashed for now to be transparent on the test runs as well. This is an automated message

[GitHub] [flink] XComp commented on pull request #15134: [FLINK-21654][test] Added @throws information to tests

2021-03-10 Thread GitBox
XComp commented on pull request #15134: URL: https://github.com/apache/flink/pull/15134#issuecomment-796527987 I tried reproducing the failure first in [this build](https://dev.azure.com/mapohl/flink/_build/results?buildId=331=results) with