[GitHub] [flink] XComp commented on pull request #18644: [FLINK-25974] Makes job cancellation rely on JobResultStore entry

2022-02-13 Thread GitBox
XComp commented on pull request #18644: URL: https://github.com/apache/flink/pull/18644#issuecomment-1038306192 I addressed all your comments and squashed the commits into appropriate chunks. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [flink] XComp commented on pull request #18644: [FLINK-25974] Makes job cancellation rely on JobResultStore entry

2022-02-13 Thread GitBox
XComp commented on pull request #18644: URL: https://github.com/apache/flink/pull/18644#issuecomment-1038306192 I addressed all your comments and squashed the commits into appropriate chunks. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [flink] XComp commented on pull request #18644: [FLINK-25974] Makes job cancellation rely on JobResultStore entry

2022-02-11 Thread GitBox
XComp commented on pull request #18644: URL: https://github.com/apache/flink/pull/18644#issuecomment-1036435463 I addressed comments, @metaswirl had. I squashed and rebased the branch... -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [flink] XComp commented on pull request #18644: [FLINK-25974] Makes job cancellation rely on JobResultStore entry

2022-02-11 Thread GitBox
XComp commented on pull request #18644: URL: https://github.com/apache/flink/pull/18644#issuecomment-1036325680 @dmvk I addressed your concerns and did some more research. Please check the commit messages for further details on the reasoning. -- This is an automated message from the

[GitHub] [flink] XComp commented on pull request #18644: [FLINK-25974] Makes job cancellation rely on JobResultStore entry

2022-02-10 Thread GitBox
XComp commented on pull request #18644: URL: https://github.com/apache/flink/pull/18644#issuecomment-1034821588 I went through the code once more after you raised valid concerns. I reverted my changes and investigated the cancellation code path for the `JobMasterServiceLeadershipRunner`.