[GitHub] [flink] XComp commented on pull request #18869: [FLINK-26284] Introduces mark-for-deletion state in ZooKeeperStateHandleStore

2022-02-28 Thread GitBox
XComp commented on pull request #18869: URL: https://github.com/apache/flink/pull/18869#issuecomment-1054100223 Test failure are unrelated to this change: * FLINK-26393 * [FLINK-26321](https://issues.apache.org/jira/browse/FLINK-26321) -- This is an automated message from the Apache

[GitHub] [flink] XComp commented on pull request #18869: [FLINK-26284] Introduces mark-for-deletion state in ZooKeeperStateHandleStore

2022-02-27 Thread GitBox
XComp commented on pull request #18869: URL: https://github.com/apache/flink/pull/18869#issuecomment-1053977510 rebased branch after PR #18919 was merged -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [flink] XComp commented on pull request #18869: [FLINK-26284] Introduces mark-for-deletion state in ZooKeeperStateHandleStore

2022-02-25 Thread GitBox
XComp commented on pull request #18869: URL: https://github.com/apache/flink/pull/18869#issuecomment-1051008394 > I did another minor refactoring in order to be consistent with the changes of https://github.com/apache/flink/pull/18901 (see [comment](https://github.com/apache/flink/pull/189

[GitHub] [flink] XComp commented on pull request #18869: [FLINK-26284] Introduces mark-for-deletion state in ZooKeeperStateHandleStore

2022-02-25 Thread GitBox
XComp commented on pull request #18869: URL: https://github.com/apache/flink/pull/18869#issuecomment-1050766013 I did another minor refactoring in order to be consistent with the changes of #18901 (see [comment](https://github.com/apache/flink/pull/18901/files#r814672839)): `addAndLock` i

[GitHub] [flink] XComp commented on pull request #18869: [FLINK-26284] Introduces mark-for-deletion state in ZooKeeperStateHandleStore

2022-02-25 Thread GitBox
XComp commented on pull request #18869: URL: https://github.com/apache/flink/pull/18869#issuecomment-1050742102 I reorganized the commits once more moving the FLINK-26285 fix into its own PR #18919 and rebased this branch onto the FLINK-26285 PR (that's why there's an additional commit sti

[GitHub] [flink] XComp commented on pull request #18869: [FLINK-26284] Introduces mark-for-deletion state in ZooKeeperStateHandleStore

2022-02-25 Thread GitBox
XComp commented on pull request #18869: URL: https://github.com/apache/flink/pull/18869#issuecomment-1050669327 Thanks for the approval, @dmvk . I addressed your comments (and also updated the `StateHandleStore.getAllHandles` JavaDoc as discussed off-topic). -- This is an automated messa

[GitHub] [flink] XComp commented on pull request #18869: [FLINK-26284] Introduces mark-for-deletion state in ZooKeeperStateHandleStore

2022-02-24 Thread GitBox
XComp commented on pull request #18869: URL: https://github.com/apache/flink/pull/18869#issuecomment-1050102076 @dmvk thanks for looking at the PR. I addressed or responded to your comments. PTAL -- This is an automated message from the Apache Git Service. To respond to the message, plea