[GitHub] [flink] XComp commented on pull request #20673: [BP-1.15][FLINK-28265][k8s] Make KubernetesStateHandleStore#addEntry idempotent

2022-08-26 Thread GitBox
XComp commented on PR #20673: URL: https://github.com/apache/flink/pull/20673#issuecomment-1228163552 > @XComp Oh, my bad. I should not introduce this concurrent issue here. Either the callbackInvocationCount needs to be asserted in the whenComplete, or I should execute CompletableFuture.su

[GitHub] [flink] XComp commented on pull request #20673: [BP-1.15][FLINK-28265][k8s] Make KubernetesStateHandleStore#addEntry idempotent

2022-08-25 Thread GitBox
XComp commented on PR #20673: URL: https://github.com/apache/flink/pull/20673#issuecomment-1227172486 hm, is the failure happening because we're not explicitly setting the direct executor for the initial `CompletableFuture` that gets created through `CompletableFuture.supplyAsync`. That way