Xeli commented on issue #8259: [FLINK-12325][metrics] Fix bug in statsd exporter when using negative values URL: https://github.com/apache/flink/pull/8259#issuecomment-487275106 Hi @zentol, I've added Gauge support by checking if the type is (a subclass of) `Numeric`. You make a good point about the risk of sending 2 udp packages. I'm seeing some mixed documentation about how we might solve this. Most do not mention anything about sending multiple metrics in a single udp package at all. One explicitly states newlines can be used, while another states only one metric per udp can be used. I've tried a couple of implementations' docker images to see if it would work with the new lines. One seemed to support it, but most did not properly. I think a proper way of supporting this is to add the ability of statsd through tcp, and keep this udp implementation as a sort of best-effort. What do you think?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
