aljoscha commented on a change in pull request #10835: [FLINK-15533] Fix 
parallelism setting propagation during graph instantiation.
URL: https://github.com/apache/flink/pull/10835#discussion_r365811483
 
 

 ##########
 File path: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java
 ##########
 @@ -272,6 +272,7 @@ public StreamExecutionEnvironment setMaxParallelism(int 
maxParallelism) {
         * value.
         */
        public int getParallelism() {
+               consolidateParallelismDefinitionsInConfiguration();
 
 Review comment:
   I think we should call this in the constructor, so that it is called at a 
well known location and not the just the first time `getParallelism()` is 
called. There is still some legacy weirdness around this setting, because the 
`ExecutionConfig` sets this to `PARALLELISM_DEFAULT` but this value is then 
never used. This is for legacy reasons.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to