[GitHub] [flink] aljoscha commented on a change in pull request #14312: [FLINK-20491] Support Broadcast State in BATCH execution mode

2021-01-05 Thread GitBox
aljoscha commented on a change in pull request #14312: URL: https://github.com/apache/flink/pull/14312#discussion_r551824176 ## File path: docs/dev/datastream_execution_mode.md ## @@ -1,8 +1,6 @@ --- title: "Execution Mode (Batch/Streaming)" -nav-id: datastream_execution_mode

[GitHub] [flink] aljoscha commented on a change in pull request #14312: [FLINK-20491] Support Broadcast State in BATCH execution mode

2021-01-04 Thread GitBox
aljoscha commented on a change in pull request #14312: URL: https://github.com/apache/flink/pull/14312#discussion_r551461770 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/StreamMultipleInputProcessorFactory.java ## @@ -142,6 +148,7 @@ p

[GitHub] [flink] aljoscha commented on a change in pull request #14312: [FLINK-20491] Support Broadcast State in BATCH execution mode

2021-01-04 Thread GitBox
aljoscha commented on a change in pull request #14312: URL: https://github.com/apache/flink/pull/14312#discussion_r551461439 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/sort/MultiInputSortingDataInput.java ## @@ -107,29 +112,38 @@

[GitHub] [flink] aljoscha commented on a change in pull request #14312: [FLINK-20491] Support Broadcast State in BATCH execution mode

2021-01-04 Thread GitBox
aljoscha commented on a change in pull request #14312: URL: https://github.com/apache/flink/pull/14312#discussion_r551461102 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/transformations/AbstractBroadcastStateTransformation.java ## @@ -0,0 +1,

[GitHub] [flink] aljoscha commented on a change in pull request #14312: [FLINK-20491] Support Broadcast State in BATCH execution mode

2021-01-04 Thread GitBox
aljoscha commented on a change in pull request #14312: URL: https://github.com/apache/flink/pull/14312#discussion_r551460963 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/sort/MultiInputSortingDataInput.java ## @@ -107,29 +112,38 @@

[GitHub] [flink] aljoscha commented on a change in pull request #14312: [FLINK-20491] Support Broadcast State in BATCH execution mode

2021-01-04 Thread GitBox
aljoscha commented on a change in pull request #14312: URL: https://github.com/apache/flink/pull/14312#discussion_r551459508 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/translators/TwoInputTransformationTranslator.java ## @@ -46,7 +47,11

[GitHub] [flink] aljoscha commented on a change in pull request #14312: [FLINK-20491] Support Broadcast State in BATCH execution mode

2021-01-04 Thread GitBox
aljoscha commented on a change in pull request #14312: URL: https://github.com/apache/flink/pull/14312#discussion_r551366952 ## File path: docs/dev/datastream_execution_mode.md ## @@ -237,6 +237,35 @@ next key. See [FLIP-140](https://cwiki.apache.org/confluence/x/kDh4CQ) for b

[GitHub] [flink] aljoscha commented on a change in pull request #14312: [FLINK-20491] Support Broadcast State in BATCH execution mode

2021-01-04 Thread GitBox
aljoscha commented on a change in pull request #14312: URL: https://github.com/apache/flink/pull/14312#discussion_r551359341 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/sort/MultiInputSortingDataInput.java ## @@ -318,23 +346,40 @@

[GitHub] [flink] aljoscha commented on a change in pull request #14312: [FLINK-20491] Support Broadcast State in BATCH execution mode

2021-01-04 Thread GitBox
aljoscha commented on a change in pull request #14312: URL: https://github.com/apache/flink/pull/14312#discussion_r551357346 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/translators/TwoInputTransformationTranslator.java ## @@ -46,7 +47,11

[GitHub] [flink] aljoscha commented on a change in pull request #14312: [FLINK-20491] Support Broadcast State in BATCH execution mode

2021-01-04 Thread GitBox
aljoscha commented on a change in pull request #14312: URL: https://github.com/apache/flink/pull/14312#discussion_r551355827 ## File path: flink-tests/src/test/java/org/apache/flink/api/datastream/DataStreamBatchExecutionITCase.java ## @@ -180,6 +191,107 @@ public void batchSu

[GitHub] [flink] aljoscha commented on a change in pull request #14312: [FLINK-20491] Support Broadcast State in BATCH execution mode

2021-01-04 Thread GitBox
aljoscha commented on a change in pull request #14312: URL: https://github.com/apache/flink/pull/14312#discussion_r551353891 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/StreamTwoInputProcessorFactory.java ## @@ -90,24 +94,51 @@

[GitHub] [flink] aljoscha commented on a change in pull request #14312: [FLINK-20491] Support Broadcast State in BATCH execution mode

2021-01-04 Thread GitBox
aljoscha commented on a change in pull request #14312: URL: https://github.com/apache/flink/pull/14312#discussion_r551353423 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/StreamTwoInputProcessorFactory.java ## @@ -90,24 +94,51 @@

[GitHub] [flink] aljoscha commented on a change in pull request #14312: [FLINK-20491] Support Broadcast State in BATCH execution mode

2021-01-04 Thread GitBox
aljoscha commented on a change in pull request #14312: URL: https://github.com/apache/flink/pull/14312#discussion_r551351615 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/StreamMultipleInputProcessorFactory.java ## @@ -142,6 +148,7 @@ p

[GitHub] [flink] aljoscha commented on a change in pull request #14312: [FLINK-20491] Support Broadcast State in BATCH execution mode

2021-01-04 Thread GitBox
aljoscha commented on a change in pull request #14312: URL: https://github.com/apache/flink/pull/14312#discussion_r551349489 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/transformations/AbstractBroadcastStateTransformation.java ## @@ -0,0 +1,

[GitHub] [flink] aljoscha commented on a change in pull request #14312: [FLINK-20491] Support Broadcast State in BATCH execution mode

2021-01-04 Thread GitBox
aljoscha commented on a change in pull request #14312: URL: https://github.com/apache/flink/pull/14312#discussion_r551346465 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/BroadcastConnectedStream.java ## @@ -246,28 +246,36 @@ public

[GitHub] [flink] aljoscha commented on a change in pull request #14312: [FLINK-20491] Support Broadcast State in BATCH execution mode

2021-01-04 Thread GitBox
aljoscha commented on a change in pull request #14312: URL: https://github.com/apache/flink/pull/14312#discussion_r551345782 ## File path: docs/dev/datastream_execution_mode.md ## @@ -237,6 +237,35 @@ next key. See [FLIP-140](https://cwiki.apache.org/confluence/x/kDh4CQ) for b

[GitHub] [flink] aljoscha commented on a change in pull request #14312: [FLINK-20491] Support Broadcast State in BATCH execution mode

2020-12-20 Thread GitBox
aljoscha commented on a change in pull request #14312: URL: https://github.com/apache/flink/pull/14312#discussion_r546347104 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/StreamMultipleInputProcessorFactory.java ## @@ -143,7 +150,20 @@

[GitHub] [flink] aljoscha commented on a change in pull request #14312: [FLINK-20491] Support Broadcast State in BATCH execution mode

2020-12-18 Thread GitBox
aljoscha commented on a change in pull request #14312: URL: https://github.com/apache/flink/pull/14312#discussion_r545741434 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamNode.java ## @@ -84,7 +84,7 @@ private String tran

[GitHub] [flink] aljoscha commented on a change in pull request #14312: [FLINK-20491] Support Broadcast State in BATCH execution mode

2020-12-18 Thread GitBox
aljoscha commented on a change in pull request #14312: URL: https://github.com/apache/flink/pull/14312#discussion_r545737859 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamConfig.java ## @@ -735,4 +761,10 @@ public int hashCode() {

[GitHub] [flink] aljoscha commented on a change in pull request #14312: [FLINK-20491] Support Broadcast State in BATCH execution mode

2020-12-14 Thread GitBox
aljoscha commented on a change in pull request #14312: URL: https://github.com/apache/flink/pull/14312#discussion_r542271310 ## File path: docs/dev/datastream_execution_mode.md ## @@ -237,6 +237,36 @@ next key. See [FLIP-140](https://cwiki.apache.org/confluence/x/kDh4CQ) for b

[GitHub] [flink] aljoscha commented on a change in pull request #14312: [FLINK-20491] Support Broadcast State in BATCH execution mode

2020-12-10 Thread GitBox
aljoscha commented on a change in pull request #14312: URL: https://github.com/apache/flink/pull/14312#discussion_r540289201 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/translators/TwoInputTransformationTranslator.java ## @@ -45,7 +46,11

[GitHub] [flink] aljoscha commented on a change in pull request #14312: [FLINK-20491] Support Broadcast State in BATCH execution mode

2020-12-10 Thread GitBox
aljoscha commented on a change in pull request #14312: URL: https://github.com/apache/flink/pull/14312#discussion_r540218683 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/translators/TwoInputTransformationTranslator.java ## @@ -45,7 +46,11

[GitHub] [flink] aljoscha commented on a change in pull request #14312: [FLINK-20491] Support Broadcast State in BATCH execution mode

2020-12-10 Thread GitBox
aljoscha commented on a change in pull request #14312: URL: https://github.com/apache/flink/pull/14312#discussion_r540206319 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/sort/MultiInputSortingDataInput.java ## @@ -315,23 +342,40 @@