aljoscha commented on issue #8371: [FLINK-9679] - Add AvroSerializationSchema
URL: https://github.com/apache/flink/pull/8371#issuecomment-570554230
I merged, thanks a lot for your work and patience! 😅
This is an automated mess
aljoscha commented on issue #8371: [FLINK-9679] - Add AvroSerializationSchema
URL: https://github.com/apache/flink/pull/8371#issuecomment-570173617
I pushed a branch that squashes commits and adds some simplification. I'm
now working on extending `test_confluent_schema_registry.sh` to also
aljoscha commented on issue #8371: [FLINK-9679] - Add AvroSerializationSchema
URL: https://github.com/apache/flink/pull/8371#issuecomment-566041705
@Wosin could you please rebase on master and squash it into sensible
commits, as you would like to have them merged in the end.
--
aljoscha commented on issue #8371: [FLINK-9679] - Add AvroSerializationSchema
URL: https://github.com/apache/flink/pull/8371#issuecomment-559420365
By the way, I'm on the ASF slack workspace:
https://s.apache.org/slack-invite. You can ping me there so that we can resolve
reviews quicker. S
aljoscha commented on issue #8371: [FLINK-9679] - Add AvroSerializationSchema
URL: https://github.com/apache/flink/pull/8371#issuecomment-559020628
@Wosin Is there a reason `RegistryAvroSerializationSchema.serialize()` and
`ConfluentRegistryAvroSerializationSchema.serialize()` are different
aljoscha commented on issue #8371: [FLINK-9679] - Add AvroSerializationSchema
URL: https://github.com/apache/flink/pull/8371#issuecomment-555384761
There are build failures because of checkstyle:
https://travis-ci.com/flink-ci/flink/builds/137108234
aljoscha commented on issue #8371: [FLINK-9679] - Add AvroSerializationSchema
URL: https://github.com/apache/flink/pull/8371#issuecomment-542689920
@soumyasmruti So you're saying the PR in the current state does not work?
@Wosin Do you have a comment on that?
--
aljoscha commented on issue #8371: [FLINK-9679] - Add AvroSerializationSchema
URL: https://github.com/apache/flink/pull/8371#issuecomment-506282454
@Wosin could you please rebase and squash the various commits into some
commits that make sense, i.e. separate pre-requisites like version upgr
