[GitHub] [flink] aljoscha commented on pull request #11326: [FLINK-11427][formats] Add protobuf parquet support for StreamingFileSink

2020-10-12 Thread GitBox
aljoscha commented on pull request #11326: URL: https://github.com/apache/flink/pull/11326#issuecomment-707043968 Merged!  This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [flink] aljoscha commented on pull request #11326: [FLINK-11427][formats] Add protobuf parquet support for StreamingFileSink

2020-10-09 Thread GitBox
aljoscha commented on pull request #11326: URL: https://github.com/apache/flink/pull/11326#issuecomment-705600463 It seems the tests fail for this one. This is an automated message from the Apache Git Service. To respond to

[GitHub] [flink] aljoscha commented on pull request #11326: [FLINK-11427][formats] Add protobuf parquet support for StreamingFileSink

2020-10-08 Thread GitBox
aljoscha commented on pull request #11326: URL: https://github.com/apache/flink/pull/11326#issuecomment-705600463 It seems the tests fail for this one. This is an automated message from the Apache Git Service. To respond to

[GitHub] [flink] aljoscha commented on pull request #11326: [FLINK-11427][formats] Add protobuf parquet support for StreamingFileSink

2020-10-01 Thread GitBox
aljoscha commented on pull request #11326: URL: https://github.com/apache/flink/pull/11326#issuecomment-702031110 I think we should merge this after all. The code is very simple but if we provide it we avoid different users having to re-implement it in their own code. Plus, having the