aljoscha commented on pull request #12412:
URL: https://github.com/apache/flink/pull/12412#issuecomment-638275915
Thanks for the reviews! I'm merging
This is an automated message from the Apache Git Service.
To respond to the
aljoscha commented on pull request #12412:
URL: https://github.com/apache/flink/pull/12412#issuecomment-638170374
I would merge this to `release-1.11` as well,
https://issues.apache.org/jira/browse/FLINK-18011 is marked as a blocker for
Flink 1.11 and no-one has objected to this. I interpr
aljoscha commented on pull request #12412:
URL: https://github.com/apache/flink/pull/12412#issuecomment-637610435
I think I addressed all the comments, please take another look.
This is an automated message from the Apache Gi
aljoscha commented on pull request #12412:
URL: https://github.com/apache/flink/pull/12412#issuecomment-637589309
@StephanEwen Thanks for the review!
about 1) I had a version where `WatermarkStrategy` is an `abstract class`,
where the strategy implementations were final static priva
aljoscha commented on pull request #12412:
URL: https://github.com/apache/flink/pull/12412#issuecomment-636046671
By now I'm wondering wether we should make `WatermarkStrategy`
`@PublicEvolving`.
This is an automated message
