[GitHub] [flink] alpreu commented on a diff in pull request #19552: [FLINK-27185][connectors][formats] Convert formats and connectors modules to assertj

2022-05-02 Thread GitBox
alpreu commented on code in PR #19552: URL: https://github.com/apache/flink/pull/19552#discussion_r863507040 ## flink-formats/flink-csv/src/test/java/org/apache/flink/formats/csv/CsvRowDataSerDeSchemaTest.java: ## @@ -61,11 +61,9 @@ import static org.apache.flink.table.data.Str

[GitHub] [flink] alpreu commented on a diff in pull request #19552: [FLINK-27185][connectors][formats] Convert formats and connectors modules to assertj

2022-05-02 Thread GitBox
alpreu commented on code in PR #19552: URL: https://github.com/apache/flink/pull/19552#discussion_r863505977 ## flink-formats/flink-csv/src/test/java/org/apache/flink/formats/csv/CsvRowDataSerDeSchemaTest.java: ## @@ -358,12 +354,8 @@ public void testSerializationWithTypesMismat

[GitHub] [flink] alpreu commented on a diff in pull request #19552: [FLINK-27185][connectors][formats] Convert formats and connectors modules to assertj

2022-04-25 Thread GitBox
alpreu commented on code in PR #19552: URL: https://github.com/apache/flink/pull/19552#discussion_r857573227 ## flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaShortRetentionTestBase.java: ## @@ -286,7 +286,7 @@ public void r

[GitHub] [flink] alpreu commented on a diff in pull request #19552: [FLINK-27185][connectors][formats] Convert formats and connectors modules to assertj

2022-04-25 Thread GitBox
alpreu commented on code in PR #19552: URL: https://github.com/apache/flink/pull/19552#discussion_r857542559 ## flink-connectors/flink-connector-base/src/test/java/org/apache/flink/connector/base/source/reader/fetcher/SplitFetcherManagerTest.java: ## @@ -100,7 +93,7 @@ private f