[GitHub] [flink] architgyl commented on a diff in pull request #22509: [FLINK-31983] Add yarn Acls capability to Flink containers

2023-06-26 Thread via GitHub
architgyl commented on code in PR #22509: URL: https://github.com/apache/flink/pull/22509#discussion_r1242542478 ## flink-yarn/src/main/java/org/apache/flink/yarn/Utils.java: ## @@ -620,4 +626,46 @@ public static YarnConfiguration getYarnConfiguration( return yarnConf

[GitHub] [flink] architgyl commented on a diff in pull request #22509: [FLINK-31983] Add yarn Acls capability to Flink containers

2023-06-26 Thread via GitHub
architgyl commented on code in PR #22509: URL: https://github.com/apache/flink/pull/22509#discussion_r1242542217 ## .idea/vcs.xml: ## @@ -1,25 +0,0 @@ - Review Comment: Restored the file ## flink-yarn/src/main/java/org/apache/flink/yarn/configuration/YarnConfigOpt

[GitHub] [flink] architgyl commented on a diff in pull request #22509: [FLINK-31983] Add yarn Acls capability to Flink containers

2023-06-15 Thread via GitHub
architgyl commented on code in PR #22509: URL: https://github.com/apache/flink/pull/22509#discussion_r1231535045 ## flink-yarn/src/main/java/org/apache/flink/yarn/configuration/YarnConfigOptions.java: ## @@ -231,6 +231,27 @@ public class YarnConfigOptions {

[GitHub] [flink] architgyl commented on a diff in pull request #22509: [FLINK-31983] Add yarn Acls capability to Flink containers

2023-06-12 Thread via GitHub
architgyl commented on code in PR #22509: URL: https://github.com/apache/flink/pull/22509#discussion_r1227304307 ## flink-yarn-tests/src/test/java/org/apache/flink/yarn/YARNSessionFIFOITCase.java: ## @@ -60,6 +60,12 @@ class YARNSessionFIFOITCase extends YarnTestBase { pri

[GitHub] [flink] architgyl commented on a diff in pull request #22509: [FLINK-31983] Add yarn Acls capability to Flink containers

2023-06-08 Thread via GitHub
architgyl commented on code in PR #22509: URL: https://github.com/apache/flink/pull/22509#discussion_r1223335569 ## flink-yarn/src/main/java/org/apache/flink/yarn/Utils.java: ## @@ -620,4 +626,38 @@ public static YarnConfiguration getYarnConfiguration( return yarnConf

[GitHub] [flink] architgyl commented on a diff in pull request #22509: [FLINK-31983] Add yarn Acls capability to Flink containers

2023-05-10 Thread via GitHub
architgyl commented on code in PR #22509: URL: https://github.com/apache/flink/pull/22509#discussion_r1189439481 ## docs/layouts/shortcodes/generated/yarn_config_configuration.html: ## @@ -182,5 +182,15 @@ String Specify YARN node label for the Flink Ta

[GitHub] [flink] architgyl commented on a diff in pull request #22509: [FLINK-31983] Add yarn Acls capability to Flink containers

2023-05-09 Thread via GitHub
architgyl commented on code in PR #22509: URL: https://github.com/apache/flink/pull/22509#discussion_r1189438040 ## flink-yarn/src/main/java/org/apache/flink/yarn/configuration/YarnConfigOptions.java: ## @@ -231,6 +231,25 @@ public class YarnConfigOptions {

[GitHub] [flink] architgyl commented on a diff in pull request #22509: [FLINK-31983] Add yarn Acls capability to Flink containers

2023-05-09 Thread via GitHub
architgyl commented on code in PR #22509: URL: https://github.com/apache/flink/pull/22509#discussion_r1189437797 ## flink-yarn-tests/src/test/java/org/apache/flink/yarn/YARNSessionFIFOITCase.java: ## @@ -61,6 +61,9 @@ class YARNSessionFIFOITCase extends YarnTestBase { priv

[GitHub] [flink] architgyl commented on a diff in pull request #22509: [FLINK-31983] Add yarn Acls capability to Flink containers

2023-05-09 Thread via GitHub
architgyl commented on code in PR #22509: URL: https://github.com/apache/flink/pull/22509#discussion_r1189036465 ## flink-yarn/src/main/java/org/apache/flink/yarn/Utils.java: ## @@ -620,4 +623,30 @@ public static YarnConfiguration getYarnConfiguration( return yarnConf

[GitHub] [flink] architgyl commented on a diff in pull request #22509: [FLINK-31983] Add yarn Acls capability to Flink containers

2023-05-08 Thread via GitHub
architgyl commented on code in PR #22509: URL: https://github.com/apache/flink/pull/22509#discussion_r1187759775 ## docs/layouts/shortcodes/generated/yarn_config_configuration.html: ## @@ -182,5 +182,15 @@ String Specify YARN node label for the Flink Ta

[GitHub] [flink] architgyl commented on a diff in pull request #22509: [FLINK-31983] Add yarn Acls capability to Flink containers

2023-05-08 Thread via GitHub
architgyl commented on code in PR #22509: URL: https://github.com/apache/flink/pull/22509#discussion_r1187759775 ## docs/layouts/shortcodes/generated/yarn_config_configuration.html: ## @@ -182,5 +182,15 @@ String Specify YARN node label for the Flink Ta

[GitHub] [flink] architgyl commented on a diff in pull request #22509: [FLINK-31983] Add yarn Acls capability to Flink containers

2023-05-08 Thread via GitHub
architgyl commented on code in PR #22509: URL: https://github.com/apache/flink/pull/22509#discussion_r1187756546 ## docs/layouts/shortcodes/generated/yarn_config_configuration.html: ## @@ -182,5 +182,15 @@ String Specify YARN node label for the Flink Ta

[GitHub] [flink] architgyl commented on a diff in pull request #22509: [FLINK-31983] Add yarn Acls capability to Flink containers

2023-05-08 Thread via GitHub
architgyl commented on code in PR #22509: URL: https://github.com/apache/flink/pull/22509#discussion_r1187755439 ## flink-yarn/src/main/java/org/apache/flink/yarn/Utils.java: ## @@ -620,4 +623,30 @@ public static YarnConfiguration getYarnConfiguration( return yarnConf

[GitHub] [flink] architgyl commented on a diff in pull request #22509: [FLINK-31983] Add yarn Acls capability to Flink containers

2023-05-04 Thread via GitHub
architgyl commented on code in PR #22509: URL: https://github.com/apache/flink/pull/22509#discussion_r1185469043 ## flink-yarn-tests/src/test/java/org/apache/flink/yarn/YARNSessionFIFOITCase.java: ## @@ -61,6 +61,9 @@ class YARNSessionFIFOITCase extends YarnTestBase { priv

[GitHub] [flink] architgyl commented on a diff in pull request #22509: [FLINK-31983] Add yarn Acls capability to Flink containers

2023-05-03 Thread via GitHub
architgyl commented on code in PR #22509: URL: https://github.com/apache/flink/pull/22509#discussion_r1184309760 ## flink-yarn-tests/src/test/java/org/apache/flink/yarn/YARNSessionFIFOITCase.java: ## @@ -61,6 +61,9 @@ class YARNSessionFIFOITCase extends YarnTestBase { priv

[GitHub] [flink] architgyl commented on a diff in pull request #22509: [FLINK-31983] Add yarn Acls capability to Flink containers

2023-05-03 Thread via GitHub
architgyl commented on code in PR #22509: URL: https://github.com/apache/flink/pull/22509#discussion_r1184308688 ## flink-yarn/src/main/java/org/apache/flink/yarn/Utils.java: ## @@ -620,4 +623,30 @@ public static YarnConfiguration getYarnConfiguration( return yarnConf