[GitHub] [flink] ashmeet-kandhari commented on pull request #20991: [FLINK-25538][flink-connector-kafka] JUnit5 Migration

2023-06-29 Thread via GitHub
ashmeet-kandhari commented on PR #20991: URL: https://github.com/apache/flink/pull/20991#issuecomment-1613909720 Hi @sergey, Unfortunately, I will not be able to work on this due to some personal work. Better to reassign this task Regards, Ashmeet. On Fri, J

[GitHub] [flink] ashmeet-kandhari commented on pull request #20991: [FLINK-25538][flink-connector-kafka] JUnit5 Migration

2023-06-15 Thread via GitHub
ashmeet-kandhari commented on PR #20991: URL: https://github.com/apache/flink/pull/20991#issuecomment-1594034092 Hi @Sergey, I am on vacation and will be back in July. I can continue after that. Thanks Ashmeet On Tue, Jun 6, 2023, 13:11 Sergey Nuyanzin ***@***.*

[GitHub] [flink] ashmeet-kandhari commented on pull request #20991: [FLINK-25538][flink-connector-kafka] JUnit5 Migration

2023-02-03 Thread via GitHub
ashmeet-kandhari commented on PR #20991: URL: https://github.com/apache/flink/pull/20991#issuecomment-1416496203 Hi @snuyanzin I am thinking of creating new branch and start slowly -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [flink] ashmeet-kandhari commented on pull request #20991: [FLINK-25538][flink-connector-kafka] JUnit5 Migration

2022-12-15 Thread GitBox
ashmeet-kandhari commented on PR #20991: URL: https://github.com/apache/flink/pull/20991#issuecomment-1354074250 Hi @snuyanzin I am recently encountering issue, where I am not able to run tests. Any idea about this > [ERROR] Failed to execute goal org.apache.maven.plugins:m

[GitHub] [flink] ashmeet-kandhari commented on pull request #20991: [FLINK-25538][flink-connector-kafka] JUnit5 Migration

2022-12-15 Thread GitBox
ashmeet-kandhari commented on PR #20991: URL: https://github.com/apache/flink/pull/20991#issuecomment-1354073289 Hi @snuyanzin , I have given you access to my repo. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [flink] ashmeet-kandhari commented on pull request #20991: [FLINK-25538][flink-connector-kafka] JUnit5 Migration

2022-12-11 Thread GitBox
ashmeet-kandhari commented on PR #20991: URL: https://github.com/apache/flink/pull/20991#issuecomment-1345624195 > hi @ashmeet-kandhari thanks for conflicts resolution I left some comments (i didn't go through the whole changeset) however there are several types of things which

[GitHub] [flink] ashmeet-kandhari commented on pull request #20991: [FLINK-25538][flink-connector-kafka] JUnit5 Migration

2022-12-08 Thread GitBox
ashmeet-kandhari commented on PR #20991: URL: https://github.com/apache/flink/pull/20991#issuecomment-1342895879 Hi @snuyanzin, I am on vacation and didn't have access to my laptop. Will address the comments by this weekend. Thanks for waiting :) -- This is an automated me

[GitHub] [flink] ashmeet-kandhari commented on pull request #20991: [FLINK-25538][flink-connector-kafka] JUnit5 Migration

2022-11-23 Thread GitBox
ashmeet-kandhari commented on PR #20991: URL: https://github.com/apache/flink/pull/20991#issuecomment-1325605146 Hi @snuyanzin, I have resolved the conflicts. Please review it, whenever you can -- This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [flink] ashmeet-kandhari commented on pull request #20991: [FLINK-25538][flink-connector-kafka] JUnit5 Migration

2022-11-22 Thread GitBox
ashmeet-kandhari commented on PR #20991: URL: https://github.com/apache/flink/pull/20991#issuecomment-1323938824 Doesn't show any diff, I tried checking the history as well and shows nothing ![image](https://user-images.githubusercontent.com/37675804/203368442-7e42d3cb-8e2c-4a49-a195-a

[GitHub] [flink] ashmeet-kandhari commented on pull request #20991: [FLINK-25538][flink-connector-kafka] JUnit5 Migration

2022-11-22 Thread GitBox
ashmeet-kandhari commented on PR #20991: URL: https://github.com/apache/flink/pull/20991#issuecomment-1323920168 Oh not sure why are they here, but this is what I found from the rat.txt logs ``` 14 Unknown Licenses *

[GitHub] [flink] ashmeet-kandhari commented on pull request #20991: [FLINK-25538][flink-connector-kafka] JUnit5 Migration

2022-11-22 Thread GitBox
ashmeet-kandhari commented on PR #20991: URL: https://github.com/apache/flink/pull/20991#issuecomment-1323914415 Hi @snuyanzin I tried resolving the conflicts (haven't pushed yet), but when I try to build locally getting the following error ``` Too many files with unapprov

[GitHub] [flink] ashmeet-kandhari commented on pull request #20991: [FLINK-25538][flink-connector-kafka] JUnit5 Migration

2022-11-10 Thread GitBox
ashmeet-kandhari commented on PR #20991: URL: https://github.com/apache/flink/pull/20991#issuecomment-1310983666 Hi @snuyanzin Can you re-check this PR once -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [flink] ashmeet-kandhari commented on pull request #20991: [FLINK-25538][flink-connector-kafka] JUnit5 Migration

2022-11-04 Thread GitBox
ashmeet-kandhari commented on PR #20991: URL: https://github.com/apache/flink/pull/20991#issuecomment-1303971800 Hi @snuyanzin I have made changes for the comments added. Let me know if anything else is there -- This is an automated message from the Apache Git Service. To re

[GitHub] [flink] ashmeet-kandhari commented on pull request #20991: [FLINK-25538][flink-connector-kafka] JUnit5 Migration

2022-10-15 Thread GitBox
ashmeet-kandhari commented on PR #20991: URL: https://github.com/apache/flink/pull/20991#issuecomment-1279718997 > Thanks for your contribution @ashmeet-kandhari As I mentioned in jira issue we could continue code related discussions here > > Could you please share more detail/link to